feat!: Migrate CloudFlare plugin to v2#1777
Merged
disq merged 26 commits intocloudquery:mainfrom Sep 16, 2022
Merged
Conversation
5393bf9 to
96e8b3c
Compare
28d1640 to
5bce68e
Compare
hermanschaaf
suggested changes
Sep 9, 2022
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
Left a couple of comments; nothing major. I haven't gone through all the resources yet :)
hermanschaaf
reviewed
Sep 9, 2022
hermanschaaf
reviewed
Sep 9, 2022
hermanschaaf
approved these changes
Sep 9, 2022
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
yevgenypats
suggested changes
Sep 11, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Can you please open a new cloudflare test account to manually test it?
Member
Author
tested, works |
yevgenypats
suggested changes
Sep 13, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Looks good but I'd like the codegen to look more like in aws and gcp #1774. i.e split to files and avoid parent,combine and other functional utility functional to make it easier to maintain (imo). if something has relations the convention is to put the relation in it's own file (see aws)
Member
Author
Updated. |
erezrokah
approved these changes
Sep 15, 2022
erezrokah
approved these changes
Sep 15, 2022
erezrokah
reviewed
Sep 15, 2022
erezrokah
reviewed
Sep 15, 2022
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
yevgenypats
approved these changes
Sep 15, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
🤖 I have created a release *beep* *boop* --- ## [0.2.0-pre.0](plugins/source/cloudflare-v0.1.7-pre.0...plugins/source/cloudflare/v0.2.0-pre.0) (2022-09-21) ### ⚠ BREAKING CHANGES * Migrate CloudFlare plugin to v2 (#1777) ### Features * Add Sentry DSN ([#1913](#1913)) ([5cc036e](5cc036e)) * Migrate CloudFlare plugin to v2 ([#1777](#1777)) ([ea6735b](ea6735b)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.10 ([#1474](#1474)) ([b142e13](b142e13)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.11 ([#1491](#1491)) ([5140bef](5140bef)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.12 ([#1503](#1503)) ([a740719](a740719)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.9 ([#1286](#1286)) ([67ac422](67ac422)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.2 ([#1838](#1838)) ([5b16c59](5b16c59)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.3 ([#1858](#1858)) ([9e3ace7](9e3ace7)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.4 ([#1862](#1862)) ([5d141cf](5d141cf)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.2 ([#1872](#1872)) ([49ed26d](49ed26d)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.3 ([#1886](#1886)) ([7435d59](7435d59)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.4 ([#1889](#1889)) ([63a5362](63a5362)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.9 ([#1891](#1891)) ([3469f20](3469f20)) * **deps:** Update to Go 1.18 ([#1292](#1292)) ([9b96c8f](9b96c8f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah
added a commit
that referenced
this pull request
Oct 4, 2022
🤖 I have created a release *beep* *boop* --- ## [1.0.0](plugins-source-cloudflare-v0.9.9...plugins-source-cloudflare-v1.0.0) (2022-10-04) ### ⚠ BREAKING CHANGES * Official v1 release (#2335) * Migrate CloudFlare plugin to v2 (#1777) ### Features * Add Sentry DSN ([#1913](#1913)) ([5cc036e](5cc036e)) * Migrate CloudFlare plugin to v2 ([#1777](#1777)) ([ea6735b](ea6735b)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.10.2 ([#2048](#2048)) ([e407991](e407991)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.0 ([#2135](#2135)) ([1729467](1729467)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.2 ([#2162](#2162)) ([5701aa5](5701aa5)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.4 ([#2211](#2211)) ([898b11e](898b11e)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.5 ([#2228](#2228)) ([a0670f3](a0670f3)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.2 ([#1838](#1838)) ([5b16c59](5b16c59)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.3 ([#1858](#1858)) ([9e3ace7](9e3ace7)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.4 ([#1862](#1862)) ([5d141cf](5d141cf)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.12 ([#1916](#1916)) ([27d8153](27d8153)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.2 ([#1872](#1872)) ([49ed26d](49ed26d)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.3 ([#1886](#1886)) ([7435d59](7435d59)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.4 ([#1889](#1889)) ([63a5362](63a5362)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.9 ([#1891](#1891)) ([3469f20](3469f20)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.0 ([#1997](#1997)) ([4fa40da](4fa40da)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.1 ([#2024](#2024)) ([8f88de4](8f88de4)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.2 ([#2044](#2044)) ([9b69b46](9b69b46)) * **deps:** Update plugin-sdk for cloudflare to v0.11.6 ([#2254](#2254)) ([0ab9847](0ab9847)) * Update all source plugin to v0.12.2 ([#2316](#2316)) ([5099dcf](5099dcf)) ### Miscellaneous Chores * Official v1 release ([#2335](#2335)) ([e32de23](e32de23)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: erezrokah <erezrokah@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of first commit, resource schemas are not migrated yet.Untested but compiles/lints.