feat!: Migrate GitHub plugin to v2#1776
Merged
candiduslynx merged 60 commits intomainfrom Sep 20, 2022
Merged
Conversation
hermanschaaf
suggested changes
Sep 8, 2022
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
I didn't review all the resources in great detail (I think we can merge and fix any issues as they come up). Overall it looks good 👍 I just left a couple of comments
yevgenypats
suggested changes
Sep 12, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Given we have some more time for v2 release, let's introduce the new codegen. We only generate the structs and the resolvers should go into resource_fetch.go. See example - #1774
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
51f3bc1 to
cf0c4c1
Compare
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
b72fb05 to
5155bcb
Compare
…/cloudquery into feature/github/new-plugin-sdk
hermanschaaf
approved these changes
Sep 20, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
🤖 I have created a release *beep* *boop* --- ## [0.1.11-pre.0](plugins/source/github-v0.1.10-pre.0...plugins/source/github/v0.1.11-pre.0) (2022-09-21) ### Features * Migrate GitHub plugin to v2 ([#1776](#1776)) ([217609b](217609b)) ### Bug Fixes * **deps:** Update golang.org/x/oauth2 digest to 0ebed06 ([#1651](#1651)) ([c31b001](c31b001)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.10 ([#1474](#1474)) ([b142e13](b142e13)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.11 ([#1491](#1491)) ([5140bef](5140bef)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.12 ([#1503](#1503)) ([a740719](a740719)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.9 ([#1286](#1286)) ([67ac422](67ac422)) * Validate github config ([#1438](#1438)) ([8d37fc4](8d37fc4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)