Skip to content

Add query type support#176

Merged
roneli merged 6 commits intocloudquery:mainfrom
irmatov:add_query_type
Sep 9, 2021
Merged

Add query type support#176
roneli merged 6 commits intocloudquery:mainfrom
irmatov:add_query_type

Conversation

@irmatov
Copy link
Copy Markdown
Contributor

@irmatov irmatov commented Aug 16, 2021

Query can have a field named "type" which defaults to "automatic".
Another possible value is "manual".

CLI result output will highlight manual query results with warning
emoji and text.

Query can have a field named "type" which defaults to "automatic".
Another possible value is "manual".

CLI result output will highlight manual queries results with warning
emoji and text.
@irmatov irmatov requested review from michelvocks and roneli August 16, 2021 13:23
@irmatov
Copy link
Copy Markdown
Contributor Author

irmatov commented Aug 16, 2021

Closes cloudquery/cloudquery-issues#85

Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would suggest one change with the normalize/validate moving it to part of the policy config parsing phase.

Copy link
Copy Markdown
Contributor

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irmatov irmatov requested a review from roneli September 8, 2021 14:04
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roneli roneli merged commit 5bf3b9a into cloudquery:main Sep 9, 2021
@irmatov irmatov deleted the add_query_type branch September 15, 2021 12:49
@cq-bot cq-bot mentioned this pull request Aug 9, 2022
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
…11.3 (#176)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/cloudquery/cq-provider-sdk](https://togithub.com/cloudquery/cq-provider-sdk) | require | patch | `v0.11.2` -> `v0.11.3` |

---

### Release Notes

<details>
<summary>cloudquery/cq-provider-sdk</summary>

### [`v0.11.3`](https://togithub.com/cloudquery/cq-provider-sdk/releases/tag/v0.11.3)

[Compare Source](https://togithub.com/cloudquery/cq-provider-sdk/compare/v0.11.2...v0.11.3)

##### Bug Fixes

-   Windows sysctl call ([#&#8203;340](https://togithub.com/cloudquery/cq-provider-sdk/issues/340)) ([464529d](https://togithub.com/cloudquery/cq-provider-sdk/commit/464529dfd4ca6cd57dc492c757149a898bc72790))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
🤖 I have created a release *beep* *boop*
---


## [0.5.9](cloudquery/cq-provider-k8s@v0.5.8...v0.5.9) (2022-06-15)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.2 ([#174](cloudquery/cq-provider-k8s#174)) ([8496fae](cloudquery/cq-provider-k8s@8496fae))
* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.3 ([#176](cloudquery/cq-provider-k8s#176)) ([cc27338](cloudquery/cq-provider-k8s@cc27338))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
🤖 I have created a release *beep* *boop*
---


## [0.5.19](cloudquery/cq-provider-digitalocean@v0.5.18...v0.5.19) (2022-07-03)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.13.1 ([#175](cloudquery/cq-provider-digitalocean#175)) ([f970c4b](cloudquery/cq-provider-digitalocean@f970c4b))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
…14.4 (#176)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/cloudquery/cq-provider-sdk](https://togithub.com/cloudquery/cq-provider-sdk) | require | patch | `v0.14.3` -> `v0.14.4` |

---

### Release Notes

<details>
<summary>cloudquery/cq-provider-sdk</summary>

### [`v0.14.4`](https://togithub.com/cloudquery/cq-provider-sdk/releases/tag/v0.14.4)

[Compare Source](https://togithub.com/cloudquery/cq-provider-sdk/compare/v0.14.3...v0.14.4)

##### Bug Fixes

-   Add support for int32 and int64 array types ([#&#8203;433](https://togithub.com/cloudquery/cq-provider-sdk/issues/433)) ([7d4624d](https://togithub.com/cloudquery/cq-provider-sdk/commit/7d4624dbfed7c02482d7d1ef083275b0f8eb257b))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants