Skip to content

Update CLI help for provider command#174

Merged
yevgenypats merged 3 commits intocloudquery:mainfrom
irmatov:update_provider_help
Aug 15, 2021
Merged

Update CLI help for provider command#174
yevgenypats merged 3 commits intocloudquery:mainfrom
irmatov:update_provider_help

Conversation

@irmatov
Copy link
Copy Markdown
Contributor

@irmatov irmatov commented Aug 11, 2021

No description provided.

@irmatov irmatov requested review from roneli and yevgenypats August 11, 2021 07:05
@irmatov irmatov mentioned this pull request Aug 11, 2021
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @yevgenypats any comments?

Copy link
Copy Markdown
Contributor

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few wording changes suggestions.

cmd/provider.go Outdated
"github.com/spf13/cobra"
)

var providerHelpMsg = "Provider command that unifies provider subcommands."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"top-level command to interact with providers"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

cmd/provider.go Outdated
Short: providerHelpMsg,
Long: providerHelpMsg,
Example: `
# Downloads all providers mentioned in the configuration file:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloads all providers specified in config.hcl:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

"github.com/spf13/viper"
)

var providerDownloadHelpMsg = "Downloads all providers mentioned in the configuration file."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloads all providers specified in config.hcl

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Short: providerDownloadHelpMsg,
Long: providerDownloadHelpMsg,
Example: `
# Downloads all providers mentioned in the configuration file:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloads all providers specified in config.hcl

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@irmatov irmatov requested a review from yevgenypats August 11, 2021 08:25
@yevgenypats yevgenypats merged commit 1bbd440 into cloudquery:main Aug 15, 2021
@irmatov irmatov deleted the update_provider_help branch August 16, 2021 13:05
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
…11.2 (#174)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/cloudquery/cq-provider-sdk](https://togithub.com/cloudquery/cq-provider-sdk) | require | patch | `v0.11.1` -> `v0.11.2` |

---

### Release Notes

<details>
<summary>cloudquery/cq-provider-sdk</summary>

### [`v0.11.2`](https://togithub.com/cloudquery/cq-provider-sdk/releases/tag/v0.11.2)

[Compare Source](https://togithub.com/cloudquery/cq-provider-sdk/compare/v0.11.1...v0.11.2)

##### Features

-   Calculate max goroutines based on file limit ([#&#8203;337](https://togithub.com/cloudquery/cq-provider-sdk/issues/337)) ([fb429b8](https://togithub.com/cloudquery/cq-provider-sdk/commit/fb429b882599ff88c1032e7509d6034a12af5147))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
🤖 I have created a release *beep* *boop*
---


## [0.5.9](cloudquery/cq-provider-k8s@v0.5.8...v0.5.9) (2022-06-15)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.2 ([#174](cloudquery/cq-provider-k8s#174)) ([8496fae](cloudquery/cq-provider-k8s@8496fae))
* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.3 ([#176](cloudquery/cq-provider-k8s#176)) ([cc27338](cloudquery/cq-provider-k8s@cc27338))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
🤖 I have created a release *beep* *boop*
---


## [0.5.18](cloudquery/cq-provider-digitalocean@v0.5.17...v0.5.18) (2022-06-30)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.13.0 ([#173](cloudquery/cq-provider-digitalocean#173)) ([7088abf](cloudquery/cq-provider-digitalocean@7088abf))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants