feat!: Remove unique constraints in append mode #17129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
reviewed
Mar 13, 2024
Member
erezrokah
left a comment
There was a problem hiding this comment.
What's the reason this is a breaking change? How removing the unique constraint can break existing configurations/syncs?
disq
approved these changes
Mar 28, 2024
68c55ec to
2680cb0
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
🤖 I have created a release *beep* *boop* --- ## [6.0.0](cli-v5.25.1...cli-v6.0.0) (2024-07-18) ### ⚠ BREAKING CHANGES * Change `skip_dependent_tables` default from `false` to `true` ([#18191](#18191)), to avoid new tables implicitly being synced when added to plugins. See more in the [reference docs](https://docs.cloudquery.io/docs/reference/source-spec#skip_dependent_tables) * Remove unique constraints in append mode ([#17129](#17129)). This should not be breaking for most destinations (based on our tests, only DuckDB since it does not support removal of unique constraints), and will allow syncs to work when append mode is configured and the source schema has a unique constraint on a column. ### Features * Change `skip_dependent_tables` default from `false` to `true` ([#18191](#18191)) ([3c86963](3c86963)) * Remove unique constraints in append mode ([#17129](#17129)) ([4aeb94e](4aeb94e)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.12.2 ([#18584](#18584)) ([d38ac1b](d38ac1b)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.20.5 ([#18590](#18590)) ([5bfa3ca](5bfa3ca)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.20.6 ([#18593](#18593)) ([64cbb9a](64cbb9a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a destination is using
appendmode there should be no constraints on any column. Prior to this change inappendmode we would only remove the Primary Key, but now we are also removing theuniqueconstraints.BEGIN_COMMIT_OVERRIDE
feat!: Remove unique constraints in append mode (#17129)
BREAKING-CHANGE: Remove unique constraints in append mode (#17129). This should not be breaking for most destinations (based on our tests, only DuckDB since it does not support removal of unique constraints), and will allow syncs to work when append mode is configured and the source schema has a unique constraint on a column.
END_COMMIT_OVERRIDE