test: Add more cmd tests#1696
Merged
yevgenypats merged 1 commit intofeat/cloudquery-cli-v2from Sep 1, 2022
Merged
Conversation
hermanschaaf
reviewed
Sep 1, 2022
| } | ||
| defer os.RemoveAll(tmpdir) | ||
| cmd := newCmdRoot() | ||
| cmd.SetArgs([]string{"doc", tmpdir}) |
Contributor
There was a problem hiding this comment.
I didn't know about the doc command, should it be listed in the list of available commands?
Usage:
cloudquery [command]
Available Commands:
completion Generate the autocompletion script for the specified shell
generate Generate initial config file for source and destination plugins
sync Sync resources from configured source plugins to destination
Contributor
Author
There was a problem hiding this comment.
I think it shouldn't because it's mainly for our website. I don't see a user using this
Contributor
There was a problem hiding this comment.
Yeah me neither... but in that case we should probably find a better way of generating the files for the website, no need to ship it with our cli.
Contributor
There was a problem hiding this comment.
(not a priority, just a side comment)
hermanschaaf
approved these changes
Sep 1, 2022
yevgenypats
added a commit
that referenced
this pull request
Sep 6, 2022
test: Add more tests to cli
yevgenypats
added a commit
that referenced
this pull request
Sep 6, 2022
* feat!: CloudQuery V2. goes together with cloudquery/plugin-sdk#4 This is V2 of CloudQuery CLI together with the new https://github.com/cloudquery/plugin-sdk - Support for multiple databases. plugins are sending info back to CLI - seperate CLI configuration from plugins configuration. - Moved to plain gRPC (no more go-plugin) - zerolog everwhere - no custom UI implementations - no bloated/unneeded abstraction layers Issues that should be fixed: #1104 #1055 #983 #859 #858 #888 #857 #854 #904 #751 #539 #392 #292 #159 #908 #840 * migrate gcp to new sdk * work on a new abstraction layer for codegen * re-implement cq-gen * Add autogenerated mock tests * auto generated compute service * working compute service * regenerated gcp with compute with primary key * Add automigrate to postgresql-dest * small logging fix * improve pg tests * more work * pg storage working with upsert * wip * Compiled resources * autogenerated test passing * remove old gcp services * remove more old services * migrate more gcp services * PostgreSQL fixes * fix pg migration * working on more tests * remove old gcp workflows * more tests * Adding more tests * rebase more or less worked * remove replace directive * more go lint fixes * update plugin-sdk * make gcp compile * fix more linters * fix race condition bug with plugin hanging * bugfix in community plugins * fix plugin tests * fix: Show help on parsing errors * fix review * feat: Remove unique from PostgreSQL destination * remove the need for deprecated errors package * feat: Write to config file instead of stdout (v2) (#1645) * feat: Write to config file instead of stdout * Update SDK to v0.0.10 and remove unique constraints * Add more assertions to generate test * Write to stdout * clarify if statement * fix: pgx_log_level not mandatory * feat: Add errors/warnings summary * test: Add more cmd tests (#1696) test: Add more tests to cli * chore: Remove old test file * feat: Add example of list/detail codegen (#1706) * feat: Add example of list/detail codegen * make naming more reasonable * finalizing gcp * finalize gcp migration * feat: New go sdk for gcp (#1720) * update to latest sdk * feat: Move to new SDK * more fixes to autogeneration * more fixes to gcp * feat: Add sentry * remove old faker * go mod tidy * fix cli tests Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding more tests. and also moving cmd tests to run via rootCmd so we can get full coverage and know that the basic commands are working.
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)