test: Add workflow runs/usage/jobs mock test#14641
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Oct 18, 2023
Merged
test: Add workflow runs/usage/jobs mock test#14641kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
erezrokah
commented
Oct 18, 2023
| listWorkflowJobOptions := &github.ListWorkflowJobsOptions{Filter: "all", ListOptions: *listOpts} | ||
| for { | ||
| workflowJobs, resp, err := c.Github.Actions.ListWorkflowJobs(ctx, c.Org, *repo.Name, *run.ID, listWorkflowJobOptions) | ||
| workflowJobs, resp, err := c.Github.Actions.ListWorkflowJobs(ctx, *repo.Owner.Login, *repo.Name, *run.ID, listWorkflowJobOptions) |
Member
Author
There was a problem hiding this comment.
This is how we do it in most places (access the owner via the repo). It should be the same as accessing the org directly
candiduslynx
approved these changes
Oct 18, 2023
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
#### Summary Follow up to cloudquery#14529 that adds a mock test <!--
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #14529 that adds a mock test