Skip to content

doc: Status badges to readme#14535

Merged
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom
R3DRUN3:main
Oct 16, 2023
Merged

doc: Status badges to readme#14535
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom
R3DRUN3:main

Conversation

@R3DRUN3
Copy link
Copy Markdown
Contributor

@R3DRUN3 R3DRUN3 commented Oct 15, 2023

Summary

Safe to merge PR
added license, go report, ci and latest release status badges to readme to improve docs quality.
Take a look at the edited readme in my fork.

…dges

Signed-off-by: r3drun3 <simone.ragonesi@sighup.io>
@R3DRUN3 R3DRUN3 changed the title Add status badges to readme doc: status badges to readme Oct 15, 2023
@R3DRUN3 R3DRUN3 changed the title doc: status badges to readme doc: Status badges to readme Oct 15, 2023
@candiduslynx
Copy link
Copy Markdown
Contributor

Hi @R3DRUN3!
Thanks for the PR, it looks great!

Just one thing I'd like to change: we have a monorepo here, so the latest release will point sometimes to some plugins, sometimes to CLI. Is it possible to get the latest CLI release only? We tag them in a specific pattern, so it'll be easy to query.

Copy link
Copy Markdown
Contributor

@candiduslynx candiduslynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to figure out a way to point only to the CLI release (or drop the release badge altogether)

Signed-off-by: r3drun3 <simone.ragonesi@sighup.io>
@R3DRUN3
Copy link
Copy Markdown
Contributor Author

R3DRUN3 commented Oct 16, 2023

Need to figure out a way to point only to the CLI release (or drop the release badge altogether)

@candiduslynx unfortunately, it appears that there is no straightforward and efficient method for selectively referencing only the CLI releases.
Consequently, I have removed the badge for the latest release.

@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Oct 16, 2023
@kodiakhq kodiakhq bot merged commit 1f16e68 into cloudquery:main Oct 16, 2023
hydratim pushed a commit to hydratim/cloudquery that referenced this pull request Oct 20, 2023
#### Summary
*Safe to merge PR*  
added `license`, `go report`, `ci` and `latest release` status badges to readme to improve docs quality.  
Take a look at the edited readme in [my fork](https://github.com/R3DRUN3/cloudquery/blob/main/README.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants