chore: Update Go Releaser commands to not use deprecated features#14520
Merged
erezrokah merged 2 commits intocloudquery:mainfrom Oct 13, 2023
Merged
Conversation
disq
approved these changes
Oct 13, 2023
Member
Author
|
Tests are failing since I opened this PR from a fork so it's missing some secrets to run the tests |
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
…oudquery#14520) <!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 --> #### Summary We've been getting warnings from Go Releaser during publish since we use deprecated features: 1. `brews.tap` was renamed to `brews.repository`: https://goreleaser.com/deprecations/#krewsindex 2. `--skip-*` was merged into a single flag: https://goreleaser.com/deprecations/#active-deprecation-notices <!-- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md) 🧑🎓 - [ ] Run `make lint` to ensure the proposed changes follow the coding style 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Run `make test` to ensure the proposed changes pass the tests 🧪 - [ ] If changing a source plugin run `make gen` to ensure docs are up to date 📝 - [ ] Ensure the status checks below are successful ✅ --->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We've been getting warnings from Go Releaser during publish since we use deprecated features:
brews.tapwas renamed tobrews.repository: https://goreleaser.com/deprecations/#krewsindex--skip-*was merged into a single flag: https://goreleaser.com/deprecations/#active-deprecation-notices