chore: Move AWS docs to MD from MDX#14505
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Oct 12, 2023
Merged
Conversation
erezrokah
commented
Oct 12, 2023
| "react-hot-toast": "2.4.0", | ||
| "react-search-box": "^3.0.0", | ||
| "remark-directive": "^3.0.0", | ||
| "remark-directive": "^2.0.0", |
Member
Author
There was a problem hiding this comment.
Had to downgrade this package so it's compatible with Nextra built-in packages for rendering markdown
erezrokah
commented
Oct 12, 2023
| @@ -117,9 +115,9 @@ This is the (nested) spec used by the AWS source plugin. | |||
| Currently only `aws_costexplorer*` and `aws_alpha_cloudwatch_metric*` tables require this flag to be set to `true`. | |||
|
|
|||
|
|
|||
| <Callout type="warn"> | |||
Member
Author
There was a problem hiding this comment.
warn was a bug, the correct type is warning
erezrokah
commented
Oct 12, 2023
| const pluginTitle = (plugin) => title(plugin.replace(/-/g, " ")); | ||
|
|
||
| const getData = (pluginsDir, plugin) => { | ||
| const readPluginOverview = (pluginsDir, plugin) => { |
Member
Author
There was a problem hiding this comment.
I missed this in #14484. We read the overview.mdx file to get the title and stage for https://www.cloudquery.io/docs/plugins/sources/overview and https://www.cloudquery.io/docs/plugins/destinations/overview
candiduslynx
approved these changes
Oct 12, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
#### Summary Follow up to #14505. We should use a plain MD comment instead of an MDX one <!--
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
#### Summary Same as cloudquery#14484 for AWS. Part of https://github.com/cloudquery/cloud/issues/457 (internal issue). <!--
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
#### Summary Follow up to cloudquery#14505. We should use a plain MD comment instead of an MDX one <!--
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same as #14484 for AWS. Part of https://github.com/cloudquery/cloudquery-issues/issues/620 (internal issue).