Conversation
erezrokah
commented
Oct 9, 2023
erezrokah
commented
Oct 9, 2023
Member
Author
|
Now it's failing since we reached the rate limits with the GitHub actions built-in token 😞 |
Member
Author
|
Going to merge to unblock the CI |
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
<!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 --> #### Summary Not sure why this started failing with https://github.com/cloudquery/cloudquery/actions/runs/6446477635/job/17501705513?pr=14457#step:4:20. So I'm updating the version to the latest commit to see if that fixes it. Seems like updating the version worked but I also need to fix some glob patterns <!-- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md) 🧑🎓 - [ ] Run `make lint` to ensure the proposed changes follow the coding style 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Run `make test` to ensure the proposed changes pass the tests 🧪 - [ ] If changing a source plugin run `make gen` to ensure docs are up to date 📝 - [ ] Ensure the status checks below are successful ✅ --->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Not sure why this started failing with https://github.com/cloudquery/cloudquery/actions/runs/6446477635/job/17501705513?pr=14457#step:4:20.
So I'm updating the version to the latest commit to see if that fixes it.
Seems like updating the version worked but I also need to fix some glob patterns