Skip to content

skip versioning flag added for policy run#144

Merged
amanenk merged 3 commits intocloudquery:mainfrom
amanenk:skip-versioning
Jul 9, 2021
Merged

skip versioning flag added for policy run#144
amanenk merged 3 commits intocloudquery:mainfrom
amanenk:skip-versioning

Conversation

@amanenk
Copy link
Copy Markdown
Contributor

@amanenk amanenk commented Jul 9, 2021

No description provided.

@roneli roneli requested a review from michelvocks July 9, 2021 07:17
Copy link
Copy Markdown
Contributor

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small suggestion.

config.CloudQuery.PolicyDirectory = dir
}
}
config.CloudQuery.SkipVersioning = viper.GetBool("skip-versioning")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not required since you don't set a viper.BindPFlag. This flag should be also only required if you run a policy so a command argument is enough (IMO).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

@amanenk amanenk merged commit d988292 into cloudquery:main Jul 9, 2021
@cq-bot cq-bot mentioned this pull request Aug 9, 2022
erezrokah pushed a commit that referenced this pull request Aug 14, 2022

#### Summary

<!--
Explain what problem this PR addresses
-->

---
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
🤖 I have created a release *beep* *boop*
---


## [0.5.10](cloudquery/cq-provider-digitalocean@v0.5.9...v0.5.10) (2022-06-16)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.2 ([#145](cloudquery/cq-provider-digitalocean#145)) ([0bb8f91](cloudquery/cq-provider-digitalocean@0bb8f91))
* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.3 ([#147](cloudquery/cq-provider-digitalocean#147)) ([c3d4c48](cloudquery/cq-provider-digitalocean@c3d4c48))
* Registry not found on Registry.Get ([#144](cloudquery/cq-provider-digitalocean#144)) ([74c455a](cloudquery/cq-provider-digitalocean@74c455a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
🤖 I have created a release *beep* *boop*
---


## [0.5.13](cloudquery/cq-provider-okta@v0.5.12...v0.5.13) (2022-06-27)


### Bug Fixes

* **deps:** fix(deps): Update module github.com/cloudquery/cq-provider-sdk to v0.12.4 ([#143](cloudquery/cq-provider-okta#143)) ([422ad4f](cloudquery/cq-provider-okta@422ad4f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
…14.3 (#144)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/cloudquery/cq-provider-sdk](https://togithub.com/cloudquery/cq-provider-sdk) | require | patch | `v0.14.2` -> `v0.14.3` |

---

### Release Notes

<details>
<summary>cloudquery/cq-provider-sdk</summary>

### [`v0.14.3`](https://togithub.com/cloudquery/cq-provider-sdk/releases/tag/v0.14.3)

[Compare Source](https://togithub.com/cloudquery/cq-provider-sdk/compare/v0.14.2...v0.14.3)

##### Bug Fixes

-   Fix bug in ValueTypeFromString ([#&#8203;430](https://togithub.com/cloudquery/cq-provider-sdk/issues/430)) ([6ae324e](https://togithub.com/cloudquery/cq-provider-sdk/commit/6ae324ea2adeb9e0f83c523ab73c6f827db17bec))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants