fix: Don't stop on error for Regional WebACL Resources#14045
Merged
kodiakhq[bot] merged 3 commits intomainfrom Sep 27, 2023
Merged
fix: Don't stop on error for Regional WebACL Resources#14045kodiakhq[bot] merged 3 commits intomainfrom
kodiakhq[bot] merged 3 commits intomainfrom
Conversation
2 tasks
hermanschaaf
approved these changes
Sep 27, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
🤖 I have created a release *beep* *boop* --- ## [22.13.1](plugins-source-aws-v22.13.0...plugins-source-aws-v22.13.1) (2023-09-27) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.11.1 ([#14063](#14063)) ([5a0ff7b](5a0ff7b)) * Don't stop on error for Regional WebACL Resources ([#14045](#14045)) ([33ab5b0](33ab5b0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I debated between appending the error and just skipping the specific error that that is returned. I chose to append the error because the error that is thrown doesn't seem to be unique to the fact that the region is not supported, so it could be hiding other issues