feat: Add support for AWS EC2 VPC Endpoint Connections#14044
Merged
kodiakhq[bot] merged 1 commit intomainfrom Sep 26, 2023
Merged
feat: Add support for AWS EC2 VPC Endpoint Connections#14044kodiakhq[bot] merged 1 commit intomainfrom
kodiakhq[bot] merged 1 commit intomainfrom
Conversation
This PR has the following changes to source plugin(s) tables:
|
mnorbury
reviewed
Sep 26, 2023
Contributor
mnorbury
left a comment
There was a problem hiding this comment.
Looks good, just one question.
Is a VPC endpoint connection a child resource of a VPC endpoint (or an endpoint service)?
Collaborator
Author
I don't think we should consider it to be, because the API doesn't require any inputs. It is (almost) always better to have a top level table for resources because they can be better parallelized |
mnorbury
approved these changes
Sep 26, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
🤖 I have created a release *beep* *boop* --- ## [22.13.0](plugins-source-aws-v22.12.0...plugins-source-aws-v22.13.0) (2023-09-26) ### This Release has the Following Changes to Tables - Table `aws_ec2_vpc_endpoint_connections` was added ### Features * Add support for AWS EC2 VPC Endpoint Connections ([#14044](#14044)) ([0fa640e](0fa640e)), closes [#14030](#14030) * **services:** Support newly added regions ([#14032](#14032)) ([c11bfce](c11bfce)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.10.2 ([#13988](#13988)) ([aebaddf](aebaddf)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.11.0 ([#14031](#14031)) ([ac7cdc4](ac7cdc4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes: #14030