fix: Fix Bill without Feb#13487
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Aug 31, 2023
easayliu:main
Merged
Conversation
…thout 02 or another without 31 month.
candiduslynx
suggested changes
Aug 31, 2023
Contributor
candiduslynx
left a comment
There was a problem hiding this comment.
Hi @easayliu!
I think what you want to achieve can be simplified.
See https://go.dev/play/p/TvNVFcYyQdC
Co-authored-by: Alex Shcherbakov <candiduslynx@users.noreply.github.com>
candiduslynx
approved these changes
Aug 31, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
🤖 I have created a release *beep* *boop* --- ## [4.0.7](plugins-source-alicloud-v4.0.6...plugins-source-alicloud-v4.0.7) (2023-08-31) ### Bug Fixes * Properly account for months of different length in `HistoryBillingCycles` ([#13487](#13487)) ([56d0e45](56d0e45)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix HistoryBillingCycles. when data is 28~31,month without 02 or another without 31 month.
BEGIN_COMMIT_OVERRIDE
fix: Properly account for months of different length in
HistoryBillingCycles(#13487)END_COMMIT_OVERRIDE