feat: Increase default batch size bytes and timeout#13324
Merged
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom Aug 28, 2023
Merged
feat: Increase default batch size bytes and timeout#13324kodiakhq[bot] merged 3 commits intocloudquery:mainfrom
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom
Conversation
This was referenced Aug 25, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
#### Summary Extracted from #13318. Witnessed the bottleneck using `pprof`. With default batch settings I'm getting `2m29s` sync time instead of ~`11m`, With `batch_size_bytes: 100000000` and `batch_timeout: 60s` I'm getting `1m40s`. (Fixed in #13324) Used spec: ```yaml kind: source spec: name: aws path: "cloudquery/aws" version: "v19.0.0" tables: - "*" skip_tables: - "aws_cloudtrail_*" - "aws_iam_*" - "aws_servicequotas_*" destinations: - postgresql --- kind: destination spec: name: "postgresql" registry: "grpc" path: localhost:8888 # path: cloudquery/postgresql # version "v5.0.5" spec: connection_string: "postgresql://postgres:pass@localhost:5432/postgres?sslmode=disable" # batch_size_bytes: 100000000 # batch_timeout: "60s" ``` <!--
candiduslynx
suggested changes
Aug 25, 2023
Member
Author
candiduslynx
approved these changes
Aug 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #13318.
BEGIN_COMMIT_OVERRIDE
feat: Increase default batch size bytes to
100000000(100 MB) and default batch timeout to60seconds.BREAKING-CHANGE: Increase default batch size bytes to
100000000(100 MB) and default batch timeout to60seconds. We discovered a default higher batch size bytes and timeout settings provide better out of the box performance for the PostgreSQL destination. We're marking it as a breaking change as it might increase memory consumption in some environments.END_COMMIT_OVERRIDE