Skip to content

feat(resources): DigitalOcean apps, apps_alerts tables.#12792

Merged
kodiakhq[bot] merged 7 commits intomainfrom
digitalocean-apps
Aug 10, 2023
Merged

feat(resources): DigitalOcean apps, apps_alerts tables.#12792
kodiakhq[bot] merged 7 commits intomainfrom
digitalocean-apps

Conversation

@icio
Copy link
Copy Markdown
Contributor

@icio icio commented Aug 7, 2023

Closes #11723

For example:

SELECT live_url, alerts.spec->>'rule' AS rule
FROM digitalocean_apps apps
LEFT JOIN digitalocean_apps_alerts alerts ON apps._cq_id = alerts._cq_parent_id;
Checklist
  • Does re-running cloudquery sync drop old alerts when they disappear?
  • Write some tests
  • Documentation? Examples?
  • Title?

@icio icio changed the title feat(digitalocean): apps, apps_alerts tables. feat(resources): digitalocean apps, apps_alerts tables. Aug 7, 2023
@icio icio changed the title feat(resources): digitalocean apps, apps_alerts tables. feat(resources): DigitalOcean apps, apps_alerts tables. Aug 7, 2023
@cq-bot cq-bot added the website label Aug 7, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 7, 2023

This PR has the following changes to source plugin(s) tables:

  • Table digitalocean_apps was added
  • Table digitalocean_apps_alerts was added

@hermanschaaf
Copy link
Copy Markdown
Contributor

Looks great! 👍 There is one linting issue (shadow variable) that I think is worth fixing. In terms of documentation, the generated docs are generally enough, but if you like you can add an example query to the overview page (https://www.cloudquery.io/docs/plugins/sources/digitalocean/overview) - the code for that lives under the website directory here https://github.com/cloudquery/cloudquery/blob/main/website/pages/docs/plugins/sources/digitalocean/overview.mdx

@icio icio force-pushed the digitalocean-apps branch from 8693808 to 307173a Compare August 9, 2023 20:42
@icio icio marked this pull request as ready for review August 9, 2023 20:44
@icio icio requested review from a team and bbernays and removed request for a team August 9, 2023 20:44
@icio icio requested review from hermanschaaf and removed request for bbernays August 10, 2023 07:50
Copy link
Copy Markdown
Contributor

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@icio icio added the automerge Automatically merge once required checks pass label Aug 10, 2023
@kodiakhq kodiakhq bot merged commit 5d2dbcf into main Aug 10, 2023
@kodiakhq kodiakhq bot deleted the digitalocean-apps branch August 10, 2023 08:18
kodiakhq bot pushed a commit that referenced this pull request Aug 10, 2023
🤖 I have created a release *beep* *boop*
---


## [5.3.0](plugins-source-digitalocean-v5.2.1...plugins-source-digitalocean-v5.3.0) (2023-08-10)


### This Release has the Following Changes to Tables
- Table `digitalocean_apps` was added
- Table `digitalocean_apps_alerts` was added

### Features

* **resources:** DigitalOcean apps, apps_alerts tables. ([#12792](#12792)) ([5d2dbcf](5d2dbcf))


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.4.0 ([#12850](#12850)) ([0861200](0861200))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add App_Alert_list to Digital_ocean source plugin

3 participants