feat(aws): Support networkmanager resources#12111
Closed
bbernays wants to merge 0 commit intocloudquery:mainfrom
Closed
feat(aws): Support networkmanager resources#12111bbernays wants to merge 0 commit intocloudquery:mainfrom
networkmanager resources#12111bbernays wants to merge 0 commit intocloudquery:mainfrom
Conversation
bbernays
commented
Jul 10, 2023
plugins/source/aws/client/testing.go
Outdated
Comment on lines
+23
to
+26
| if testOpts.Region == "" { | ||
| testOpts.Region = "us-east-1" | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
This is necessary because networkmanager is the first service that is not available in us-east-1 it is only available in us-west-2
disq
approved these changes
Jul 11, 2023
hermanschaaf
approved these changes
Jul 11, 2023
03a36a5 to
7320337
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
#### Summary Duplicate of #12111 which I closed because I royally messed up my git branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary