Merged
Conversation
disq
requested changes
Jun 29, 2023
| } | ||
|
|
||
| func (c *Client) Close(ctx context.Context) error { | ||
| return c.db.Close() |
Member
There was a problem hiding this comment.
Suggested change
| return c.db.Close() | |
| if err := c.writer.Close(ctx); err != nil { | |
| _ = c.db.Close() | |
| return err | |
| } | |
| return c.db.Close() |
Contributor
There was a problem hiding this comment.
we still need to add _ = c.db.Close() before return err, though
UPD: added to the suggestion above
2b28eba to
2059dff
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
🤖 I have created a release *beep* *boop* --- ## [2.3.0](plugins-destination-mysql-v2.2.2...plugins-destination-mysql-v2.3.0) (2023-07-03) ### Features * **mysql:** Update to SDK V4 ([#11775](#11775)) ([1e5da72](1e5da72)) ### Bug Fixes * Close writers ([#11887](#11887)) ([26fad6c](26fad6c)) * **deps:** Update github.com/apache/arrow/go/v13 digest to 5a06b2e ([#11857](#11857)) ([43c2f5f](43c2f5f)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to df3b664 ([#11882](#11882)) ([9635b22](9635b22)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.5.0 ([#11850](#11850)) ([3255857](3255857)) * **mysql:** Fix main serve function ([#11873](#11873)) ([181c467](181c467)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still WIP