fix(source-mysql): Add schema name condition to list columns query#11623
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Jun 15, 2023
Merged
Conversation
candiduslynx
approved these changes
Jun 15, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
🤖 I have created a release *beep* *boop* --- ## [1.2.2](plugins-source-mysql-v1.2.1...plugins-source-mysql-v1.2.2) (2023-06-15) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 4d76231 ([#11532](#11532)) ([6f04233](6f04233)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to d864719 ([#11611](#11611)) ([557a290](557a290)) * **source-mysql:** Add schema name condition to list columns query ([#11623](#11623)) ([f0f8638](f0f8638)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11619.
The issue is that
usersis an existing table with aperformance_schema, see https://dev.mysql.com/doc/mysql-perfschema-excerpt/8.0/en/performance-schema-users-table.html.If someone creates a
userstable listing columns fromINFORMATION_SCHEMA.COLUMNSonly by table name gives us the columns from both the manually createduserstable and the performance one.The solution is to add the schema name to the columns query.