feat(gcp)!: Update to SDK V3 for native Arrow support#10784
Merged
yevgenypats merged 4 commits intomainfrom May 25, 2023
Merged
feat(gcp)!: Update to SDK V3 for native Arrow support#10784yevgenypats merged 4 commits intomainfrom
yevgenypats merged 4 commits intomainfrom
Conversation
kodiakhq bot
pushed a commit
to cloudquery/plugin-sdk
that referenced
this pull request
May 15, 2023
Few notes: - Most of the code here was removed in #854 to prevent accidental use before it was ready - Sources moved to use the new `schema.Table` which means use of `arrow.DataType` instead of our old `ValueType` - Protocol in sources and destinations are upgraded to use native arrow format (sources v2 and dest v1) - https://github.com/cloudquery/plugin-pb-go - Introduces a new `scalar` package which is mostly used by our "managed" sources and basically our old cqtypes just now using arrow types (which also support nesting). This will hopefully go upstream one day but I don't think we should block on that as the upstream package is not a fit right now and will take time for such refactor to make it upstream. Follow-up PRs with example sources and dest will follow soon. IMPORTANT: all destinations should be released first as we decided new sources will work only with new destination to avoid un-necessary backward compatibility maintenance. Example PRs: - PostgreSQL: cloudquery/cloudquery#10783 - GCP: cloudquery/cloudquery#10784 - CLI: cloudquery/cloudquery#10785
239d0c7 to
10f1194
Compare
Contributor
Author
|
Close #10744 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10744
BEGIN_COMMIT_OVERRIDE
feat: Update to use Apache Arrow type system (#10784)
BREAKING-CHANGE: This release introduces an internal change to our type system to use Apache Arrow. This should not have any visible breaking changes, however due to the size of the change we are introducing it under a major version bump to communicate that it might have some bugs that we weren't able to catch during our internal tests. If you encounter an issue during the upgrade, please submit a bug report. You will also need to update destinations depending on which one you use:
END_COMMIT_OVERRIDE