feat: Add GitHub Enterprise support on GitHub source#10776
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom May 12, 2023
Merged
feat: Add GitHub Enterprise support on GitHub source#10776kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
98f573b to
3b61008
Compare
hermanschaaf
approved these changes
May 12, 2023
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
Very nice, thanks for adding this!
1 task
kodiakhq bot
pushed a commit
that referenced
this pull request
May 16, 2023
🤖 I have created a release *beep* *boop* --- ## [5.2.0](plugins-source-github-v5.1.1...plugins-source-github-v5.2.0) (2023-05-16) ### Features * Add GitHub Enterprise support on GitHub source ([#10776](#10776)) ([3bc226b](3bc226b)) * **deps:** Upgrade to Apache Arrow v13 (latest `cqmain`) ([#10605](#10605)) ([a55da3d](a55da3d)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.8 ([#10798](#10798)) ([27ff430](27ff430)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements: #10696
Adding support for GHE based on the request found here
Tests
Didn't increase the coverage cause the GitHubEnterpriseClient from go-github is basically a duck-type githubClient.