feat(gcp)!: Make Listing Enabled Services failures not block the sync#10699
Merged
kodiakhq[bot] merged 8 commits intocloudquery:mainfrom May 15, 2023
Merged
Conversation
|
I think it is a useful solution, in my case it would help a lot |
hermanschaaf
approved these changes
May 11, 2023
disq
approved these changes
May 11, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
May 25, 2023
🤖 I have created a release *beep* *boop* --- ## [9.0.0](plugins-source-gcp-v8.5.1...plugins-source-gcp-v9.0.0) (2023-05-25) ### ⚠ BREAKING CHANGES * This release introduces an internal change to our type system to use [Apache Arrow](https://arrow.apache.org/). This should not have any visible breaking changes, however due to the size of the change we are introducing it under a major version bump to communicate that it might have some bugs that we weren't able to catch during our internal tests. If you encounter an issue during the upgrade, please submit a [bug report](https://github.com/cloudquery/cloudquery/issues/new/choose). * **gcp:** Initialization concurrency ([#10700](#10700)) * **gcp:** Make Listing Enabled Services failures not block the sync ([#10699](#10699)) ### Features * **deps:** Upgrade to Apache Arrow v13 (latest `cqmain`) ([#10605](#10605)) ([a55da3d](a55da3d)) * **gcp:** Enable Better Logging for when `enabled_services_only` fails ([#10695](#10695)) ([a849aea](a849aea)) * **gcp:** Initialization concurrency ([#10700](#10700)) ([0c9f510](0c9f510)) * **gcp:** Make Listing Enabled Services failures not block the sync ([#10699](#10699)) ([5b49481](5b49481)) * Update to use [Apache Arrow](https://arrow.apache.org/) type system ([612d3ea](612d3ea)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.8 ([#10798](#10798)) ([27ff430](27ff430)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We currently require a successful
ListServicesfor all projects in the org. If a user cannot make the call for a single project then the entire sync will fail. This PR changes the listing to be a best effort, which means that if CQ is not able to make theListServicescall it will just assume that all services are enabled