feat(resources): Use `resourcemanager/resources/armsubscriptions` for subscription resources by disq · Pull Request #10369 · cloudquery/cloudquery

disq · 2023-04-26T14:39:04Z

github-actions · 2023-04-26T14:39:31Z

This PR has the following changes to source plugin(s) tables:

Table azure_subscription_subscription_locations: column added with name metadata and type json
Table azure_subscription_subscription_locations: column added with name regional_display_name and type utf8
Table azure_subscription_subscription_locations: column added with name type and type utf8
Table azure_subscription_subscriptions: column added with name managed_by_tenants and type json
Table azure_subscription_subscriptions: column added with name tags and type json
Table azure_subscription_subscriptions: column added with name tenant_id and type utf8
Table azure_subscription_tenants: column added with name country_code and type utf8
Table azure_subscription_tenants: column added with name country and type utf8
Table azure_subscription_tenants: column added with name default_domain and type utf8
Table azure_subscription_tenants: column added with name display_name and type utf8
Table azure_subscription_tenants: column added with name domains and type list<item: utf8, nullable>
Table azure_subscription_tenants: column added with name tenant_branding_logo_url and type utf8
Table azure_subscription_tenants: column added with name tenant_category and type utf8
Table azure_subscription_tenants: column added with name tenant_type and type utf8

disq · 2023-04-26T14:47:21Z

plugins/source/azure/resources/services/subscription/locations.go

@@ -14,16 +14,16 @@ func locations() *schema.Table {
 		Name:        "azure_subscription_subscription_locations",
 		Resolver:    fetchLocations,
 		Description: "https://learn.microsoft.com/en-us/rest/api/resources/subscriptions/list-locations?tabs=HTTP#location",


Docs were already pointing to the right API responses so no change was made there.

disq · 2023-04-26T14:47:59Z

website/tables/azure/azure_subscription_subscription_locations.md

+|metadata|JSON|
 |display_name|String|
 |id (PK)|String|
-|latitude|String|


This is now a key under metadata along with longitude and bunch of new keys.

Maybe we can keep these fields as aliases of the ones in the metadata JSON (using path resolver) to keep this change backwards-compatible?

Maybe we can keep these fields as aliases of the ones in the metadata JSON (using path resolver) to keep this change backwards-compatible?

+1

This looks good, but +1 for making this backwards compatible

Hopefully fixed in 6fc0ad8

candiduslynx · 2023-05-04T10:15:55Z

IDK if we want to go through with this breaking change. @yevgenypats what's your take?

…s for subscription resources

🤖 I have created a release *beep* *boop* --- ## [8.3.0](plugins-source-azure-v8.2.0...plugins-source-azure-v8.3.0) (2023-06-20) ### This Release has the Following Changes to Tables - Table `azure_cognitiveservices_account_deployments` was added - Table `azure_cognitiveservices_account_models` was added - Table `azure_cognitiveservices_account_private_endpoint_connections` was added - Table `azure_cognitiveservices_account_private_link_resources` was added - Table `azure_cognitiveservices_account_skus` was added - Table `azure_cognitiveservices_account_usages` was added - Table `azure_cognitiveservices_commitment_plans` was added - Table `azure_cognitiveservices_resource_skus` was added - Table `azure_subscription_subscription_locations`: column added with name `metadata` and type `json` - Table `azure_subscription_subscription_locations`: column added with name `regional_display_name` and type `utf8` - Table `azure_subscription_subscription_locations`: column added with name `type` and type `utf8` - Table `azure_subscription_subscriptions`: column added with name `managed_by_tenants` and type `json` - Table `azure_subscription_subscriptions`: column added with name `tags` and type `json` - Table `azure_subscription_subscriptions`: column added with name `tenant_id` and type `utf8` - Table `azure_subscription_tenants`: column added with name `country_code` and type `utf8` - Table `azure_subscription_tenants`: column added with name `country` and type `utf8` - Table `azure_subscription_tenants`: column added with name `default_domain` and type `utf8` - Table `azure_subscription_tenants`: column added with name `display_name` and type `utf8` - Table `azure_subscription_tenants`: column added with name `domains` and type `list<item: utf8, nullable>` - Table `azure_subscription_tenants`: column added with name `tenant_branding_logo_url` and type `utf8` - Table `azure_subscription_tenants`: column added with name `tenant_category` and type `utf8` - Table `azure_subscription_tenants`: column added with name `tenant_type` and type `utf8` ### Features * **azure-resources:** Add missing Cognitive Services resources ([#11645](#11645)) ([74b64e4](74b64e4)) * **resources:** Use `resourcemanager/resources/armsubscriptions` for subscription resources ([#10369](#10369)) ([0a76536](0a76536)), closes [#9854](#9854) ### Bug Fixes * **azure-policies:** Fix Syntax for policies ([#10184](#10184)) ([7795b37](7795b37)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 1e68c51 ([#11637](#11637)) ([46043bc](46043bc)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 4d76231 ([#11532](#11532)) ([6f04233](6f04233)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to b0832be ([#11651](#11651)) ([71e8c29](71e8c29)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to d864719 ([#11611](#11611)) ([557a290](557a290)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.6 ([#11473](#11473)) ([7272133](7272133)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: cq-bot <cq-bot@users.noreply.github.com>

disq requested review from erezrokah and yevgenypats as code owners April 26, 2023 14:39

cq-bot added azure labels Apr 26, 2023

vercel bot deployed to Preview April 26, 2023 14:42 View deployment

disq requested a review from candiduslynx April 26, 2023 14:46

disq commented Apr 26, 2023

View reviewed changes

disq force-pushed the feat/azure_rm branch 4 times, most recently from bbedf09 to b82804b Compare May 29, 2023 12:17

vercel bot deployed to Preview May 29, 2023 12:21 View deployment

feat(azure-resources)!: Use resourcemanager/resources/armsubscription…

6d1de04

…s for subscription resources

disq force-pushed the feat/azure_rm branch from b82804b to 6d1de04 Compare June 15, 2023 13:10

Bring back latitude/longitude as shimmed columns

6fc0ad8

disq changed the title ~~feat(azure-resources)!: Use resourcemanager/resources/armsubscriptions for subscription resources~~ feat(azure-resources): Use resourcemanager/resources/armsubscriptions for subscription resources Jun 15, 2023

hermanschaaf approved these changes Jun 15, 2023

View reviewed changes

vercel bot deployed to Preview June 15, 2023 13:19 View deployment

candiduslynx approved these changes Jun 15, 2023

View reviewed changes

candiduslynx changed the title ~~feat(azure-resources): Use resourcemanager/resources/armsubscriptions for subscription resources~~ feat(azure-resources): Use resourcemanager/resources/armsubscriptions for subscription resources Jun 15, 2023

candiduslynx changed the title ~~feat(azure-resources): Use resourcemanager/resources/armsubscriptions for subscription resources~~ feat(resources): Use resourcemanager/resources/armsubscriptions for subscription resources Jun 15, 2023

erezrokah approved these changes Jun 15, 2023

View reviewed changes

disq added the automerge Automatically merge once required checks pass label Jun 15, 2023

Merge branch 'main' into feat/azure_rm

e1708c3

vercel bot deployed to Preview June 15, 2023 14:14 View deployment

kodiakhq bot merged commit 0a76536 into cloudquery:main Jun 15, 2023

cq-bot mentioned this pull request Jun 15, 2023

chore(main): Release plugins-source-azure v8.3.0 #11573

Merged

disq deleted the feat/azure_rm branch June 15, 2023 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(resources): Use `resourcemanager/resources/armsubscriptions` for subscription resources#10369

feat(resources): Use `resourcemanager/resources/armsubscriptions` for subscription resources#10369
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom
disq:feat/azure_rm

disq commented Apr 26, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Apr 26, 2023 •

edited

Loading

Uh oh!

disq Apr 26, 2023

Uh oh!

disq Apr 26, 2023

Uh oh!

hermanschaaf May 4, 2023

Uh oh!

candiduslynx May 4, 2023

Uh oh!

erezrokah May 29, 2023

Uh oh!

disq Jun 15, 2023

Uh oh!

candiduslynx commented May 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

disq commented Apr 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR has the following changes to source plugin(s) tables:

Uh oh!

disq Apr 26, 2023

Choose a reason for hiding this comment

Uh oh!

disq Apr 26, 2023

Choose a reason for hiding this comment

Uh oh!

hermanschaaf May 4, 2023

Choose a reason for hiding this comment

Uh oh!

candiduslynx May 4, 2023

Choose a reason for hiding this comment

Uh oh!

erezrokah May 29, 2023

Choose a reason for hiding this comment

Uh oh!

disq Jun 15, 2023

Choose a reason for hiding this comment

Uh oh!

candiduslynx commented May 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

disq commented Apr 26, 2023 •

edited

Loading

github-actions bot commented Apr 26, 2023 •

edited

Loading