feat(gcp): Auto generate services list#5961
Merged
kodiakhq[bot] merged 4 commits intocloudquery:mainfrom Jan 3, 2023
Merged
Conversation
Member
Author
|
We should first merge #5958 and then rebase, to make it easier to review this PR |
erezrokah
commented
Dec 26, 2022
51286f7 to
9466dc8
Compare
yevgenypats
approved these changes
Jan 3, 2023
9466dc8 to
af94f0c
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 3, 2023
🤖 I have created a release *beep* *boop* --- ## [5.4.0](plugins-source-gcp-v5.3.1...plugins-source-gcp-v5.4.0) (2023-01-03) ### Features * **gcp-codegen:** Make ListFunction optional ([#5971](#5971)) ([5717f05](5717f05)) * **gcp-resources:** Add AppEngine resources ([#5972](#5972)) ([d6b6c6a](d6b6c6a)) * **gcp-resources:** Add Artifact Registry ([#6020](#6020)) ([76faa06](76faa06)) * **gcp-resources:** Add Bare Metal Solution ([#6044](#6044)) ([9a80b27](9a80b27)) * **gcp-resources:** Add Batch ([#6128](#6128)) ([43cd3be](43cd3be)) * **gcp-resources:** Add BeyondCorp ([#6133](#6133)) ([48aafd0](48aafd0)) * **gcp-resources:** Add Vertex-AI ([#5762](#5762)) ([d22b69d](d22b69d)) * **gcp:** Auto generate services list ([#5961](#5961)) ([0467de5](0467de5)) ### Bug Fixes * **deps:** Update google.golang.org/genproto digest to f9683d7 ([#6170](#6170)) ([0df29be](0df29be)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.14.0 ([#6025](#6025)) ([35b2cfc](35b2cfc)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.15.0 ([#6071](#6071)) ([684b525](684b525)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.15.1 ([#6079](#6079)) ([650659c](650659c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.16.0 ([#6098](#6098)) ([7bacdf3](7bacdf3)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.16.1 ([#6214](#6214)) ([53b2415](53b2415)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.17.0 ([#6256](#6256)) ([b19f6cd](b19f6cd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5957.
We need to put the services file in both the code gen module and the GCP client as they both use it. Previously code gen referenced the GCP client directly which prevents auto generation of the services file.
It should be easier to review this once #5958 is merged.
Added a new makefile target as we should first discover the services, then run the codegen