fix(azure): Use lowercase namespaces#5789
Conversation
042abcd to
f9472f4
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
erezrokah
left a comment
There was a problem hiding this comment.
Looks good but I think this fixes #5760 and #5761, but not #5683 as for #5683 we still need #5758.
Also could we drop the namespace multiplexer altogether? We don't use the namespace in the List API calls. I tried it for a few API calls in #5758 and it doesn't generate a lot of errors (only one errored out with a "not registered service").
The last comment is more a product decision, dropping the namespace multiplexer will make the Azure plugin consistent with GCP's default behavior
|
I don't think we need to drop the multiplexer because otherwise azure will hit disabled APIs and this will be (really) slow. we were actually trying to implement this in GCP but with no success so far due to some issues with their list disabled APIs. Regarding the issue - Im not sure what the customer is reporting about - is they are not seeing anything at all? specific table. I think the issue needs more elaboration. |
This PR has the following changes to source plugin(s) tables:
|
@erezrokah Can we not mark it as breaking. This table was never working. |
|
|
@yevgenypats This comment is just FYI, as long as the PR title/body doesn't say it's breaking it won't bump the major version |
There are 2 separate issues:
|
🤖 I have created a release *beep* *boop* --- ## [2.2.0](plugins-source-azure-v2.1.1...plugins-source-azure-v2.2.0) (2022-12-20) ### Features * **azure:** Add storage_containers ([#5759](#5759)) ([18003e9](18003e9)) ### Bug Fixes * **azure:** Remove extra `fmt.Println` ([#5756](#5756)) ([4c588b1](4c588b1)) * **azure:** Use lowercase namespaces ([#5789](#5789)) ([b43e1bd](b43e1bd)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.5 ([#5661](#5661)) ([b354b8a](b354b8a)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.6 ([#5790](#5790)) ([8e2663c](8e2663c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.7 ([#5797](#5797)) ([15da529](15da529)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This should fix some of the missing tables we were seeing in azure. apparently namespaces are not consistent and can be lowered case, camel cased, something else... So we normalize them all to lower-case (given they are case insensitive) on the client side.