feat(azure): Add warning message when a namespace is not registered#5758
Closed
erezrokah wants to merge 4 commits intocloudquery:mainfrom
Closed
feat(azure): Add warning message when a namespace is not registered#5758erezrokah wants to merge 4 commits intocloudquery:mainfrom
erezrokah wants to merge 4 commits intocloudquery:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
I understand that change but I dont understand how this solves #5683 . What were the missing tables? |
Member
Author
They are not missing. We don't sync them because the subscription doesn't have these providers registered, see https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/resource-providers-and-types#azure-portal I think it's like enabled APIs in GCP. The main issue is not logging that we don't sync them |
This was referenced Dec 18, 2022
b3f5e0e to
9cd84e4
Compare
d4a53f9 to
23ad06c
Compare
23ad06c to
d31519f
Compare
Member
Author
|
Closing as stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5683.
I'm not sure this is the correct solution (or implementation of this approach).
Another option is to remove the condition in
cloudquery/plugins/source/azure/client/client.go
Line 105 in 674ef9b