Skip to content

feat(codegen): Add PrimaryKeys field to codegen#5623

Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
erezrokah:refactor/gcp_codegen
Dec 14, 2022
Merged

feat(codegen): Add PrimaryKeys field to codegen#5623
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
erezrokah:refactor/gcp_codegen

Conversation

@erezrokah
Copy link
Copy Markdown
Member

@erezrokah erezrokah commented Dec 13, 2022 •
edited
Loading

Summary

Looks like we're using ExtraColumns mostly for setting primary keys, so I changed it so we only pass the names of primary keys. This allowed to me to remove some boilerplate around skipping the field, just so we can extra column it.
Also this saves copy pasting the column type, resolver (which was missing in some cases), etc.

While the order of primary keys columns changed between all columns, the order between primary keys of the same table is the same.

I'm not sure how to classify this? feat? It is user facing, both in regards to columns and code gen.

@cq-bot cq-bot added the gcp label Dec 13, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 13, 2022 •
edited
Loading

This PR has the following changes to source plugin(s) tables:

  • Table gcp_apikeys_keys: column order changed for uid (PK)
  • Table gcp_compute_addresses: column order changed for self_link (PK)
  • Table gcp_compute_autoscalers: column order changed for self_link (PK)
  • Table gcp_compute_backend_services: column order changed for self_link (PK)
  • Table gcp_compute_disk_types: column order changed for self_link (PK)
  • Table gcp_compute_disks: column order changed for self_link (PK)
  • Table gcp_compute_firewalls: column order changed for self_link (PK)
  • Table gcp_compute_forwarding_rules: column order changed for self_link (PK)
  • Table gcp_compute_images: column order changed for self_link (PK)
  • Table gcp_compute_instance_groups: column order changed for self_link (PK)
  • Table gcp_compute_instances: column order changed for self_link (PK)
  • Table gcp_compute_interconnects: column order changed for self_link (PK)
  • Table gcp_compute_networks: column order changed for self_link (PK)
  • Table gcp_compute_projects: column order changed for self_link (PK)
  • Table gcp_compute_ssl_certificates: column order changed for self_link (PK)
  • Table gcp_compute_ssl_policies: column order changed for self_link (PK)
  • Table gcp_compute_subnetworks: column order changed for self_link (PK)
  • Table gcp_compute_target_http_proxies: column order changed for self_link (PK)
  • Table gcp_compute_target_ssl_proxies: column order changed for self_link (PK)
  • Table gcp_compute_url_maps: column order changed for self_link (PK)
  • Table gcp_compute_vpn_gateways: column order changed for self_link (PK)
  • Table gcp_container_clusters: column order changed for self_link (PK)
  • Table gcp_dns_managed_zones: column order changed for id (PK)
  • Table gcp_dns_policies: column order changed for id (PK)
  • Table gcp_iam_roles: column order changed for name (PK)
  • Table gcp_iam_service_accounts: column order changed for oauth2_client_id
  • Table gcp_iam_service_accounts: column order changed for unique_id (PK)
  • Table gcp_sql_instances: column order changed for self_link (PK)
  • Table gcp_sql_users: column order changed for instance (PK)
  • Table gcp_sql_users: column order changed for name (PK)

@erezrokah erezrokah force-pushed the refactor/gcp_codegen branch from 646ab24 to 19d3e37 Compare December 13, 2022 17:16
@erezrokah erezrokah changed the title refactor(codegen): Replace ExtraColumns with PrimaryKeys refactor(codegen): Add PrimaryKeys field to codegen Dec 13, 2022
@erezrokah erezrokah changed the title refactor(codegen): Add PrimaryKeys field to codegen feat(codegen): Add PrimaryKeys field to codegen Dec 13, 2022
@erezrokah erezrokah force-pushed the refactor/gcp_codegen branch from 1ead812 to ed6f0fc Compare December 13, 2022 17:30
@erezrokah erezrokah marked this pull request as ready for review December 13, 2022 17:32
@erezrokah erezrokah force-pushed the refactor/gcp_codegen branch from ed6f0fc to 678aefc Compare December 14, 2022 11:23
@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Dec 14, 2022
@kodiakhq kodiakhq bot merged commit 1980d16 into cloudquery:main Dec 14, 2022
@erezrokah erezrokah deleted the refactor/gcp_codegen branch December 14, 2022 11:29
@cq-bot cq-bot mentioned this pull request Dec 14, 2022
Merged
erezrokah pushed a commit that referenced this pull request Dec 14, 2022
@cq-bot
chore(main): Release plugins-source-gcp v5.0.0 (#5610)
b64c8b5 
🤖 I have created a release *beep* *boop*
---


##
[5.0.0](plugins-source-gcp-v4.0.0...plugins-source-gcp-v5.0.0)
(2022-12-14)


### ⚠ BREAKING CHANGES

* **gcp:** Table `gcp_resourcemanager_folders` `project_id` column was
removed, and `organization_id` added

### Features

* **codegen:** Add PrimaryKeys field to codegen
([#5623](#5623))
([1980d16](1980d16))
* **gcp:** Add SQL users
([#5622](#5622))
([cf00c37](cf00c37))


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.2
([#5583](#5583))
([d721c4e](d721c4e))
* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.12.3
([#5639](#5639))
([6452d0e](6452d0e))
* **gcp:** ResourceManager folders listing (add OrgMultiplexing)
([9dfc991](9dfc991))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disq disq Awaiting requested review from disq

1 more reviewer

@yevgenypats yevgenypats yevgenypats approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erezrokah @yevgenypats @cq-bot