feat(codegen): Add PrimaryKeys field to codegen#5623
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Dec 14, 2022
Merged
feat(codegen): Add PrimaryKeys field to codegen#5623kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Looks like we're using
ExtraColumnsmostly for setting primary keys, so I changed it so we only pass the names of primary keys. This allowed to me to remove some boilerplate around skipping the field, just so we can extra column it.Also this saves copy pasting the column type, resolver (which was missing in some cases), etc.
While the order of primary keys columns changed between all columns, the order between primary keys of the same table is the same.
I'm not sure how to classify this?
feat? It is user facing, both in regards to columns and code gen.