Merged
Conversation
hermanschaaf
suggested changes
Nov 25, 2022
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
Nice! I know this is still in draft, but I did a quick read-through and left some comments with some things for us to remember before merging. Looks great so far 👍
plugins/source/datadog/scripts/regenerate-changed-directories.sh
Outdated
Show resolved
Hide resolved
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
# Conflicts: # .github/styles/Vocab/Base/accept.txt
erezrokah
requested changes
Nov 29, 2022
Member
erezrokah
left a comment
There was a problem hiding this comment.
Looks great @amanenk, I think it's only missing updating the docs in our Website (we moved them recently from GitHub).
Once this is released we should add it to https://github.com/cloudquery/cloudquery/blob/0e4b8dc53358388f8a1e61cad8ae8a1ab2f52342/website/pages/docs/plugins/sources/overview.mdx as Preview
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
…5170) #### Summary When adding a new plugin the version file doesn't exist yet, so the build fails. This defaults to `v1.0.0` instead of failing the build, **only for new plugins** See failure: https://vercel.com/cloudquery/cloudquery-web/52G1znzrGcKCidgcvhCfKk5WZAhD PR #5096 <!--
hermanschaaf
approved these changes
Nov 30, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2022-12-01) ### Features * Adds datadog plugin resources ([#5192](#5192)) ([bc0c7e3](bc0c7e3)) * Datadog plugin ([#5096](#5096)) ([4c96026](4c96026)) * **website:** Add plugins tables ([#5259](#5259)) ([c336f4e](c336f4e)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.10.0 ([#5258](#5258)) ([a14640b](a14640b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #4794