Skip to content

fix: Show sync time#2493

Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
disq:fix/show-sync-time
Oct 8, 2022
Merged

fix: Show sync time#2493
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
disq:fix/show-sync-time

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Oct 7, 2022

old look:

Summary: resources: 22029, errors: 100, panic: 0 failed_writes: 0

new look:

Summary: resources: 25660, errors: 100, panic: 0, failed_writes: 0, time: 2m42s

@disq disq requested a review from yevgenypats as a code owner October 7, 2022 08:00
@cq-bot cq-bot added the cli label Oct 7, 2022
@disq disq force-pushed the fix/show-sync-time branch 2 times, most recently from a754979 to 67d9abc Compare October 7, 2022 15:43
@disq disq added the automerge Automatically merge once required checks pass label Oct 7, 2022
@yevgenypats yevgenypats removed the automerge Automatically merge once required checks pass label Oct 8, 2022
Copy link
Copy Markdown
Contributor

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Nit: can you also add to the log line underneath?

@disq disq force-pushed the fix/show-sync-time branch from 67d9abc to e22240a Compare October 8, 2022 09:39
@disq disq requested a review from yevgenypats October 8, 2022 09:39
@yevgenypats yevgenypats added the automerge Automatically merge once required checks pass label Oct 8, 2022
@kodiakhq kodiakhq bot merged commit 014e8aa into cloudquery:main Oct 8, 2022
@disq disq deleted the fix/show-sync-time branch October 8, 2022 18:13
kodiakhq bot pushed a commit that referenced this pull request Oct 9, 2022
🤖 I have created a release *beep* *boop*
---


## [1.0.6](cli-v1.0.5...cli-v1.0.6) (2022-10-08)


### Bug Fixes

* **cli:** Close stdout when using --log-console ([#2459](#2459)) ([264c493](264c493))
* **deps:** Update plugin-sdk for cli to v0.12.8 ([#2497](#2497)) ([33c0c46](33c0c46))
* **deps:** Update plugin-sdk for cli to v0.12.9 ([#2511](#2511)) ([6787155](6787155))
* Show sync time ([#2493](#2493)) ([014e8aa](014e8aa))
* SourceName ([#2522](#2522)) ([0b7db32](0b7db32))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants