Skip to content

feat(aws): EMR Clusters to use PreResourceResolver#2411

Merged
kodiakhq[bot] merged 4 commits intocloudquery:mainfrom
disq:feat/aws_emr_clusters_listanddetail
Oct 5, 2022
Merged

feat(aws): EMR Clusters to use PreResourceResolver#2411
kodiakhq[bot] merged 4 commits intocloudquery:mainfrom
disq:feat/aws_emr_clusters_listanddetail

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Oct 4, 2022

Should fix #2392

@cq-bot cq-bot added the aws label Oct 4, 2022
@disq disq requested a review from bbernays October 4, 2022 16:40
Copy link
Copy Markdown
Contributor

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using this ListAndDetailResolver anymore and we should deprecate it from anywhere it exist / remove the function.

We have PreResourceResolver exactly for this case. Otherwise we wont be able to control concurrency.

@disq disq changed the title feat(aws): EMR Clusters to use ListAndDetailResolver feat(aws): EMR Clusters to use PreResourceResolver Oct 4, 2022
@disq disq requested a review from yevgenypats October 4, 2022 19:18
@disq disq force-pushed the feat/aws_emr_clusters_listanddetail branch 2 times, most recently from 3c40b23 to c8b8026 Compare October 5, 2022 08:56
@disq disq force-pushed the feat/aws_emr_clusters_listanddetail branch from c8b8026 to bcdf7af Compare October 5, 2022 09:09
@disq disq added the automerge Automatically merge once required checks pass label Oct 5, 2022
@kodiakhq kodiakhq bot merged commit b01e6ca into cloudquery:main Oct 5, 2022
@disq disq deleted the feat/aws_emr_clusters_listanddetail branch October 5, 2022 09:33
kodiakhq bot pushed a commit that referenced this pull request Oct 6, 2022
🤖 I have created a release *beep* *boop*
---


## [2.0.0](plugins-source-aws-v1.0.1...plugins-source-aws-v2.0.0) (2022-10-06)


### ⚠ BREAKING CHANGES

* Update all AWS Client Versions (#2410)
* Store some JSON columns as jsonb not as a text (#2463)

### Features

* Add new fields to Lightsail and EC2 ([#2403](#2403)) ([7e3fc83](7e3fc83))
* **aws:** EMR Clusters to use PreResourceResolver ([#2411](#2411)) ([b01e6ca](b01e6ca))
* **aws:** Update cis 1.5.0 policy ([#1615](#1615)) ([0f64196](0f64196))


### Bug Fixes

* AWS codegen: fix ec2 naming ([#2473](#2473)) ([27dd558](27dd558))
* **deps:** Update plugin-sdk for aws to v0.12.3 ([#2383](#2383)) ([0ed4d5f](0ed4d5f))
* **deps:** Update plugin-sdk for aws to v0.12.4 ([#2394](#2394)) ([d8c9657](d8c9657))
* **deps:** Update plugin-sdk for aws to v0.12.6 ([#2416](#2416)) ([0539c03](0539c03))
* **deps:** Update plugin-sdk for aws to v0.12.7 ([#2445](#2445)) ([6e39611](6e39611))
* Store some JSON columns as jsonb not as a text ([#2463](#2463)) ([5da8a1f](5da8a1f))
* Update all AWS Client Versions ([#2410](#2410)) ([ca34f1c](ca34f1c))
* Update endpoints ([#2414](#2414)) ([62d8802](62d8802))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

very poor performance on aws_emr_clusters

3 participants