fix: Don't re-use scan destination between rows scan#21058
Merged
kodiakhq[bot] merged 2 commits intomainfrom Jul 16, 2025
Merged
fix: Don't re-use scan destination between rows scan#21058kodiakhq[bot] merged 2 commits intomainfrom
kodiakhq[bot] merged 2 commits intomainfrom
Conversation
Contributor
|
🚀 ClickHouse Cloud UI deployed to Vercel: |
5 tasks
kodiakhq bot
pushed a commit
to cloudquery/plugin-sdk
that referenced
this pull request
Jul 16, 2025
Cleans up #2226, #2220 and #2217. I believe I found the issue and the fix is cloudquery/cloudquery#21058 ---
savme
approved these changes
Jul 16, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 16, 2025
🤖 I have created a release *beep* *boop* --- ## [7.1.3](plugins-destination-clickhouse-v7.1.2...plugins-destination-clickhouse-v7.1.3) (2025-07-16) ### Bug Fixes * Delete stale sync time precision ([#21049](#21049)) ([52b48c8](52b48c8)) * Don't re-use scan destination between rows scan ([#21058](#21058)) ([bc909ad](bc909ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
|
Nice find 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I believe this should fix the flaky ClickHouse destination tests we've been seeing for a long while.
We were re-using the scan destination between scans which caused under some conditions to keep the previous read value instead of overwriting (I saw this happen when we first read a non null value, then supposed to read a null value, but I guess ClickHouse has some optimization so skip reading the null value). Oddly enough I only saw this for
boolean, decimal, uuidtypes.