fix: Delete stale sync time precision (#21049)

erezrokah · kodiakhq[bot] · web-flow · commit 52b48c844dbc · 2025-07-16T15:13:58.000+01:00
#### Summary I've been looking at the flaky ClickHouse destination tests to see what's up and noticed this (it doesn't fix the common error we're seeing but a different one). When using numeric arguments the Go driver defaults to second precision, see https://github.com/ClickHouse/clickhouse-go/blob/6c5ddb38dd2edc841a3b927711b841014759bede/bind.go#L186, losing data while converting the Go time to a string, see below before/after mutation queries. The solution is to use named args and specify the precision, used `MicroSeconds` because of https://github.com/cloudquery/plugin-sdk/blob/28a147900315aa9756fc66e7329e3cfbe111e4b5/plugin/testing_write_delete.go#L89 ### Before <img width="1328" height="377" alt="image" src="https://github.com/user-attachments/assets/28ea0c30-39b4-4d7d-821f-a6469a48cc5c" /> ### After <img width="1402" height="360" alt="image" src="https://github.com/user-attachments/assets/5f5faec3-b5fd-4c2a-8ae6-9b3f329e2e58" />  Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
diff --git a/plugins/destination/clickhouse/client/delete.go b/plugins/destination/clickhouse/client/delete.go
@@ -6,6 +6,7 @@ import (
 	"strconv"
 	"strings"
 
+	"github.com/ClickHouse/clickhouse-go/v2"
 	"github.com/cloudquery/cloudquery/plugins/destination/clickhouse/v7/typeconv/ch/values"
 	"github.com/cloudquery/cloudquery/plugins/destination/clickhouse/v7/util"
 	"github.com/cloudquery/plugin-sdk/v4/message"
@@ -18,7 +19,11 @@ func (c *Client) DeleteStale(ctx context.Context, messages message.WriteDeleteSt
 	}
 
 	for _, msg := range messages {
-		if err := retryExec(ctx, c.logger, c.conn, generateDeleteForDeleteStale(msg), msg.SourceName, msg.SyncTime); err != nil {
+		namedValues := []any{
+			clickhouse.Named("source_name", msg.SourceName),
+			clickhouse.DateNamed("sync_time", msg.SyncTime, clickhouse.MicroSeconds),
+		}
+		if err := retryExec(ctx, c.logger, c.conn, generateDeleteForDeleteStale(msg), namedValues...); err != nil {
 			return err
 		}
 	}
@@ -32,9 +37,9 @@ func generateDeleteForDeleteStale(msg *message.WriteDeleteStale) string {
 	sb.WriteString(util.SanitizeID(msg.TableName))
 	sb.WriteString(" WHERE ")
 	sb.WriteString(util.SanitizeID(schema.CqSourceNameColumn.Name))
-	sb.WriteString(" = $1 AND toTimeZone(")
+	sb.WriteString(" = @source_name AND toTimeZone(")
 	sb.WriteString(util.SanitizeID(schema.CqSyncTimeColumn.Name))
-	sb.WriteString(", 'UTC') < $2")
+	sb.WriteString(", 'UTC') < @sync_time")
 	return sb.String()
 }
 
