feat: Remove logging of error events to Sentry in plugins #18165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
reviewed
Jun 6, 2024
| ) | ||
|
|
||
| const ( | ||
| sentryDSN = "https://1e33dfd084aa43f2aa8e686f15a64e45@o1396617.ingest.sentry.io/4504407264526336" |
Contributor
There was a problem hiding this comment.
I suggest first removing the sentry option from the plugin-sdk as well
candiduslynx
approved these changes
Jun 6, 2024
| "fmt" | ||
| "os" | ||
|
|
||
| "log" |
Contributor
There was a problem hiding this comment.
golangci-lint --config ../../.golangci.yml --fix
This was referenced Jun 6, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [8.2.0](plugins-destination-postgresql-v8.1.1...plugins-destination-postgresql-v8.2.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [5.1.0](plugins-destination-gcs-v5.0.3...plugins-destination-gcs-v5.1.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) ### Bug Fixes * **deps:** Update module google.golang.org/api to v0.183.0 ([#18196](#18196)) ([55d0f64](55d0f64)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [4.2.0](plugins-destination-kafka-v4.1.3...plugins-destination-kafka-v4.2.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [2.9.0](plugins-destination-sqlite-v2.8.8...plugins-destination-sqlite-v2.9.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [4.1.0](plugins-destination-snowflake-v4.0.2...plugins-destination-snowflake-v4.1.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [7.2.0](plugins-destination-s3-v7.1.2...plugins-destination-s3-v7.2.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) ### Bug Fixes * **deps:** Update aws-sdk-go-v2 monorepo ([#18194](#18194)) ([8be9ca6](8be9ca6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [2.4.0](plugins-destination-meilisearch-v2.3.14...plugins-destination-meilisearch-v2.4.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [2.4.0](plugins-destination-mongodb-v2.3.14...plugins-destination-mongodb-v2.4.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [5.2.0](plugins-destination-neo4j-v5.1.14...plugins-destination-neo4j-v5.2.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [5.1.0](plugins-destination-mysql-v5.0.11...plugins-destination-mysql-v5.1.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [4.6.0](plugins-destination-mssql-v4.5.10...plugins-destination-mssql-v4.6.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [3.2.0](plugins-source-hackernews-v3.1.10...plugins-source-hackernews-v3.2.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [6.1.0](plugins-source-k8s-v6.0.17...plugins-source-k8s-v6.1.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [2.5.0](plugins-destination-gremlin-v2.4.14...plugins-destination-gremlin-v2.5.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) ### Bug Fixes * **deps:** Update aws-sdk-go-v2 monorepo ([#18193](#18193)) ([ae93290](ae93290)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [4.1.0](plugins-destination-clickhouse-v4.0.10...plugins-destination-clickhouse-v4.1.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [2.5.0](plugins-destination-firehose-v2.4.9...plugins-destination-firehose-v2.5.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) ### Bug Fixes * **deps:** Update aws-sdk-go-v2 monorepo ([#18192](#18192)) ([5b4250b](5b4250b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [4.1.0](plugins-destination-azblob-v4.0.3...plugins-destination-azblob-v4.1.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [4.0.0](plugins-destination-bigquery-v3.6.1...plugins-destination-bigquery-v4.0.0) (2024-06-11) ### ⚠ BREAKING CHANGES * Apache Arrow `timestamp` now always maps to BigQuery `timestamp` type ([#18198](#18198)). Previously, `timestamp` with `nanoseconds` precision was mapped to a `record` type. ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) ### Bug Fixes * **deps:** Update module google.golang.org/api to v0.183.0 ([#18195](#18195)) ([c560cfa](c560cfa)) * Support Apache Arrow types with non-default options ([#18198](#18198)). Previously some Apache Arrow types (namely, `timestamp` with non-default time zone) would result in plugin failure. ([4b775f9](4b775f9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [5.9.0](plugins-destination-duckdb-v5.8.1...plugins-destination-duckdb-v5.9.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [3.3.0](plugins-destination-elasticsearch-v3.2.15...plugins-destination-elasticsearch-v3.3.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [5.1.0](plugins-destination-file-v5.0.3...plugins-destination-file-v5.1.0) (2024-06-11) ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
Part of https://linear.app/cloudquery/issue/ENG-2544 Reverts #18165 - manually. Needs SDK update first: cloudquery/plugin-sdk#2372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1806.