feat: Add policy column to aws_efs_filesystems table#14672
Merged
kodiakhq[bot] merged 10 commits intocloudquery:mainfrom Oct 20, 2023
Merged
Conversation
Contributor
This PR has the following changes to source plugin(s) tables:
|
policy column to aws_efs_filesystems tablepolicy column to aws_efs_filesystems table
bbernays
requested changes
Oct 18, 2023
bbernays
reviewed
Oct 18, 2023
bbernays
reviewed
Oct 20, 2023
…resolveEfsFilesystemPolicy
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
bbernays
reviewed
Oct 20, 2023
bbernays
requested changes
Oct 20, 2023
Collaborator
bbernays
left a comment
There was a problem hiding this comment.
This PR is almost there! one last issues/change about the column name
bbernays
approved these changes
Oct 20, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
🤖 I have created a release *beep* *boop* --- ## [22.16.0](plugins-source-aws-v22.15.2...plugins-source-aws-v22.16.0) (2023-10-23) ### This Release has the Following Changes to Tables - Table `aws_efs_filesystems`: column added with name `file_system_policy` and type `utf8` ### Features * Add `policy` column to `aws_efs_filesystems` table ([#14672](#14672)) ([833b9c2](833b9c2)) ### Bug Fixes * Changed the condition to check for policies in policies table ([#13935](#13935)) ([f136331](f136331)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to f46436f ([#14803](#14803)) ([f5248d7](f5248d7)) * **deps:** Update module github.com/cloudquery/codegen to v0.3.10 ([#14773](#14773)) ([98f3e2c](98f3e2c)) * **deps:** Update module github.com/cloudquery/codegen to v0.3.11 ([#14870](#14870)) ([4fa917d](4fa917d)) * Don't call GetFunctionCodeSigningConfig or GetRuntimeManagementConfig on Lambdas packaged as Images (`aws_lambda_functions`) ([#14729](#14729)) ([6fc30d3](6fc30d3)) * Handle `NotFound` error when syncing Subscriptions with deleted topic (`aws_sns_subscriptions`) ([#14771](#14771)) ([6fcf43d](6fcf43d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolves #14632
I'm looking for a way to reduce the duplicate implementations, for example, the following part is a way to get a service to resolve data for the table. It works well when a table relays on a single resolver. But if a table needs multiple resolver then might be a good way to do it.
Use the following steps to ensure your PR is ready to be reviewed
make lintto ensure the proposed changes follow the coding style 🚨 (install golangci-lint here)make testto ensure the proposed changes pass the tests 🧪make gento ensure docs are up to date 📝