Skip to content

feat: Add policy column to aws_efs_filesystems table#14672

Merged
kodiakhq[bot] merged 10 commits intocloudquery:mainfrom
cychiang:feat-add-efs-filesystem-policy-to-filesystems-table
Oct 20, 2023
Merged

feat: Add policy column to aws_efs_filesystems table#14672
kodiakhq[bot] merged 10 commits intocloudquery:mainfrom
cychiang:feat-add-efs-filesystem-policy-to-filesystems-table

Conversation

@cychiang
Copy link
Copy Markdown
Contributor

@cychiang cychiang commented Oct 18, 2023

Summary

resolves #14632

I'm looking for a way to reduce the duplicate implementations, for example, the following part is a way to get a service to resolve data for the table. It works well when a table relays on a single resolver. But if a table needs multiple resolver then might be a good way to do it.

	p := resource.Item.(types.FileSystemDescription)
	config := efs.DescribeFileSystemPolicyInput{
		FileSystemId: p.FileSystemId,
	}
	cl := meta.(*client.Client)
	svc := cl.Services(client.AWSServiceEfs).Efs

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run make lint to ensure the proposed changes follow the coding style 🚨 (install golangci-lint here)
  • Run make test to ensure the proposed changes pass the tests 🧪
  • If changing a source plugin run make gen to ensure docs are up to date 📝
  • Ensure the status checks below are successful ✅

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/plugin/source/aws area/website automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add EFS FileSystemPolicy to AWS source plugin

3 participants