fix: Remove unnecessary type registration#14573
Merged
kodiakhq[bot] merged 3 commits intomainfrom Oct 16, 2023
Merged
Conversation
disq
approved these changes
Oct 16, 2023
candiduslynx
approved these changes
Oct 16, 2023
Contributor
Author
|
Tests failing due to #14548, the issue I was actually trying to fix when finding this issue 🙃 |
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
🤖 I have created a release *beep* *boop* --- ## [5.0.1](plugins-destination-duckdb-v5.0.0...plugins-destination-duckdb-v5.0.1) (2023-10-18) ### Bug Fixes * Compile DuckDB, SQLite and Snowflake plugins for running under Alpine Linux ([#14612](#14612)) ([c47cd1c](c47cd1c)) * Conditional static linking for linux/amd64 for DuckDB, SQLite and Snowflake ([#14626](#14626)) ([0ba7e3f](0ba7e3f)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.9 ([#14627](#14627)) ([c1d244c](c1d244c)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.3.0 ([#14635](#14635)) ([00b380c](00b380c)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.4.0 ([#14639](#14639)) ([f139c0e](f139c0e)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.14.0 ([#14577](#14577)) ([223c4c1](223c4c1)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.15.0 ([#14622](#14622)) ([b497a6b](b497a6b)) * Remove unnecessary type registration ([#14573](#14573)) ([5e3aad2](5e3aad2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
Without this, running `go test -count 2` fails with:
```
--- FAIL: TestPlugin (0.00s)
client_test.go:16: arrow: type extension with name uuid already defined
```
No other plugins call this in the tests anymore, and I think it's a leftover from a previous migration. The registration now happens automatically in the plugin serve method.
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
) 🤖 I have created a release *beep* *boop* --- ## [5.0.1](cloudquery/cloudquery@plugins-destination-duckdb-v5.0.0...plugins-destination-duckdb-v5.0.1) (2023-10-18) ### Bug Fixes * Compile DuckDB, SQLite and Snowflake plugins for running under Alpine Linux ([cloudquery#14612](cloudquery#14612)) ([c47cd1c](cloudquery@c47cd1c)) * Conditional static linking for linux/amd64 for DuckDB, SQLite and Snowflake ([cloudquery#14626](cloudquery#14626)) ([0ba7e3f](cloudquery@0ba7e3f)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.9 ([cloudquery#14627](cloudquery#14627)) ([c1d244c](cloudquery@c1d244c)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.3.0 ([cloudquery#14635](cloudquery#14635)) ([00b380c](cloudquery@00b380c)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.4.0 ([cloudquery#14639](cloudquery#14639)) ([f139c0e](cloudquery@f139c0e)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.14.0 ([cloudquery#14577](cloudquery#14577)) ([223c4c1](cloudquery@223c4c1)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.15.0 ([cloudquery#14622](cloudquery#14622)) ([b497a6b](cloudquery@b497a6b)) * Remove unnecessary type registration ([cloudquery#14573](cloudquery#14573)) ([5e3aad2](cloudquery@5e3aad2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, running
go test -count 2fails with:No other plugins call this in the tests anymore, and I think it's a leftover from a previous migration. The registration now happens automatically in the plugin serve method.