Skip to content

Commit 0ba7e3f

Browse files
authored
fix: Conditional static linking for linux/amd64 for DuckDB, SQLite and Snowflake (#14626)
In #14612 we added static linking to the DuckDB, SQLite and Snowflake plugins, but this broke Darwin buils. As it is only needed for Linux images I have added conditional overrides to the goreleaser yml config.
1 parent 0575d45 commit 0ba7e3f

3 files changed

Lines changed: 17 additions & 3 deletions

File tree

plugins/destination/duckdb/.goreleaser.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ builds:
2222
- CC=/usr/bin/gencc.sh
2323
- CXX=/usr/bin/gencpp.sh
2424
ldflags:
25-
- -s -w -X github.com/cloudquery/cloudquery/plugins/{{ .Var.component }}/resources/plugin.Version={{.Version}} -linkmode external -extldflags=-static
25+
- -s -w -X github.com/cloudquery/cloudquery/plugins/{{ .Var.component }}/resources/plugin.Version={{.Version}}
2626
goos:
2727
# Windows disabled due to https://github.com/marcboeker/go-duckdb/issues/51
2828
# - windows
@@ -37,6 +37,11 @@ builds:
3737
# linux arm64 has some issues with cross-compile
3838
- goos: linux
3939
goarch: arm64
40+
overrides:
41+
- goos: linux
42+
goarch: amd64
43+
ldflags:
44+
- -s -w -X github.com/cloudquery/cloudquery/plugins/{{ .Var.component }}/resources/plugin.Version={{.Version}} -linkmode external -extldflags=-static
4045

4146
after:
4247
hooks:

plugins/destination/snowflake/.goreleaser.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ builds:
2222
- CC=/usr/bin/gencc.sh
2323
- CXX=/usr/bin/gencpp.sh
2424
ldflags:
25-
- -s -w -X github.com/cloudquery/cloudquery/plugins/{{ .Var.component }}/resources/plugin.Version={{.Version}} -linkmode external -extldflags=-static
25+
- -s -w -X github.com/cloudquery/cloudquery/plugins/{{ .Var.component }}/resources/plugin.Version={{.Version}}
2626
goos:
2727
- windows
2828
- linux
@@ -45,6 +45,10 @@ builds:
4545
- GO111MODULE=on
4646
- CC=/usr/bin/gencc.sh
4747
- CXX=/usr/bin/gencpp.sh
48+
- goos: linux
49+
goarch: amd64
50+
ldflags:
51+
- -s -w -X github.com/cloudquery/cloudquery/plugins/{{ .Var.component }}/resources/plugin.Version={{.Version}} -linkmode external -extldflags=-static
4852
after:
4953
hooks:
5054
- cmd: unzip -o {{ .Var.binary }}_darwin_arm64.zip

plugins/destination/sqlite/.goreleaser.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ builds:
2222
- CC=/usr/bin/gencc.sh
2323
- CXX=/usr/bin/gencpp.sh
2424
ldflags:
25-
- -s -w -X github.com/cloudquery/cloudquery/plugins/{{ .Var.component }}/resources/plugin.Version={{.Version}} -linkmode external -extldflags=-static
25+
- -s -w -X github.com/cloudquery/cloudquery/plugins/{{ .Var.component }}/resources/plugin.Version={{.Version}}
2626
goos:
2727
- windows
2828
- linux
@@ -36,6 +36,11 @@ builds:
3636
# linux arm64 has some issues with cross-compile
3737
- goos: linux
3838
goarch: arm64
39+
overrides:
40+
- goos: linux
41+
goarch: amd64
42+
ldflags:
43+
- -s -w -X github.com/cloudquery/cloudquery/plugins/{{ .Var.component }}/resources/plugin.Version={{.Version}} -linkmode external -extldflags=-static
3944

4045
after:
4146
hooks:

0 commit comments

Comments
 (0)