feat: Use autogenerated JSON schema by candiduslynx · Pull Request #14111 · cloudquery/cloudquery

candiduslynx · 2023-09-28T05:03:23Z

Follow-up for #13876
Blocked by:

plugins/source/gcp/go.mod

plugins/source/gcp/client/spec/schema.json

hermanschaaf · 2023-10-02T13:47:51Z

plugins/source/gcp/client/spec/schema.json

        },
        "folder_ids": {
-          "title": "Folder IDs",
-          "description": "Location of the projects to sync from. Mutually exclusive with project_filter",


What happened to all the descriptions?

I removed them (they can be added via jsonschema_description tag, but the code lines would look too long).

I guess we can experiment with the descriptions & generating docs from the schema later, but for now, the descriptions don't give any additional info to the validation errors, so I suppose it's OK to omit them.

hermanschaaf · 2023-10-02T14:22:10Z

Could we split the GCP SDK update into a separate PR so that it's separate from the JSONSchema update and shows as a different entry in the changelog?

Extracted from #14111

Same as #14111 but for Oracle source plugin

🤖 I have created a release *beep* *boop* --- ## [9.7.0](plugins-source-gcp-v9.6.2...plugins-source-gcp-v9.7.0) (2023-10-04) ### This Release has the Following Changes to Tables - Table `gcp_aiplatform_index_endpoints`: column added with name `encryption_spec` and type `json` - Table `gcp_aiplatform_indexes`: column added with name `encryption_spec` and type `json` - Table `gcp_aiplatform_pipeline_jobs`: column added with name `schedule_name` and type `utf8` - Table `gcp_baremetalsolution_instances`: column added with name `firmware_version` and type `utf8` - Table `gcp_baremetalsolution_instances`: column added with name `login_info` and type `utf8` - Table `gcp_baremetalsolution_instances`: column added with name `volumes` and type `json` - Table `gcp_baremetalsolution_instances`: column added with name `workload_profile` and type `utf8` - Table `gcp_baremetalsolution_networks`: column added with name `gateway_ip` and type `utf8` - Table `gcp_baremetalsolution_networks`: column added with name `jumbo_frames_enabled` and type `bool` - Table `gcp_baremetalsolution_networks`: column added with name `mount_points` and type `json` - Table `gcp_baremetalsolution_networks`: column added with name `pod` and type `utf8` - Table `gcp_baremetalsolution_nfs_shares`: column added with name `id` and type `utf8` - Table `gcp_baremetalsolution_nfs_shares`: column added with name `requested_size_gib` and type `int64` - Table `gcp_baremetalsolution_nfs_shares`: column added with name `storage_type` and type `utf8` - Table `gcp_baremetalsolution_volume_luns`: column added with name `expire_time` and type `timestamp[us, tz=UTC]` - Table `gcp_baremetalsolution_volume_luns`: column added with name `instances` and type `list<item: utf8, nullable>` - Table `gcp_baremetalsolution_volumes`: column added with name `attached` and type `bool` - Table `gcp_baremetalsolution_volumes`: column added with name `boot_volume` and type `bool` - Table `gcp_baremetalsolution_volumes`: column added with name `expire_time` and type `timestamp[us, tz=UTC]` - Table `gcp_baremetalsolution_volumes`: column added with name `instances` and type `list<item: utf8, nullable>` - Table `gcp_baremetalsolution_volumes`: column added with name `max_size_gib` and type `int64` - Table `gcp_baremetalsolution_volumes`: column added with name `notes` and type `utf8` - Table `gcp_baremetalsolution_volumes`: column added with name `originally_requested_size_gib` and type `int64` - Table `gcp_baremetalsolution_volumes`: column added with name `performance_tier` and type `utf8` - Table `gcp_baremetalsolution_volumes`: column added with name `protocol` and type `utf8` - Table `gcp_baremetalsolution_volumes`: column added with name `workload_profile` and type `utf8` - Table `gcp_logging_metrics`: column added with name `bucket_name` and type `utf8` - Table `gcp_workflows_workflows`: column added with name `call_log_level` and type `utf8` - Table `gcp_workflows_workflows`: column added with name `crypto_key_name` and type `utf8` - Table `gcp_workflows_workflows`: column added with name `state_error` and type `json` - Table `gcp_workflows_workflows`: column added with name `user_env_vars` and type `json` ### Features * Update GCP libraries ([#14274](#14274)) ([aecb60e](aecb60e)) * Use autogenerated JSON schema ([#14111](#14111)) ([6cdf961](6cdf961)) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v14 digest to 00efb06 ([#14202](#14202)) ([fc8cc62](fc8cc62)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to 7ded38b ([#14246](#14246)) ([005891e](005891e)) * **deps:** Update github.com/petermattis/goid digest to 1876fd5 ([#14234](#14234)) ([3b56924](3b56924)) * **deps:** Update module github.com/cloudquery/codegen to v0.3.4 ([#14284](#14284)) ([84fb893](84fb893)) * **services:** Update GCP Services ([#14263](#14263)) ([5dcf494](5dcf494)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Extracted from cloudquery#14111

Follow-up for cloudquery#13876 Blocked by: - [x] invopop/jsonschema#103 - [x] invopop/jsonschema#105 - [x] cloudquery/codegen#29 - [x] cloudquery/plugin-sdk#1254

Same as cloudquery#14111 but for Oracle source plugin

🤖 I have created a release *beep* *boop* --- ## [9.7.0](cloudquery/cloudquery@plugins-source-gcp-v9.6.2...plugins-source-gcp-v9.7.0) (2023-10-04) ### This Release has the Following Changes to Tables - Table `gcp_aiplatform_index_endpoints`: column added with name `encryption_spec` and type `json` - Table `gcp_aiplatform_indexes`: column added with name `encryption_spec` and type `json` - Table `gcp_aiplatform_pipeline_jobs`: column added with name `schedule_name` and type `utf8` - Table `gcp_baremetalsolution_instances`: column added with name `firmware_version` and type `utf8` - Table `gcp_baremetalsolution_instances`: column added with name `login_info` and type `utf8` - Table `gcp_baremetalsolution_instances`: column added with name `volumes` and type `json` - Table `gcp_baremetalsolution_instances`: column added with name `workload_profile` and type `utf8` - Table `gcp_baremetalsolution_networks`: column added with name `gateway_ip` and type `utf8` - Table `gcp_baremetalsolution_networks`: column added with name `jumbo_frames_enabled` and type `bool` - Table `gcp_baremetalsolution_networks`: column added with name `mount_points` and type `json` - Table `gcp_baremetalsolution_networks`: column added with name `pod` and type `utf8` - Table `gcp_baremetalsolution_nfs_shares`: column added with name `id` and type `utf8` - Table `gcp_baremetalsolution_nfs_shares`: column added with name `requested_size_gib` and type `int64` - Table `gcp_baremetalsolution_nfs_shares`: column added with name `storage_type` and type `utf8` - Table `gcp_baremetalsolution_volume_luns`: column added with name `expire_time` and type `timestamp[us, tz=UTC]` - Table `gcp_baremetalsolution_volume_luns`: column added with name `instances` and type `list<item: utf8, nullable>` - Table `gcp_baremetalsolution_volumes`: column added with name `attached` and type `bool` - Table `gcp_baremetalsolution_volumes`: column added with name `boot_volume` and type `bool` - Table `gcp_baremetalsolution_volumes`: column added with name `expire_time` and type `timestamp[us, tz=UTC]` - Table `gcp_baremetalsolution_volumes`: column added with name `instances` and type `list<item: utf8, nullable>` - Table `gcp_baremetalsolution_volumes`: column added with name `max_size_gib` and type `int64` - Table `gcp_baremetalsolution_volumes`: column added with name `notes` and type `utf8` - Table `gcp_baremetalsolution_volumes`: column added with name `originally_requested_size_gib` and type `int64` - Table `gcp_baremetalsolution_volumes`: column added with name `performance_tier` and type `utf8` - Table `gcp_baremetalsolution_volumes`: column added with name `protocol` and type `utf8` - Table `gcp_baremetalsolution_volumes`: column added with name `workload_profile` and type `utf8` - Table `gcp_logging_metrics`: column added with name `bucket_name` and type `utf8` - Table `gcp_workflows_workflows`: column added with name `call_log_level` and type `utf8` - Table `gcp_workflows_workflows`: column added with name `crypto_key_name` and type `utf8` - Table `gcp_workflows_workflows`: column added with name `state_error` and type `json` - Table `gcp_workflows_workflows`: column added with name `user_env_vars` and type `json` ### Features * Update GCP libraries ([cloudquery#14274](cloudquery#14274)) ([aecb60e](cloudquery@aecb60e)) * Use autogenerated JSON schema ([cloudquery#14111](cloudquery#14111)) ([6cdf961](cloudquery@6cdf961)) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v14 digest to 00efb06 ([cloudquery#14202](cloudquery#14202)) ([fc8cc62](cloudquery@fc8cc62)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to 7ded38b ([cloudquery#14246](cloudquery#14246)) ([005891e](cloudquery@005891e)) * **deps:** Update github.com/petermattis/goid digest to 1876fd5 ([cloudquery#14234](cloudquery#14234)) ([3b56924](cloudquery@3b56924)) * **deps:** Update module github.com/cloudquery/codegen to v0.3.4 ([cloudquery#14284](cloudquery#14284)) ([84fb893](cloudquery@84fb893)) * **services:** Update GCP Services ([cloudquery#14263](cloudquery#14263)) ([5dcf494](cloudquery@5dcf494)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

candiduslynx added the no automerge label Sep 28, 2023

candiduslynx requested review from disq and yevgenypats as code owners September 28, 2023 05:03

cq-bot added the gcp label Sep 28, 2023

candiduslynx commented Sep 28, 2023

View reviewed changes

plugins/source/gcp/go.mod Outdated Show resolved Hide resolved

candiduslynx requested a review from hermanschaaf September 28, 2023 06:17

candiduslynx force-pushed the feat/jsonschema/gcp-autogen branch from 13ba1ee to 1400011 Compare September 28, 2023 07:07

candiduslynx commented Sep 28, 2023

View reviewed changes

plugins/source/gcp/go.mod Outdated Show resolved Hide resolved

candiduslynx force-pushed the feat/jsonschema/gcp-autogen branch from 1400011 to 487d3e6 Compare September 28, 2023 10:42

candiduslynx changed the title ~~feat: Use autogenerates JSON schema~~ feat: Use autogenerated JSON schema Sep 28, 2023

candiduslynx force-pushed the feat/jsonschema/gcp-autogen branch from 52add69 to 70426c1 Compare September 29, 2023 04:46

candiduslynx commented Sep 29, 2023

View reviewed changes

plugins/source/gcp/client/spec/schema.json Show resolved Hide resolved

candiduslynx added automerge Automatically merge once required checks pass and removed no automerge labels Oct 2, 2023

hermanschaaf reviewed Oct 2, 2023

View reviewed changes

candiduslynx force-pushed the feat/jsonschema/gcp-autogen branch from 63a1229 to ad2f965 Compare October 2, 2023 13:50

candiduslynx requested a review from hermanschaaf October 2, 2023 13:51

cq-bot added the website label Oct 2, 2023

candiduslynx requested a review from erezrokah as a code owner October 2, 2023 14:04

cq-bot added the ci label Oct 2, 2023

candiduslynx force-pushed the feat/jsonschema/gcp-autogen branch from f26e615 to a78462d Compare October 2, 2023 14:10

candiduslynx mentioned this pull request Oct 2, 2023

feat: Update GCP libraries #14274

Merged

kodiakhq bot pushed a commit that referenced this pull request Oct 2, 2023

feat: Update GCP libraries (#14274)

aecb60e

Extracted from #14111

candiduslynx added 6 commits October 2, 2023 17:53

rm title & desc

cc381ba

add id

1444155

fix CredentialsConfig

b5d97c6

start spec fix

679ddbe

finalize spec

cd0b042

use gen

77017cd

candiduslynx added 3 commits October 2, 2023 17:54

regen

642fb19

use generated schema from sdk

b5ea5d8

print the schema on err

0470d4a

candiduslynx force-pushed the feat/jsonschema/gcp-autogen branch from a78462d to 0470d4a Compare October 2, 2023 14:55

cq-bot removed website labels Oct 2, 2023

hermanschaaf approved these changes Oct 2, 2023

View reviewed changes

Merge branch 'main' into feat/jsonschema/gcp-autogen

e6bf172

kodiakhq bot merged commit 6cdf961 into main Oct 2, 2023

kodiakhq bot deleted the feat/jsonschema/gcp-autogen branch October 2, 2023 15:07

cq-bot mentioned this pull request Oct 2, 2023

chore(main): Release plugins-source-gcp v9.7.0 #14236

Merged

candiduslynx mentioned this pull request Oct 2, 2023

feat: Use autogenerated JSON schema #14275

Merged

kodiakhq bot pushed a commit that referenced this pull request Oct 3, 2023

feat: Use autogenerated JSON schema (#14275)

eb183a9

Same as #14111 but for Oracle source plugin

hydratim pushed a commit to hydratim/cloudquery that referenced this pull request Oct 20, 2023

feat: Update GCP libraries (cloudquery#14274)

02a568d

Extracted from cloudquery#14111

hydratim pushed a commit to hydratim/cloudquery that referenced this pull request Oct 20, 2023

feat: Use autogenerated JSON schema (cloudquery#14275)

ba524f1

Same as cloudquery#14111 but for Oracle source plugin

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Use autogenerated JSON schema#14111

feat: Use autogenerated JSON schema#14111
kodiakhq[bot] merged 10 commits intomainfrom
feat/jsonschema/gcp-autogen

candiduslynx commented Sep 28, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hermanschaaf Oct 2, 2023

Uh oh!

candiduslynx Oct 2, 2023

Uh oh!

hermanschaaf commented Oct 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

candiduslynx commented Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hermanschaaf Oct 2, 2023

Choose a reason for hiding this comment

Uh oh!

candiduslynx Oct 2, 2023

Choose a reason for hiding this comment

Uh oh!

hermanschaaf commented Oct 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

candiduslynx commented Sep 28, 2023 •

edited

Loading