Skip to content

Document missing component metadata fields#1840

Merged
aknysh merged 1 commit intomainfrom
osterman/metadata-docs-restructure
Dec 5, 2025
Merged

Document missing component metadata fields#1840
aknysh merged 1 commit intomainfrom
osterman/metadata-docs-restructure

Conversation

@osterman
Copy link
Member

@osterman osterman commented Dec 5, 2025

what

  • Moved metadata documentation to stacks/components/ with clearer sidebar label components.*.metadata
  • Added documentation for three missing metadata fields: terraform_workspace, terraform_workspace_pattern, and custom
  • Updated all cross-references to use new URL structure
  • Added bidirectional links between metadata and workspaces documentation

why

Component metadata is currently under-documented. The schema defines 8 metadata fields, but the documentation only covered 5. The location stacks/metadata.mdx also implied stack-level configuration, creating confusion. Moving to stacks/components/metadata.mdx clarifies that metadata is only valid under components.terraform.<name>.metadata.

references

  • Schema: pkg/datafetcher/schema/atmos/manifest/1.0.json
  • Related docs: website/docs/components/terraform/workspaces.mdx

@osterman osterman requested a review from a team as a code owner December 5, 2025 04:27
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2025

Warning

Rate limit exceeded

@osterman has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 43 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 38eb63c and cab4f7d.

📒 Files selected for processing (8)
  • website/docs/components/terraform/workspaces.mdx (1 hunks)
  • website/docs/howto/inheritance.mdx (1 hunks)
  • website/docs/stacks/components/helmfile.mdx (1 hunks)
  • website/docs/stacks/components/index.mdx (1 hunks)
  • website/docs/stacks/components/metadata.mdx (2 hunks)
  • website/docs/stacks/components/packer.mdx (1 hunks)
  • website/docs/stacks/components/terraform.mdx (1 hunks)
  • website/docs/stacks/stacks.mdx (1 hunks)
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch osterman/metadata-docs-restructure

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the size/s Small size PR label Dec 5, 2025
- Move metadata.mdx to stacks/components/ with sidebar label `components.*.metadata`
- Add documentation for terraform_workspace field (literal workspace override)
- Add documentation for terraform_workspace_pattern field (pattern with context tokens)
- Add documentation for custom field (user extension point for arbitrary metadata)
- Update all cross-references to use new /stacks/components/component-metadata URL
- Add cross-reference from workspaces.mdx back to metadata page

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@osterman osterman force-pushed the osterman/metadata-docs-restructure branch from b39848a to cab4f7d Compare December 5, 2025 04:27
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.17%. Comparing base (38eb63c) to head (cab4f7d).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1840      +/-   ##
==========================================
+ Coverage   72.13%   72.17%   +0.04%     
==========================================
  Files         475      475              
  Lines       45713    45713              
==========================================
+ Hits        32974    32993      +19     
+ Misses      10118    10099      -19     
  Partials     2621     2621              
Flag Coverage Δ
unittests 72.17% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@osterman osterman added the no-release Do not create a new release (wait for additional code changes) label Dec 5, 2025
@aknysh aknysh merged commit ed4c02b into main Dec 5, 2025
64 of 65 checks passed
@aknysh aknysh deleted the osterman/metadata-docs-restructure branch December 5, 2025 18:14
osterman added a commit that referenced this pull request Dec 6, 2025
Brings in recent changes from main including:
- Native devcontainer support (#1697)
- Version constraint validation for atmos.yaml (#1759)
- Fix for empty backend.tf.json generation (#1833)
- Document missing component metadata fields (#1840)

Resolved conflicts:
- cmd/root.go: Added both devcontainer and init/scaffold imports
- Test snapshot will be regenerated to include devcontainer command

Note: Pre-existing linting issues in init/scaffold experimental code
remain and will be addressed before merging to main.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Do not create a new release (wait for additional code changes) size/s Small size PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants