fix: correct pager default to false as intended by PR #1430 by osterman · Pull Request #1642 · cloudposse/atmos

osterman · 2025-10-16T02:23:13Z

what

Fix regression where pager was enabled by default despite PR fix: disable pager mouse interactions and add global --pager flag #1430 intending to disable it
Change v.SetDefault("settings.terminal.pager", true) to false in pkg/config/load.go

why

PR fix: disable pager mouse interactions and add global --pager flag #1430 (commit 08a44dd) documented a BREAKING CHANGE: "Pager is now disabled by default"
However, the actual default value in setDefaultConfiguration() was never changed from true to false
This caused the pager to remain enabled by default for users without explicit pager: false in their atmos.yaml
The repository's own atmos.yaml has pager: false which masked the issue locally

references

Regression introduced in: commit 2325ab9 (PR add pager to describe config command #1203)
Intended fix that was incomplete: commit 08a44dd (PR fix: disable pager mouse interactions and add global --pager flag #1430)
Related file: pkg/config/load.go:159

Summary by CodeRabbit

Changes
- Terminal pager is now disabled by default so command output displays directly in the terminal for easier piping, copying, and quick scanning.
- You can re-enable paging via configuration, a CLI flag, or an environment variable.
Bug Fixes
- Removed an extraneous debug message from CLI stderr to reduce noise.
Documentation
- Added a blog post explaining the pager default correction, impact, and how to opt back in.

coderabbitai · 2025-10-16T02:23:24Z

📝 Walkthrough

Walkthrough

Default CLI configuration changed: settings.terminal.pager now defaults to false. Test snapshots were updated to reflect the new default and a removed debug line. A blog post documenting the pager default correction was added.

Changes

Cohort / File(s)	Summary
Config defaults `pkg/config/load.go`	Changed default for `settings.terminal.pager` from `true` to `false` in `setDefaultConfiguration`.
Test snapshots `tests/snapshots/TestCLICommands_atmos_describe_configuration.stdout.golden`, `tests/snapshots/TestCLICommands_atmos_describe_configuration.stderr.golden`	Updated stdout snapshot to show `terminal.pager` as `0` instead of `1`; removed a `DEBU Failed to use pager` line from the stderr snapshot.
Website / docs `website/blog/2025-10-15-pager-default-correction.md`	Added blog post explaining the pager default correction, impact, and how to opt into paging (config/CLI/env).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

patch, tests, docs

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly summarizes the primary change by stating the correction of the pager default to false and uses the conventional “fix:” prefix while referencing the original PR for context, all in a concise single sentence that directly aligns with the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch osterman/fix-pager-default

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9d75d92 and f52239d.

📒 Files selected for processing (1)

website/blog/2025-10-15-pager-default-correction.md (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

website/**

📄 CodeRabbit inference engine (.cursor/rules/atmos-rules.mdc)

website/**: Update website documentation in website/ when adding features
Ensure consistency between CLI help text and website documentation
Follow the website's documentation structure and style
Keep website code in website/ and follow its architecture/style; test changes locally
Keep CLI and website documentation in sync; document new features with examples and use cases

Files:

website/blog/2025-10-15-pager-default-correction.md

🪛 LanguageTool

website/blog/2025-10-15-pager-default-correction.md

[style] ~16-~16: ‘with the intention of’ might be wordy. Consider a shorter alternative.
Context: ... in September 2025, PR #1430 was merged with the intention of changing this default to improve the sc...

(EN_WORDINESS_PREMIUM_WITH_THE_INTENTION_OF)

[grammar] ~18-~18: There might be a mistake here.
Context: ... PR included: - A global --pager flag - Support for the NO_PAGER environment v...

(QB_NEW_EN)

[grammar] ~19-~19: There might be a mistake here.
Context: ... for the NO_PAGER environment variable - Documentation stating: "**BREAKING CHANG...

(QB_NEW_EN)

[typographical] ~20-~20: Consider using a typographic opening quote here.
Context: ...nment variable - Documentation stating: "BREAKING CHANGE: Pager is now disabl...

(EN_QUOTES)

[typographical] ~20-~20: Consider using a typographic close quote here.
Context: ...ANGE**: Pager is now disabled by default" However, the actual default value in t...

(EN_QUOTES)

[grammar] ~82-~82: There might be a mistake here.
Context: ...s - PR #1642: Pager Default Correction - [Original PR #1430: Pager Improvements](h...

(QB_NEW_EN)

[grammar] ~83-~83: There might be a mistake here.
Context: ...- Original PR #1430: Pager Improvements - [Terminal Configuration Documentation](/c...

(QB_NEW_EN)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

GitHub Check: Build (ubuntu-latest, linux)
GitHub Check: Build (windows-latest, windows)
GitHub Check: Lint (golangci)
GitHub Check: Analyze (go)
GitHub Check: website-deploy-preview
GitHub Check: Summary

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Update test snapshots to reflect the corrected pager default value: - Change pager from "1" (true) to "0" (false) in describe configuration output - Remove "Failed to use pager" debug message from stderr (pager is now disabled by default) These changes align with the fix in the previous commit where the pager default was corrected to false as originally intended by PR #1430.

codecov · 2025-10-16T02:55:07Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.02%. Comparing base (ba4a2de) to head (714c8be).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
+ Coverage   64.97%   65.02%   +0.04%     
==========================================
  Files         338      338              
  Lines       37535    37535              
==========================================
+ Hits        24388    24406      +18     
+ Misses      11201    11182      -19     
- Partials     1946     1947       +1

Flag	Coverage Δ
unittests	`65.02% <100.00%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/config/load.go	`80.17% <100.00%> (ø)`

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add blog post explaining the regression and its fix: - Describes the history of the pager default issue - Explains impact on users - Provides migration guide for those who relied on pager being enabled - Links to relevant PRs and documentation This blog post helps users understand why the pager behavior may have changed and how to re-enable it if desired.

…fault

Change documentation link from /cli/configuration/settings#terminal-settings to /cli/configuration/terminal to fix broken link in blog post.

github-actions · 2025-10-17T04:40:43Z

These changes were released in v1.195.0-test.0.

fix: correct pager default to false as intended by PR #1430

717bf1e

osterman requested a review from a team as a code owner October 16, 2025 02:23

github-actions bot added the size/xs Extra small size PR label Oct 16, 2025

coderabbitai bot previously approved these changes Oct 16, 2025

View reviewed changes

aknysh previously approved these changes Oct 16, 2025

View reviewed changes

osterman added the patch A minor, backward compatible change label Oct 16, 2025

osterman dismissed stale reviews from aknysh and coderabbitai[bot] via 313ee61 October 16, 2025 02:43

coderabbitai bot previously approved these changes Oct 16, 2025

View reviewed changes

osterman added 2 commits October 15, 2025 22:53

Merge branch 'main' into osterman/fix-pager-default

7a0c5cd

osterman dismissed coderabbitai[bot]’s stale review via 9d75d92 October 16, 2025 04:16

github-actions bot added size/s Small size PR and removed size/xs Extra small size PR labels Oct 16, 2025

coderabbitai bot previously approved these changes Oct 16, 2025

View reviewed changes

osterman added 2 commits October 16, 2025 08:39

Merge remote-tracking branch 'origin/main' into osterman/fix-pager-de…

b6b017d

…fault

fix: correct broken link in blog post

f52239d

Change documentation link from /cli/configuration/settings#terminal-settings to /cli/configuration/terminal to fix broken link in blog post.

osterman dismissed coderabbitai[bot]’s stale review via f52239d October 16, 2025 13:39

coderabbitai bot approved these changes Oct 16, 2025

View reviewed changes

github-actions bot deployed to preview October 16, 2025 13:43 View deployment

Merge branch 'main' into osterman/fix-pager-default

714c8be

aknysh approved these changes Oct 16, 2025

View reviewed changes

github-actions bot deployed to preview October 16, 2025 16:40 View deployment

osterman merged commit 87ac398 into main Oct 16, 2025
54 checks passed

osterman deleted the osterman/fix-pager-default branch October 16, 2025 16:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: correct pager default to false as intended by PR #1430#1642

fix: correct pager default to false as intended by PR #1430#1642
osterman merged 7 commits intomainfrom
osterman/fix-pager-default

osterman commented Oct 16, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 16, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested labels

Uh oh!

codecov bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

osterman commented Oct 16, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

what

why

references

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Pre-merge checks and finishing touches

Uh oh!

codecov bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

osterman commented Oct 16, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 16, 2025 •

edited

Loading

codecov bot commented Oct 16, 2025 •

edited

Loading