pkg/list/list_components.go (2)

34-49: DRY the per-type extraction loop.

Trim repetition by looping over known component types.

-	// Extract terraform components
-	if terraformComponents, ok := componentsMap["terraform"].(map[string]any); ok {
-		allComponents = append(allComponents, lo.Keys(terraformComponents)...)
-	}
-
-	// Extract helmfile components
-	if helmfileComponents, ok := componentsMap["helmfile"].(map[string]any); ok {
-		allComponents = append(allComponents, lo.Keys(helmfileComponents)...)
-	}
-
-	// Extract packer components
-	if packerComponents, ok := componentsMap["packer"].(map[string]any); ok {
-		allComponents = append(allComponents, lo.Keys(packerComponents)...)
-	}
+	componentTypes := []string{"terraform", "helmfile", "packer"}
+	for _, typ := range componentTypes {
+		if m, ok := componentsMap[typ].(map[string]any); ok {
+			allComponents = append(allComponents, lo.Keys(m)...)
+		}
+	}

---

56-56: Option: return a de-duped slice here.

Keeps single-stack callers clean even if types overlap; callers can still sort later.

-	return allComponents, nil
+	return lo.Uniq(allComponents), nil

pkg/list/list_components_test.go (2)

114-120: Good packer fixture; add a unit subtest that mixes all types.

Add a subtest in TestGetStackComponents to assert aggregation across terraform, helmfile, and packer in one stack.

t.Run("aggregates terraform, helmfile, and packer", func(t *testing.T) {
	stackData := map[string]any{
		"components": map[string]any{
			"terraform": map[string]any{"vpc": map[string]any{}},
			"helmfile":  map[string]any{"echo-server": map[string]any{}},
			"packer":    map[string]any{"ami": map[string]any{}},
		},
	}
	components, err := getStackComponents(stackData)
	require.NoError(t, err)
	assert.ElementsMatch(t, []string{"vpc", "echo-server", "ami"}, components)
})

---

130-134: Broaden exported-path coverage.

Consider adding helmfile/packer entries to TestFilterAndListComponents’ stacksMap to verify the exported FilterAndListComponents aggregates non-terraform types, not just unit helpers.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

pkg/list/list_components.go (1)

53-55: Wrap the “no components” error with context.

Adds call-site breadcrumbs and aligns with error-wrapping guidance. This echoes an earlier suggestion.

-	if len(allComponents) == 0 {
-		return nil, ErrNoComponentsFound
-	}
+	if len(allComponents) == 0 {
+		return nil, fmt.Errorf("getStackComponents: %w", ErrNoComponentsFound)
+	}

pkg/list/list_components.go (2)

36-51: Reduce maintenance by aggregating generically (and preallocate).

Rather than hard-coding terraform/helmfile/packer, iterate all component-type maps; this future-proofs for new types and trims allocations.

-	var allComponents []string
-
-	// Extract terraform components
-	if terraformComponents, ok := componentsMap["terraform"].(map[string]any); ok {
-		allComponents = append(allComponents, lo.Keys(terraformComponents)...)
-	}
-
-	// Extract helmfile components
-	if helmfileComponents, ok := componentsMap["helmfile"].(map[string]any); ok {
-		allComponents = append(allComponents, lo.Keys(helmfileComponents)...)
-	}
-
-	// Extract packer components
-	if packerComponents, ok := componentsMap["packer"].(map[string]any); ok {
-		allComponents = append(allComponents, lo.Keys(packerComponents)...)
-	}
+	// Aggregate keys from all component-type maps under "components".
+	size := 0
+	for _, v := range componentsMap {
+		if m, ok := v.(map[string]any); ok {
+			size += len(m)
+		}
+	}
+	allComponents := make([]string, 0, size)
+	for _, v := range componentsMap {
+		if m, ok := v.(map[string]any); ok {
+			allComponents = append(allComponents, lo.Keys(m)...)
+		}
+	}

---

25-34: Consistently wrap parse errors with context.

Keeps error chains descriptive while preserving sentinels.

-	stackMap, ok := stackData.(map[string]any)
+	stackMap, ok := stackData.(map[string]any)
 	if !ok {
-		return nil, ErrParseStacks
+		return nil, fmt.Errorf("getStackComponents: %w", ErrParseStacks)
 	}
 
-	componentsMap, ok := stackMap["components"].(map[string]any)
+	componentsMap, ok := stackMap["components"].(map[string]any)
 	if !ok {
-		return nil, ErrParseComponents
+		return nil, fmt.Errorf("getStackComponents: %w", ErrParseComponents)
 	}

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

pkg/list/list_components.go (1)

36-51: Reduce duplication by looping over supported component types.

Same pattern repeated 3x; iterate over a small allowlist for maintainability.

-	// Extract terraform components
-	if terraformComponents, ok := componentsMap["terraform"].(map[string]any); ok {
-		allComponents = append(allComponents, lo.Keys(terraformComponents)...)
-	}
-
-	// Extract helmfile components
-	if helmfileComponents, ok := componentsMap["helmfile"].(map[string]any); ok {
-		allComponents = append(allComponents, lo.Keys(helmfileComponents)...)
-	}
-
-	// Extract packer components
-	if packerComponents, ok := componentsMap["packer"].(map[string]any); ok {
-		allComponents = append(allComponents, lo.Keys(packerComponents)...)
-	}
+	// Extract components for known types
+	for _, t := range []string{"terraform", "helmfile", "packer"} {
+		if m, ok := componentsMap[t].(map[string]any); ok {
+			allComponents = append(allComponents, lo.Keys(m)...)
+		}
+	}

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.