Conversation
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
Contributor
There was a problem hiding this comment.
golangci-lint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1441 +/- ##
==========================================
+ Coverage 55.59% 55.98% +0.38%
==========================================
Files 273 274 +1
Lines 28626 28928 +302
==========================================
+ Hits 15916 16194 +278
- Misses 10927 10940 +13
- Partials 1783 1794 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
go-getter to th latest versiongo-getter to the latest version
|
Warning This PR exceeds the recommended limit of 1,000 lines.Large PRs are difficult to review and may be rejected due to their size. Please verify that this PR does not address multiple issues. |
* test: increase test coverage for go-getter downloader to 77.7% - Add comprehensive tests for GetCustom() method covering various scenarios (89.1% coverage) - Add tests for git operations: clone (90.9%), update (86.5%), checkout (100%), fetchSubmodules (100%) - Add tests for findRemoteDefaultBranch() method (100% coverage) - Add tests for CustomGitGetter.Get() method (100% coverage) - Define static errors in errors/errors.go to comply with golangci-lint err113 - Format code with gofumpt - Overall package coverage increased from 46.1% to 77.7% 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * [autofix.ci] apply automated fixes * updates --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: aknysh <andriy.knysh@gmail.com>
osterman
previously approved these changes
Sep 3, 2025
- Replace deprecated io/ioutil with os.CreateTemp - Add constants for magic numbers (base10, portBitSize, sshKeyFileMode) - Add constants for repeated strings (gitCommand, originRemote, gitArgSeparator) - Create gitOperationParams struct to reduce function arguments - Fix invalid URL construction in tests - Remove unused return values from test helper functions - Fix potential index out of bounds issue - Add #nosec comments for validated subprocess commands - Apply gofumpt formatting Reduces linting issues from 20 to 6 (remaining are complexity warnings)
|
These changes were released in v1.189.0. |
osterman
added a commit
that referenced
this pull request
Sep 5, 2025
- Resolve conflict in .gitignore by combining both test artifact entries - Includes latest main branch changes: - Update go-getter to latest version (#1441) - Make inline atmos config override config from imports (#1447) - Replace t.Skip with t.Skipf throughout codebase (#1449) - Maintains all gotcha-related changes from feature branch
osterman
added a commit
that referenced
this pull request
Sep 23, 2025
* updates * updates * updates * updates * updates * updates * [autofix.ci] apply automated fixes * updates * [autofix.ci] apply automated fixes * updates * updates * updates * updates * test: increase test coverage for go-getter downloader to 77.7% (#1443) * test: increase test coverage for go-getter downloader to 77.7% - Add comprehensive tests for GetCustom() method covering various scenarios (89.1% coverage) - Add tests for git operations: clone (90.9%), update (86.5%), checkout (100%), fetchSubmodules (100%) - Add tests for findRemoteDefaultBranch() method (100% coverage) - Add tests for CustomGitGetter.Get() method (100% coverage) - Define static errors in errors/errors.go to comply with golangci-lint err113 - Format code with gofumpt - Overall package coverage increased from 46.1% to 77.7% 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * [autofix.ci] apply automated fixes * updates --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: aknysh <andriy.knysh@gmail.com> * fix: resolve golangci-lint issues in pkg/downloader (#1445) - Replace deprecated io/ioutil with os.CreateTemp - Add constants for magic numbers (base10, portBitSize, sshKeyFileMode) - Add constants for repeated strings (gitCommand, originRemote, gitArgSeparator) - Create gitOperationParams struct to reduce function arguments - Fix invalid URL construction in tests - Remove unused return values from test helper functions - Fix potential index out of bounds issue - Add #nosec comments for validated subprocess commands - Apply gofumpt formatting Reduces linting issues from 20 to 6 (remaining are complexity warnings) --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <erik@cloudposse.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
go-getterto the latest versionDisableSymlinksconfigurable on thegitclientwhy
"CVE-2025-8959", Score: 7.5
HashiCorp's go-getter library subdirectory download feature is vulnerable to symlink attacks leading to unauthorized
read access beyond the designated directory boundaries. This vulnerability, identified as "CVE-2025-8959",
is fixed in go-getter 1.7.9.
Read More: https://www.mend.io/vulnerability-database/CVE-2025-8959