tests/snapshots/TestCLICommands_atmos_warns_if_not_in_git_repo_with_no_atmos_config.stdout.golden (1)

4-5: Empty stacks dir placeholder — please confirm it's expected.

Message shows “set to ,”. If that blank is intentional for “no config” scenarios, all good (not blocking). Per prior learnings, we won’t suggest changing snapshot text that mirrors real output.

I can help open a follow-up to improve the runtime message (not the snapshot) if this wasn’t intentional.

tests/snapshots/TestCLICommands_atmos_atlantis_generate_repo-config_help.stderr.golden (1)

3-3: Trim trailing space at EOL (nit).

Line ends with a space after the comma; this can cause brittle snapshots. If intentional per snapshot policy, ignore.

tests/snapshots/TestCLICommands_atmos_terraform_--help.stderr.golden (1)

3-3: Trailing space at EOL (nit).

Same minor whitespace at the end of the line.

tests/snapshots/TestCLICommands_atmos_atlantis_generate_help.stderr.golden (1)

3-3: Trim EOL space (nit).

Minor trailing whitespace here as well.

tests/snapshots/TestCLICommands_atmos_atlantis_generate_repo-config_--help.stderr.golden (1)

3-3: Trailing whitespace (nit).

Same note on the space after the comma.

tests/snapshots/TestCLICommands_atmos_doesnt_warn_if_in_git_repo_with_no_atmos_config.stderr.golden (1)

3-3: Minor: remove trailing space (nit).

Consistent nit with other snapshots.

tests/snapshots/TestCLICommands_atmos.stdout.golden (1)

2-3: Handle empty vs. missing stacks directory distinctly

Currently, when the stacksDir setting is unset or empty, the CLI emits:

CLI config file specifies the directory for Atmos stacks as ,
but the directory does not exist.

That leaves an awkward blank before the comma. To improve clarity and UX:

• If no stacks directory is configured, emit:
  CLI config file does not specify the stacks directory.
• If a path is configured but doesn’t exist, emit:
  CLI config file specifies the directory for Atmos stacks as '<path>', but the directory does not exist.

This change is optional but will make the output more readable. All stdout snapshots have been verified to be telemetry-free.

tests/snapshots/TestCLICommands_atmos_atlantis_generate_repo-config.stdout.golden (1)

2-3: Empty stacks directory placeholder

This produces “as , but the directory does not exist.” Consider conditional phrasing for empty values to avoid dangling punctuation and improve clarity.

Happy to propose a small helper that formats this message based on presence/absence of the path.

tests/snapshots/TestCLICommands_atmos_doesnt_warn_if_in_git_repo_with_no_atmos_config.stdout.golden (1)

4-5: Tighten messaging when default stacks dir is unset

“The default Atmos stacks directory is set to , but…” reads odd when empty. Suggest: if unset → “Default stacks directory is not configured.” If set-but-missing → include the path.

Want me to open a follow-up PR to centralize this formatting?

pkg/telemetry/utils.go (1)

135-166: Optional: guard against repeat prints when cache is unavailable.

If LoadCache/SaveCache fails, disclosure may print more than once per process. Consider a process-level guard (sync.Once or atomic.Bool) to suppress repeats even when persistence fails.

Example:

+var disclosureShownInProcess atomic.Bool
+
 func disclosureMessage() string {
+	if disclosureShownInProcess.Load() {
+		return ""
+	}
 	// Do not show disclosure if running in CI
 	if isCI() {
 		return ""
 	}
 	// Only show disclosure if telemetry is enabled
 	telemetry := getTelemetryFromConfig()
 	if telemetry == nil || !telemetry.isEnabled {
 		return ""
 	}
 	TelemetryDisclosureShown := getOrInitializeCacheValue(
 		func(cfg *cfg.CacheConfig) bool { return cfg.TelemetryDisclosureShown },
 		func(cfg *cfg.CacheConfig, _ bool) { cfg.TelemetryDisclosureShown = true },
 		false,
 	)
 	if TelemetryDisclosureShown {
 		return ""
 	}
+	disclosureShownInProcess.Store(true)
 	return DisclosureMessage
 }

pkg/telemetry/utils_test.go (1)

544-612: Make the test capture both streams in one call to avoid leaking output; use assert.Contains.

Current approach prints to real stderr during the stdout capture phase. Capture both streams in a single invocation and assert with testify helpers for clarity.

Apply:

 func TestPrintTelemetryDisclosureOutputsToStderr(t *testing.T) {
@@
-	// Helper function to capture stdout
-	captureStdout := func(f func()) string {
-		old := os.Stdout
-		r, w, _ := os.Pipe()
-		os.Stdout = w
-
-		f()
-
-		w.Close()
-		os.Stdout = old
-
-		var buf bytes.Buffer
-		io.Copy(&buf, r)
-		return buf.String()
-	}
-
-	// Helper function to capture stderr
-	captureStderr := func(f func()) string {
-		old := os.Stderr
-		r, w, _ := os.Pipe()
-		os.Stderr = w
-
-		f()
-
-		w.Close()
-		os.Stderr = old
-
-		var buf bytes.Buffer
-		io.Copy(&buf, r)
-		return buf.String()
-	}
+	// Helper to capture stdout and stderr together to prevent leaking to test logs
+	captureStreams := func(f func()) (string, string) {
+		oldOut, oldErr := os.Stdout, os.Stderr
+		rOut, wOut, _ := os.Pipe()
+		rErr, wErr, _ := os.Pipe()
+		os.Stdout, os.Stderr = wOut, wErr
+
+		var stdoutBuf, stderrBuf bytes.Buffer
+		done := make(chan struct{}, 2)
+		go func() { io.Copy(&stdoutBuf, rOut); rOut.Close(); done <- struct{}{} }()
+		go func() { io.Copy(&stderrBuf, rErr); rErr.Close(); done <- struct{}{} }()
+
+		f()
+
+		wOut.Close()
+		wErr.Close()
+		os.Stdout, os.Stderr = oldOut, oldErr
+		<-done
+		<-done
+		return stdoutBuf.String(), stderrBuf.String()
+	}
@@
-	// Capture stdout - should be empty
-	stdoutOutput := captureStdout(func() {
-		PrintTelemetryDisclosure()
-	})
-
-	// Reset cache for stderr test
-	cacheCfg.TelemetryDisclosureShown = false
-	cfg.SaveCache(cacheCfg)
-
-	// Capture stderr - should contain the disclosure message
-	stderrOutput := captureStderr(func() {
-		PrintTelemetryDisclosure()
-	})
+	// Capture both streams in a single call
+	stdoutOutput, stderrOutput := captureStreams(func() {
+		PrintTelemetryDisclosure()
+	})
@@
-	assert.Empty(t, stdoutOutput, "Telemetry disclosure should not write to stdout")
+	assert.Empty(t, stdoutOutput, "Telemetry disclosure should not write to stdout")
@@
-	assert.True(t, strings.Contains(stderrOutput, "Notice: Atmos now collects"),
-		"Telemetry disclosure should write to stderr")
+	assert.Contains(t, stderrOutput, "Notice: Atmos now collects",
+		"Telemetry disclosure should write to stderr")
 }

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: samtholiya
PR: cloudposse/atmos#955
File: tests/snapshots/TestCLICommands_atmos_validate_editorconfig_--help.stdout.golden:0-0
Timestamp: 2025-01-19T15:49:15.593Z
Learning: In future commits, the help text for Atmos CLI commands should be limited to only show component and stack parameters for commands that actually use them. This applies to the example usage section in command help text.

Learnt from: Listener430
PR: cloudposse/atmos#1149
File: tests/snapshots/TestCLICommands_atmos_vendor_pull_ssh.stderr.golden:7-7
Timestamp: 2025-03-18T12:26:25.329Z
Learning: In the Atmos project, typos or inconsistencies in test snapshot files (such as "terrafrom" instead of "terraform") may be intentional as they capture the exact output of commands and should not be flagged as issues requiring correction.

Learnt from: Listener430
PR: cloudposse/atmos#1061
File: tests/snapshots/TestCLICommands_atmos_vendor_pull_ssh.stderr.golden:8-8
Timestamp: 2025-02-14T23:12:38.030Z
Learning: Test snapshots in the Atmos project, particularly for dry run scenarios, may be updated during the development process, and temporary inconsistencies in their content should not be flagged as issues.

Learnt from: samtholiya
PR: cloudposse/atmos#959
File: cmd/workflow.go:74-74
Timestamp: 2025-01-30T19:30:59.120Z
Learning: Error handling for `cmd.Usage()` is not required in the Atmos CLI codebase, as confirmed by the maintainer.

Learnt from: Listener430
PR: cloudposse/atmos#825
File: internal/exec/helmfile_generate_varfile.go:28-31
Timestamp: 2024-12-07T16:16:13.038Z
Learning: In `internal/exec/helmfile_generate_varfile.go`, the `--help` command (`./atmos helmfile generate varfile --help`) works correctly without requiring stack configurations, and the only change needed was to make `ProcessCommandLineArgs` exportable by capitalizing its name.

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-07-01T02:22:25.901Z
Learning: Ensure consistency between CLI help text and website documentation

Learnt from: aknysh
PR: cloudposse/atmos#1363
File: internal/exec/template_utils.go:18-18
Timestamp: 2025-07-05T20:59:02.914Z
Learning: In the Atmos project, gomplate v4 is imported with a blank import (`_ "github.com/hairyhenderson/gomplate/v4"`) alongside v3 imports to resolve AWS SDK version conflicts. V3 uses older AWS SDK versions that conflict with newer AWS modules used by Atmos. A full migration to v4 requires extensive refactoring due to API changes and should be handled in a separate PR.

Learnt from: samtholiya
PR: cloudposse/atmos#1077
File: pkg/downloader/custom_github_detector.go:0-0
Timestamp: 2025-02-21T20:56:05.539Z
Learning: The `github.com/charmbracelet/log` package should be imported with the alias `log` according to the project's import alias configuration.

Learnt from: RoseSecurity
PR: cloudposse/atmos#797
File: pkg/list/atmos.yaml:213-214
Timestamp: 2024-11-25T17:17:15.703Z
Learning: The file `pkg/list/atmos.yaml` is primarily intended for testing purposes.

Learnt from: osterman
PR: cloudposse/atmos#808
File: examples/demo-atmos-cli-imports/atmos.yaml:8-8
Timestamp: 2025-01-25T15:21:40.413Z
Learning: In Atmos, when a directory is specified for configuration loading (e.g., in the `import` section of atmos.yaml), all files within that directory should be treated as Atmos configurations. Do not suggest restricting file extensions in directory-based glob patterns.

Learnt from: Listener430
PR: cloudposse/atmos#844
File: cmd/helmfile.go:37-37
Timestamp: 2024-12-11T18:40:12.808Z
Learning: In the atmos project, `cliConfig` is initialized within the `cmd` package in `root.go` and can be used in other command files.

Learnt from: haitham911
PR: cloudposse/atmos#736
File: pkg/config/const.go:6-6
Timestamp: 2024-10-20T13:12:46.499Z
Learning: In `cmd/cmd_utils.go`, it's acceptable to have hardcoded references to `atmos.yaml` in logs, and it's not necessary to update them to use the `CliConfigFileName` constant.

Learnt from: osterman
PR: cloudposse/atmos#740
File: cmd/cmd_utils.go:340-359
Timestamp: 2024-10-23T21:36:40.262Z
Learning: In the Go codebase for Atmos, when reviewing functions like `checkAtmosConfig` in `cmd/cmd_utils.go`, avoid suggesting refactoring to return errors instead of calling `os.Exit` if such changes would significantly increase the scope due to the need to update multiple call sites.

Learnt from: samtholiya
PR: cloudposse/atmos#959
File: cmd/cmd_utils.go:121-148
Timestamp: 2025-02-03T05:57:18.407Z
Learning: The Atmos CLI should fail fast (exit) when encountering configuration errors, including command alias configuration issues, to prevent undefined behavior. Use LogErrorAndExit instead of returning errors in such cases.

Learnt from: aknysh
PR: cloudposse/atmos#810
File: examples/tests/stacks/catalog/terraform/template-functions-test2/defaults.yaml:28-32
Timestamp: 2024-12-01T00:33:20.298Z
Learning: In `examples/tests/stacks/catalog/terraform/template-functions-test2/defaults.yaml`, `!exec atmos terraform output` is used in examples to demonstrate its usage, even though `!terraform.output` is the recommended approach according to the documentation.

Learnt from: osterman
PR: cloudposse/atmos#808
File: pkg/config/config.go:478-483
Timestamp: 2024-12-02T21:26:32.337Z
Learning: In the 'atmos' project, when reviewing Go code like `pkg/config/config.go`, avoid suggesting file size checks after downloading remote configs if such checks aren't implemented elsewhere in the codebase.

Learnt from: samtholiya
PR: cloudposse/atmos#1068
File: tests/snapshots/TestCLICommands_atmos_terraform_help.stdout.golden:59-64
Timestamp: 2025-02-18T13:13:11.497Z
Learning: For Atmos CLI help text, angle brackets in command examples and flag descriptions should be escaped using HTML entities (e.g., `<component>`) rather than converted to backticks or other markdown formatting.

cmd/cmd_utils_test.go (1)

196-202: Consider memoizing the packer presence check to avoid repeated LookPath calls.
This keeps test startup a bit snappier when many tests use the guard.

Apply this diff to the helper:

 func skipIfPackerNotInstalled(t *testing.T) {
 	t.Helper()
-	if _, err := exec.LookPath("packer"); err != nil {
-		t.Skip("Skipping test: packer is not installed or not in PATH")
-	}
+	packerOnce.Do(func() {
+		_, err := exec.LookPath("packer")
+		packerInPath = (err == nil)
+	})
+	if !packerInPath {
+		t.Skip("Skipping test: packer is not installed or not in PATH")
+	}
 }

Also add the following outside this range:

// add to imports
import "sync"

// add near top-level in this file
var (
	packerOnce   sync.Once
	packerInPath bool
)

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: samtholiya
PR: cloudposse/atmos#1255
File: cmd/describe_affected_test.go:15-15
Timestamp: 2025-05-23T19:51:47.091Z
Learning: The atmos codebase has a custom extension to *testing.T that provides a Chdir method, allowing test functions to call t.Chdir() to change working directories during tests. This is used consistently across test files in the codebase.

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-07-01T02:22:25.901Z
Learning: Applies to **/*_test.go : Test both happy paths and error conditions

cmd/terraform_test.go (3)

19-29: Prefer t.Setenv over os.Setenv + manual cleanup.

Reduces boilerplate and auto-restores env.

-    err := os.Setenv("ATMOS_CLI_CONFIG_PATH", stacksPath)
-    assert.NoError(t, err, "Setting 'ATMOS_CLI_CONFIG_PATH' environment variable should execute without error")
-
-    err = os.Setenv("ATMOS_BASE_PATH", stacksPath)
-    assert.NoError(t, err, "Setting 'ATMOS_BASE_PATH' environment variable should execute without error")
-
-    // Unset env values after testing
-    defer func() {
-        os.Unsetenv("ATMOS_BASE_PATH")
-        os.Unsetenv("ATMOS_CLI_CONFIG_PATH")
-    }()
+    t.Setenv("ATMOS_CLI_CONFIG_PATH", stacksPath)
+    t.Setenv("ATMOS_BASE_PATH", stacksPath)

---

65-69: Apply t.Setenv here too.

Same simplification for TestTerraformRun2.

-    // Unset env values after testing
-    defer func() {
-        os.Unsetenv("ATMOS_BASE_PATH")
-        os.Unsetenv("ATMOS_CLI_CONFIG_PATH")
-    }()
+    // t.Setenv will auto-clean these

---

99-109: Use t.Setenv in TestTerraformRun3 as well.

Keeps all three tests consistent and cleaner.

-    err := os.Setenv("ATMOS_CLI_CONFIG_PATH", stacksPath)
-    assert.NoError(t, err, "Setting 'ATMOS_CLI_CONFIG_PATH' environment variable should execute without error")
-
-    err = os.Setenv("ATMOS_BASE_PATH", stacksPath)
-    assert.NoError(t, err, "Setting 'ATMOS_BASE_PATH' environment variable should execute without error")
-
-    // Unset env values after testing
-    defer func() {
-        os.Unsetenv("ATMOS_BASE_PATH")
-        os.Unsetenv("ATMOS_CLI_CONFIG_PATH")
-    }()
+    t.Setenv("ATMOS_CLI_CONFIG_PATH", stacksPath)
+    t.Setenv("ATMOS_BASE_PATH", stacksPath)

cmd/terraform_generate_varfile_test.go (1)

17-24: Use t.Setenv to simplify env setup and teardown.

Less noise; auto cleanup.

-    err := os.Setenv("ATMOS_CLI_CONFIG_PATH", stacksPath)
-    assert.NoError(t, err, "Setting 'ATMOS_CLI_CONFIG_PATH' environment variable should execute without error")
-
-    err = os.Setenv("ATMOS_BASE_PATH", stacksPath)
-    assert.NoError(t, err, "Setting 'ATMOS_BASE_PATH' environment variable should execute without error")
-
-    err = os.Setenv("ATMOS_LOGS_LEVEL", "Debug")
-    assert.NoError(t, err, "Setting 'ATMOS_LOGS_LEVEL' environment variable should execute without error")
+    t.Setenv("ATMOS_CLI_CONFIG_PATH", stacksPath)
+    t.Setenv("ATMOS_BASE_PATH", stacksPath)
+    t.Setenv("ATMOS_LOGS_LEVEL", "Debug")

Outside the selected lines, also change the first later assignment to declare err:

// before
err = Execute()
// after
err := Execute()

Also applies to: 36-41

cmd/terraform_generate_backend_test.go (1)

17-24: Likewise, switch to t.Setenv for brevity.

Consistent with other tests.

-    err := os.Setenv("ATMOS_CLI_CONFIG_PATH", stacksPath)
-    assert.NoError(t, err, "Setting 'ATMOS_CLI_CONFIG_PATH' environment variable should execute without error")
-
-    err = os.Setenv("ATMOS_BASE_PATH", stacksPath)
-    assert.NoError(t, err, "Setting 'ATMOS_BASE_PATH' environment variable should execute without error")
-
-    err = os.Setenv("ATMOS_LOGS_LEVEL", "Debug")
-    assert.NoError(t, err, "Setting 'ATMOS_LOGS_LEVEL' environment variable should execute without error")
+    t.Setenv("ATMOS_CLI_CONFIG_PATH", stacksPath)
+    t.Setenv("ATMOS_BASE_PATH", stacksPath)
+    t.Setenv("ATMOS_LOGS_LEVEL", "Debug")

Outside the selected lines, also declare err at first use:

// before
err = Execute()
// after
err := Execute()

Also applies to: 36-41

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: aknysh
PR: cloudposse/atmos#825
File: internal/exec/terraform.go:30-30
Timestamp: 2024-12-07T16:19:01.683Z
Learning: In `internal/exec/terraform.go`, skipping stack validation when help flags are present is not necessary.

Learnt from: Listener430
PR: cloudposse/atmos#825
File: internal/exec/helmfile_generate_varfile.go:28-31
Timestamp: 2024-12-07T16:16:13.038Z
Learning: In `internal/exec/helmfile_generate_varfile.go`, the `--help` command (`./atmos helmfile generate varfile --help`) works correctly without requiring stack configurations, and the only change needed was to make `ProcessCommandLineArgs` exportable by capitalizing its name.

internal/exec/helmfile_test.go (1)

6-6: Alias os/exec to avoid confusion with package exec.

Within package exec, importing os/exec as exec is easy to misread. Prefer osexec.

-import (
+import (
   "bytes"
   "os"
-  "os/exec"
+  osexec "os/exec"
   "strings"
   "testing"
 )
@@
-  if _, err := exec.LookPath("helmfile"); err != nil {
+  if _, err := osexec.LookPath("helmfile"); err != nil {

cmd/helmfile_test.go (1)

11-11: Ensure the helper marks itself as a test helper.

In cmd/cmd_utils_test.go, add t.Helper() inside skipIfHelmfileNotInstalled for cleaner failure locations.

 func skipIfHelmfileNotInstalled(t *testing.T) {
+  t.Helper()
   if _, err := exec.LookPath("helmfile"); err != nil {
     t.Skip("Skipping test: helmfile is not installed or not in PATH")
   }
 }

internal/exec/terraform_test.go (3)

21-24: Good skips; consider DRYing with a helper and aliasing os/exec.

• Create a local test helper skipIfTerraformNotInstalled(t) and reuse it in each test.
• Alias os/exec to osexec for readability inside package exec.

-import (
+import (
   "bytes"
   "os"
-  "os/exec"
+  osexec "os/exec"
   "strings"
   "testing"
@@
-  if _, err := exec.LookPath("terraform"); err != nil {
+  if _, err := osexec.LookPath("terraform"); err != nil {
     t.Skip("Skipping test: terraform is not installed or not in PATH")
   }

Add once in this file:

// test-only helper
func skipIfTerraformNotInstalled(t *testing.T) {
  t.Helper()
  if _, err := osexec.LookPath("terraform"); err != nil {
    t.Skip("Skipping test: terraform is not installed or not in PATH")
  }
}

Then replace the repeated guards with skipIfTerraformNotInstalled(t).

Also applies to: 115-118, 183-186, 253-256, 318-321, 359-362, 427-430, 471-474, 547-550

---

6-6: Alias import to avoid name ambiguity.

Within package exec, prefer osexec "os/exec".

-  "os/exec"
+  osexec "os/exec"

---

547-550: Prefer a single sink; also restore logger output.

You capture stderr into a pipe and also redirect logger to a buffer, then merge both. Consider capturing just one, or keep both but restore logger output.

-  oldStderr := os.Stderr
-  r, w, _ := os.Pipe()
-  os.Stderr = w
+  oldStderr := os.Stderr
+  r, w, _ := os.Pipe()
+  os.Stderr = w
+  defer func() {
+    os.Stderr = oldStderr
+    log.SetOutput(os.Stderr)
+  }()
@@
-  var buf bytes.Buffer
-  log.SetOutput(&buf)
+  var buf bytes.Buffer
+  log.SetOutput(&buf)
+  // Alternatively, remove the pipe and capture only the logger:
+  // (drop the r/w pipe entirely if all messages are via log)

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: Listener430
PR: cloudposse/atmos#825
File: internal/exec/helmfile_generate_varfile.go:28-31
Timestamp: 2024-12-07T16:16:13.038Z
Learning: In `internal/exec/helmfile_generate_varfile.go`, the `--help` command (`./atmos helmfile generate varfile --help`) works correctly without requiring stack configurations, and the only change needed was to make `ProcessCommandLineArgs` exportable by capitalizing its name.

Learnt from: aknysh
PR: cloudposse/atmos#1352
File: pkg/store/artifactory_store_test.go:108-113
Timestamp: 2025-08-15T14:43:41.030Z
Learning: In test files for the atmos project, it's acceptable to ignore errors from os.Setenv/Unsetenv operations during test environment setup and teardown, as these are controlled test scenarios.

Learnt from: osterman
PR: cloudposse/atmos#808
File: examples/demo-atmos.d/atmos.d/tools/helmfile.yml:10-10
Timestamp: 2024-12-12T15:17:45.245Z
Learning: In `examples/demo-atmos.d/atmos.d/tools/helmfile.yml`, when suggesting changes to `kubeconfig_path`, ensure that the values use valid Go template syntax.

Learnt from: aknysh
PR: cloudposse/atmos#825
File: internal/exec/terraform.go:30-30
Timestamp: 2024-12-07T16:19:01.683Z
Learning: In `internal/exec/terraform.go`, skipping stack validation when help flags are present is not necessary.

Learnt from: haitham911
PR: cloudposse/atmos#727
File: internal/exec/terraform_clean.go:215-223
Timestamp: 2024-10-27T04:41:49.199Z
Learning: In `internal/exec/terraform_clean.go`, the function `determineCleanPath` is necessary and should not be removed.

Learnt from: aknysh
PR: cloudposse/atmos#759
File: internal/exec/terraform.go:366-368
Timestamp: 2024-11-02T15:35:09.958Z
Learning: In `internal/exec/terraform.go`, the workspace cleaning code under both the general execution path and within the `case "init":` block is intentionally duplicated because the code execution paths are different. The `.terraform/environment` file should be deleted before executing `terraform init` in both scenarios to ensure a clean state.

Learnt from: haitham911
PR: cloudposse/atmos#1195
File: internal/exec/terraform_clean.go:99-99
Timestamp: 2025-04-26T15:54:10.506Z
Learning: The error variable `ErrRelPath` is defined in `internal/exec/terraform_clean_util.go` and is used across files in the `exec` package, including in `terraform_clean.go`. This is part of an approach to standardize error handling in the codebase.

Learnt from: haitham911
PR: cloudposse/atmos#727
File: internal/exec/terraform_clean.go:155-175
Timestamp: 2024-10-27T04:28:40.966Z
Learning: In the `CollectDirectoryObjects` function in `internal/exec/terraform_clean.go`, recursive search through all subdirectories is not needed.

Learnt from: samtholiya
PR: cloudposse/atmos#1255
File: cmd/describe_affected_test.go:15-15
Timestamp: 2025-05-23T19:51:47.091Z
Learning: The atmos codebase has a custom extension to *testing.T that provides a Chdir method, allowing test functions to call t.Chdir() to change working directories during tests. This is used consistently across test files in the codebase.

Learnt from: samtholiya
PR: cloudposse/atmos#1255
File: cmd/describe_affected_test.go:15-15
Timestamp: 2025-05-23T19:51:47.091Z
Learning: In the atmos codebase, t.Chdir() is a valid method call on *testing.T objects and works correctly for changing directories in tests. This is implemented through custom testing framework extensions and is used consistently throughout the test suite.

Learnt from: samtholiya
PR: cloudposse/atmos#1255
File: cmd/describe_affected_test.go:15-15
Timestamp: 2025-05-23T19:51:47.091Z
Learning: In the atmos codebase, t.Chdir() is a valid method that can be called on *testing.T objects. This functionality is implemented through custom testing framework extensions and is used consistently throughout the test suite for changing working directories during tests.

Learnt from: samtholiya
PR: cloudposse/atmos#1255
File: cmd/describe_affected_test.go:15-15
Timestamp: 2025-05-23T19:51:47.091Z
Learning: In the atmos codebase, t.Chdir() is a valid method call on *testing.T objects and works correctly for changing directories in tests.

Learnt from: aknysh
PR: cloudposse/atmos#775
File: internal/exec/template_funcs_component.go:157-159
Timestamp: 2024-11-12T03:16:02.910Z
Learning: In the Go code for `componentFunc` in `internal/exec/template_funcs_component.go`, the function `cleanTerraformWorkspace` does not return errors, and it's acceptable if the file does not exist. Therefore, error handling for `cleanTerraformWorkspace` is not needed.

Learnt from: haitham911
PR: cloudposse/atmos#727
File: internal/exec/terraform_clean.go:407-416
Timestamp: 2024-11-24T19:13:10.287Z
Learning: In `internal/exec/terraform_clean.go`, when `getStackTerraformStateFolder` returns an error in the `handleCleanSubCommand` function, the error is logged, and the process continues without returning the error.

internal/aws_utils/aws_utils_test.go (1)

53-55: Optional: switch other env setup to t.Setenv and drop cleanupEnv.

Reduces risk of leaks if cleanup is skipped and simplifies the table.

Apply a small refactor:

@@
-       setupEnv   func()
-       cleanupEnv func()
+       setupEnv   func(t *testing.T)
@@
-           setupEnv: func() {
-               os.Setenv("AWS_ACCESS_KEY_ID", "test-key")
-               os.Setenv("AWS_SECRET_ACCESS_KEY", "test-secret")
-           },
-           cleanupEnv: func() {
-               os.Unsetenv("AWS_ACCESS_KEY_ID")
-               os.Unsetenv("AWS_SECRET_ACCESS_KEY")
-           },
+           setupEnv: func(t *testing.T) {
+               t.Setenv("AWS_ACCESS_KEY_ID", "test-key")
+               t.Setenv("AWS_SECRET_ACCESS_KEY", "test-secret")
+           },
@@
-           setupEnv: func() {
-               os.Setenv("AWS_ACCESS_KEY_ID", "test-key")
-               os.Setenv("AWS_SECRET_ACCESS_KEY", "test-secret")
-           },
-           cleanupEnv: func() {
-               os.Unsetenv("AWS_ACCESS_KEY_ID")
-               os.Unsetenv("AWS_SECRET_ACCESS_KEY")
-           },
+           setupEnv: func(t *testing.T) {
+               t.Setenv("AWS_ACCESS_KEY_ID", "test-key")
+               t.Setenv("AWS_SECRET_ACCESS_KEY", "test-secret")
+           },
@@
-           // Setup
-           if tt.setupEnv != nil {
-               tt.setupEnv()
-           }
+           // Setup
+           if tt.setupEnv != nil {
+               tt.setupEnv(t)
+           }
@@
-           // Cleanup
-           if tt.cleanupEnv != nil {
-               defer tt.cleanupEnv()
-           }
+           // No explicit cleanup needed; t.Setenv handles restoration.

internal/terraform_backend/terraform_backend_s3_test.go (1)

98-100: Optional: also hard-disable shared config autoloading.

Guard against environments exporting AWS_SDK_LOAD_CONFIG=1.

             // Clear AWS_PROFILE to prevent conflicts with local AWS configuration.
             t.Setenv("AWS_PROFILE", "")
+            // Ensure SDK does not read shared config/credentials.
+            t.Setenv("AWS_SDK_LOAD_CONFIG", "0")

pkg/store/aws_ssm_param_store_test.go (1)

588-590: Optional: add a tiny test helper to DRY this across files.

Keeps tests consistent and minimizes repetition.

Example helper (new file: internal/testutil/env.go):

package testutil

import "testing"

func ClearAWSProfile(t *testing.T) {
	t.Helper()
	t.Setenv("AWS_PROFILE", "")
}

Usage here:

- t.Setenv("AWS_PROFILE", "")
+ testutil.ClearAWSProfile(t)

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: aknysh
PR: cloudposse/atmos#1352
File: pkg/store/artifactory_store_test.go:108-113
Timestamp: 2025-08-15T14:43:41.030Z
Learning: In test files for the atmos project, it's acceptable to ignore errors from os.Setenv/Unsetenv operations during test environment setup and teardown, as these are controlled test scenarios.

tests/fixtures/scenarios/atmos-cli-imports-override/configs.d/commands.yaml (2)

6-6: Quote the step for consistency and to avoid accidental leading/trailing whitespace.

No behavior change; improves robustness across YAML parsers and aligns with other fixtures.

Apply this diff:

-      - atmos describe config
+      - "atmos describe config"

---

3-4: Optional: rename this fixture's "test" command to avoid cross‑fixture collisions

Multiple fixtures define a command named "test" (examples: tests/fixtures/scenarios/vendor/atmos.yaml, tests/fixtures/scenarios/vendor-globs/atmos.yaml, tests/fixtures/scenarios/atmos-configuration/atmos.d/commands.yaml, tests/fixtures/scenarios/atmos-cli-imports/configs.d/commands.yaml). Rename this fixture's command to a more specific name such as "imports-override:test" to avoid merge/override surprises.

.github/workflows/vhs.yaml (1)

17-17: Re-evaluate cancel-in-progress=false for CI efficiency.

Leaving old runs alive can waste minutes and capacity on rapid pushes. Consider enabling cancel-in-progress unless you have a concrete reason to preserve prior runs per group.

Do you want me to flip these to true and open a follow-up PR?

Also applies to: 64-64

.github/settings.yml (1)

15-23: Branch policy is effectively “allow all”; tighten or justify.

Including both "**/" and "" is redundant; "*" already matches everything (and ‘main’). If secrets are scoped to this environment, consider narrowing patterns or adding required reviewers.

Proposed cleanup:

   - name: screengrabs
     deployment_branch_policy:
       custom_branches:
-        - name: "main"
-          type: branch
-        - name: "**/*"
-          type: branch
-        - name: "*"
-          type: branch
+        - name: "main"
+          type: branch
+        - name: "release/*"
+          type: branch

Optional: add required reviewers/timeouts if you intend to guard env secrets.

.github/workflows/screengrabs.yaml (2)

38-38: Using environment secrets on pull_request can fail for forks.

Jobs referencing environments don’t get secrets on forked PRs; steps will fail. Gate by repo ownership or fall back to GITHUB_TOKEN.

   build:
     needs: [prepare]
     runs-on: ubuntu-latest
     environment: screengrabs
+    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false

---

75-80: GitHub App token: ensure permissions exist and storage location is safe.

Confirm the App has contents:write and pull_requests:write, and that the private key is stored at the environment or repo level appropriately.

If you want this to work on forks you’ll need a different path (workflow_run, PRs from branches only, or skip on forks).

.github/actions/remove-dependabot-semver-labels/action.yml (1)

1-83: Solid composite action; consider auto‑adding no-release and fix lint nit.

• Auto-add no-release to Dependabot PRs to reduce manual steps.
• YAML lint: trailing blank line at end (empty-lines warning).

Patch:

           const hasNoRelease = labels.some(l => l.name === 'no-release');
           if (!hasNoRelease) {
-            console.log('⚠️  Warning: no-release label is missing from this Dependabot PR');
-            console.log('    This label should be added via .github/dependabot.yml configuration');
+            console.log('Adding missing no-release label to Dependabot PR');
+            try {
+              await github.rest.issues.addLabels({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                issue_number: context.issue.number,
+                labels: ['no-release']
+              });
+              console.log('✓ Added: no-release');
+            } catch (error) {
+              console.warn(`Could not add no-release label: ${error.message}`);
+            }
           }

And remove the extra blank line at EOF.

.github/workflows/codeql.yml (1)

121-140: Label policy is strict; consider auto‑label on Dependabot or relax to “at least 1”.

If maintainers don’t add no-release automatically, this will block PRs. Either auto-add in the cleanup action (preferred) or relax the rule.

Want me to wire the auto‑label logic and update the composite action + this workflow in one patch?

.github/workflows/test.yml (2)

146-149: Pin actions to stable versions instead of @main.

Use tagged releases for hashicorp/setup-packer to reduce supply‑chain risk and surprise breakages.

Apply this pattern:

-uses: hashicorp/setup-packer@main
+uses: hashicorp/setup-packer@v3

Repeat for all three occurrences.

Also applies to: 301-304, 525-528

---

24-24: Confirm Packer 1.14.1 availability and compatibility.

• Packer v1.14.1 is an official release and hashicorp/setup-packer accepts "1.14.1" via its version input — the bump is valid; still run your plugins/tests to confirm runtime compatibility.
• Recommend pinning hashicorp/setup-packer to a stable tag (e.g., @v3) instead of @main for supply‑chain safety.

Want a quick diff for all occurrences?

cmd/describe_stacks.go (3)

67-71: Use the injected setter for testability/consistency.

Call the passed-in setter (g.setCliArgsForDescribeStackCli) instead of the package-level function.

Apply this diff:

-		err = setCliArgsForDescribeStackCli(cmd.Flags(), describe)
+		err = g.setCliArgsForDescribeStackCli(cmd.Flags(), describe)

---

114-118: Wrap errors per project style; avoid exit in library-ish helper.

fmt.Errorf without %w and CheckErrorPrintAndExit here make testing harder. Return a wrapped error instead.

Apply this diff:

-		default:
-			er := fmt.Errorf("unsupported type %T for flag %s", v, k)
-			errUtils.CheckErrorPrintAndExit(er, "", "")
+		default:
+			return fmt.Errorf("%w: unsupported type %T for flag %s", errUtils.ErrStaticError, v, k)

---

49-51: Nit: end comments with periods (godot).

Add trailing periods to satisfy lint.

Apply this diff:

-		// Check Atmos configuration
+		// Check Atmos configuration.
@@
-			// TODO: update this post pr:https://github.com/cloudposse/atmos/pull/1174 is merged
+			// TODO: Update this after PR https://github.com/cloudposse/atmos/pull/1174 is merged.

Also applies to: 73-75

cmd/describe_stacks_test.go (3)

95-105: Align flag types with production to catch mismatches.

These test-defined flags should be StringSlice to mirror the command and avoid silent gaps.

Apply this diff:

-			fs.String("components", "", "Filter by specific `atmos` components")
-			fs.String("component-types", "", "Filter by specific component types. Supported component types: terraform, helmfile")
-			fs.String("sections", "", "Output only the specified component sections. Available component sections: `backend`, `backend_type`, `deps`, `env`, `inheritance`, `metadata`, `remote_state_backend`, `remote_state_backend_type`, `settings`, `vars`")
+			fs.StringSlice("components", nil, "Filter by specific `atmos` components")
+			fs.StringSlice("component-types", nil, "Filter by specific component types. Supported component types: terraform, helmfile")
+			fs.StringSlice("sections", nil, "Output only the specified component sections. Available component sections: `backend`, `backend_type`, `deps`, `env`, `inheritance`, `metadata`, `remote_state_backend`, `remote_state_backend_type`, `settings`, `vars`")

---

145-145: Add a components parsing test for symmetry.

Covers the slice behavior and guards the bug fixed above.

+func TestSetCliArgs_Components_StringSlice(t *testing.T) {
+	fs := pflag.NewFlagSet("test", pflag.ContinueOnError)
+	fs.StringSlice("components", nil, "Filter by specific `atmos` components")
+	err := fs.Parse([]string{"--components=comp1,comp2"})
+	assert.NoError(t, err)
+
+	args := &exec.DescribeStacksArgs{}
+	err = setCliArgsForDescribeStackCli(fs, args)
+	assert.NoError(t, err)
+	assert.Equal(t, []string{"comp1", "comp2"}, args.Components)
+}

---

133-137: Nit: comment punctuation.

Terminate comments with periods to satisfy godot.

Apply this diff:

-	// Define only the flags we plan to change
+	// Define only the flags we plan to change.
@@
-	// Provide slice-style input (CSV is supported by pflag for StringSlice)
+	// Provide slice-style input (CSV is supported by pflag for StringSlice).

internal/exec/terraform_output_utils_other.go (1)

6-9: No-op stubs look good; tiny godot nit.

Add a period to the inline comment to satisfy the linter.

 func windowsFileDelay() {
-	// No delay needed on Unix-like systems
+	// No delay needed on Unix-like systems.
 }

internal/exec/terraform_utils.go (1)

54-61: Good Windows hardening via retry; add trailing period to comment.

Keeps behavior identical on non-Windows and handles file locks on Windows. Add a period to comply with godot.

-		// Use retry logic on Windows to handle file locking
+		// Use retry logic on Windows to handle file locking.
 		deleteErr := retryOnWindows(func() error {
 			return os.Remove(filePath)
 		})

internal/exec/terraform_output_utils.go (2)

256-277: Solid mitigation for Windows file-locking; polish comment punctuation.

Delays and retry wrapping are appropriate. Please add trailing periods to comments to satisfy godot.

-			// Add delay on Windows after workspace operations to prevent file locking
+			// Add delay on Windows after workspace operations to prevent file locking.
 			windowsFileDelay()
…
-		// Add small delay on Windows to prevent file locking issues
+		// Add small delay on Windows to prevent file locking issues.
 		windowsFileDelay()
 
-		// Wrap the output call with retry logic for Windows
+		// Wrap the output call with retry logic for Windows.
 		var outputMeta map[string]tfexec.OutputMeta

---

194-196: Optional: avoid fixed 5m timeout for Terraform ops.

Prior guidance discouraged timeouts on Terraform commands due to highly variable runtimes. Consider removing or making this configurable.

internal/exec/terraform_output_utils_other_test.go (2)

20-22: Deflake: relax non-Windows “no-op” timing threshold.

CI jitter can exceed 10ms. Bump to 50ms to avoid flakes.

-	assert.Less(t, elapsed.Milliseconds(), int64(10), "Expected no significant delay on non-Windows platforms")
+	assert.Less(t, elapsed.Milliseconds(), int64(50), "Expected no significant delay on non-Windows platforms")

---

63-65: Deflake: relax timing threshold on error path.

Same rationale as above.

-	assert.Less(t, elapsed.Milliseconds(), int64(10), "Expected no delay on non-Windows platforms even with errors")
+	assert.Less(t, elapsed.Milliseconds(), int64(50), "Expected no delay on non-Windows platforms even with errors")

internal/exec/terraform_output_utils_windows.go (2)

20-22: Fix doc to match actual attempt count.

Implementation performs up to 3 total attempts (not “retry 3 times”). Update wording.

-// It will retry up to 3 times with increasing delays.
+// It will attempt up to 3 times with increasing delays.

---

6-9: Simplify: runtime.GOOS checks are redundant under a Windows build tag.

Drop the checks and the runtime import; sleep and retry unconditionally in this file.

-import (
-	"runtime"
-	"time"
-)
+import "time"
@@
 func windowsFileDelay() {
-	if runtime.GOOS == "windows" {
-		time.Sleep(100 * time.Millisecond)
-	}
+	time.Sleep(100 * time.Millisecond)
 }
@@
 func retryOnWindows(fn func() error) error {
-	if runtime.GOOS != "windows" {
-		return fn()
-	}
+	// Windows build: always apply retries.

Also applies to: 15-17, 23-25

internal/exec/terraform_output_utils_windows_test.go (2)

20-23: Deflake: widen acceptable delay window.

Scheduling can push >150ms; widen upper bound.

-	assert.LessOrEqual(t, elapsed.Milliseconds(), int64(150), "Expected no more than 150ms delay on Windows")
+	assert.LessOrEqual(t, elapsed.Milliseconds(), int64(300), "Expected no more than 300ms delay on Windows")

---

73-75: Align comment with assertion.

Comment says 300ms min; assert checks 250ms. Make the comment match to avoid confusion.

-	// Should have delays: 100ms + 200ms = 300ms minimum.
-	assert.GreaterOrEqual(t, elapsed.Milliseconds(), int64(250), "Expected at least 250ms total delay for all retries")
+	// Should have cumulative delays of at least ~250ms (100ms + 200ms), allowing CI jitter.
+	assert.GreaterOrEqual(t, elapsed.Milliseconds(), int64(250), "Expected at least 250ms total delay for all retries")

internal/exec/terraform_output_utils_integration_test.go (1)

87-93: Deflake: relax non-Windows “no-op” threshold.

Match other tests; 50ms is safer on shared runners.

-		assert.Less(t, elapsed.Milliseconds(), int64(10), "Expected no significant delay on non-Windows")
+		assert.Less(t, elapsed.Milliseconds(), int64(50), "Expected no significant delay on non-Windows")

website/docs/integrations/github-actions/affected-stacks.mdx (1)

33-33: RemoteFile reachable (HTTP 200); pin to commit SHA & add CLI stderr note

• Verified the remote RawGitHub URL returns HTTP 200.
• Recommend pinning the refs/heads/master reference to a specific commit SHA to prevent future drift.
• Add a one-line CLI docs note that telemetry notices now emit to stderr (per PR objective).

tests/fixtures/scenarios/atmos-cli-imports-override/configs.d/vendor.yaml (1)

5-9: Trim commented variants or move to a dedicated variant fixture.

Comments are fine, but they can confuse future readers of this fixture. Consider either removing them or creating separate fixture files for the directory/absolute-path variants under the same scenario.

Apply if you prefer a minimal fixture:

   # Directory with multiple files
-  #base_path: "./vendor"
+  # base_path: "./vendor"
 
   # Absolute path
-  #base_path: "vendor.d/vendor1.yaml"
+  # base_path: "vendor.d/vendor1.yaml"

Or move these into dedicated files like:

• tests/fixtures/scenarios/atmos-cli-imports-override/configs.d/vendor-dir.yaml
• tests/fixtures/scenarios/atmos-cli-imports-override/configs.d/vendor-abs.yaml

website/docs/core-concepts/stacks/yaml-functions/yaml-functions.mdx (1)

138-141: Fix mismatch: comment says “remote JSON” but example is local.

Tighten the copy to avoid confusing readers.

Apply:

-        # Download a remote JSON file with .json extension and query data using YQ
-        # Note: URLs without extensions are treated as text, so use URLs with appropriate extensions
+        # Include a local JSON file with .json extension and query data using YQ
+        # Tip: For remote URLs, ensure the URL ends with .json (or save locally) so it's parsed, otherwise use !include.raw
         github_data: !include ./github-meta.json .api

website/docs/core-concepts/stacks/yaml-functions/include.mdx (2)

62-75: Minor: add a no‑extension URL example.

Consider one explicit example that shows a URL without extension returning a string to reinforce the Note.

Example:

# No extension => treated as plain text
raw_text: !include https://api.example.com/meta

---

292-295: Fix mismatch: comment says “remote JSON” but example is local.

Align the comment and example.

Apply:

-        # Download and include a remote JSON file from a URL with .json extension
-        # Note: For URLs without extensions, save locally first or use a URL with .json extension
-        github_config: !include ./github-meta.json .api
+        # Include a local JSON file with .json extension
+        # Tip: For remote URLs, prefer a .json URL (or save locally) so it parses as JSON; otherwise use !include.raw
+        github_config: !include ./github-meta.json .api

website/docs/core-concepts/stacks/yaml-functions/include.raw.mdx (1)

101-116: Docs: confirm URL examples and add short auth guidance for !include.raw

• Examples are correct: !include.raw uses go‑getter (pkg/utils/yaml_include_by_extension.go → downloader.NewGoGetterDownloader → FetchAndParseRaw) and supports http(s), s3://, gcs://, git, oci, scp, sftp.
• Query strings are ignored for extension detection (pkg/filetype/filetype_by_extension.go tests) — the ?version=2 example is fine.
• Auth details to document: Git token injection (pkg/downloader/custom_git_detector.go — resolveToken/getDefaultUsername); SSH key via ?sshkey= (pkg/downloader/get_git.go); S3/GCS rely on cloud provider credentials (AWS env/profile/instance role; GCP ADC / GOOGLE_APPLICATION_CREDENTIALS). Logs mask basic auth in debug output.
• Action: keep the examples, but add a 2–3 line note under them summarizing supported auth methods and recommending env vars/atmos.yaml tokens or the ?sshkey (base64) pattern instead of embedding secrets in docs.

pkg/list/list_components_test.go (3)

56-60: Make integration assertion resilient (use Subset instead of full ElementsMatch).

Hard-coding the full list is brittle against config drift. Assert a stable subset and keep the existing non‑empty checks.

-	assert.ElementsMatch(t, []string{
-		"aws/bastion", "echo-server", "infra/infra-server", "infra/infra-server-override",
-		"infra/vpc", "mixin/test-1", "mixin/test-2", "test/test-component",
-		"test/test-component-override", "test/test-component-override-2", "test/test-component-override-3",
-		"top-level-component1", "vpc", "vpc/new",
-	}, output)
+	expected := []string{
+		"aws/bastion", "echo-server", "infra/infra-server", "infra/infra-server-override",
+		"infra/vpc", "vpc", "vpc/new",
+	}
+	assert.Subset(t, output, expected)

---

114-120: Exercise multi‑source aggregation in a single stack (add helmfile to stack3).

Cover helmfile alongside packer in the same synthetic stack to validate union logic end‑to‑end.

 		"stack3": map[string]any{
 			"components": map[string]any{
+				"helmfile": map[string]any{
+					"ingress-nginx": map[string]any{},
+				},
 				"packer": map[string]any{
 					"ami": map[string]any{},
 				},
 			},
 		},

---

130-134: Rename test and assert both sources are included.

Reflect the multi‑source intent and assert helmfile + packer keys are returned.

-	t.Run("packer stack", func(t *testing.T) {
+	t.Run("multi-source stack", func(t *testing.T) {
 		components, err := getComponentsForSpecificStack("stack3", stacksMap)
 		require.NoError(t, err)
-		assert.ElementsMatch(t, []string{"ami"}, components)
+		assert.ElementsMatch(t, []string{"ami", "ingress-nginx"}, components)
 	})

pkg/list/list_components.go (1)

36-59: Preallocate and reduce map lookups in aggregation loop.

Minor alloc tweak: compute capacity and reuse extracted maps to avoid repeated type assertions.

-	var allComponents []string
-
-	// Extract terraform components
-	if terraformComponents, ok := componentsMap["terraform"].(map[string]any); ok {
-		allComponents = append(allComponents, lo.Keys(terraformComponents)...)
-	}
-
-	// Extract helmfile components
-	if helmfileComponents, ok := componentsMap["helmfile"].(map[string]any); ok {
-		allComponents = append(allComponents, lo.Keys(helmfileComponents)...)
-	}
-
-	// Extract packer components
-	if packerComponents, ok := componentsMap["packer"].(map[string]any); ok {
-		allComponents = append(allComponents, lo.Keys(packerComponents)...)
-	}
+	terraformComponents, _ := componentsMap["terraform"].(map[string]any)
+	helmfileComponents, _ := componentsMap["helmfile"].(map[string]any)
+	packerComponents, _ := componentsMap["packer"].(map[string]any)
+
+	size := 0
+	if terraformComponents != nil {
+		size += len(terraformComponents)
+	}
+	if helmfileComponents != nil {
+		size += len(helmfileComponents)
+	}
+	if packerComponents != nil {
+		size += len(packerComponents)
+	}
+
+	allComponents := make([]string, 0, size)
+	if terraformComponents != nil {
+		allComponents = append(allComponents, lo.Keys(terraformComponents)...)
+	}
+	if helmfileComponents != nil {
+		allComponents = append(allComponents, lo.Keys(helmfileComponents)...)
+	}
+	if packerComponents != nil {
+		allComponents = append(allComponents, lo.Keys(packerComponents)...)
+	}

internal/tui/utils/utils_test.go (4)

22-31: Use real newlines instead of literal "\n" inside raw strings.

Raw string + \n yields backslash-n, not a newline. Prefer actual multiline raw strings for readability.

Apply this diff:

-			code:        `package main\n\nfunc main() {\n\tfmt.Println("Hello, World!")\n}`,
+			code:        `package main
+
+func main() {
+	fmt.Println("Hello, World!")
+}`,

(Same pattern applies to other cases using backticks with \n.)

---

189-193: Ineffective assertion: NotNil on string is always true.

Assert emptiness instead.

Apply this diff:

-				// Empty input still produces some whitespace output.
-				assert.NotNil(t, output)
+				// Empty input should still produce some whitespace output.
+				assert.NotEmpty(t, output)

---

313-315: Make the link assertion case-insensitive to avoid flakiness.

Renderers may alter case/styling.

Apply this diff:

-				assert.Contains(t, output, "Click here")
+				assert.Contains(t, strings.ToLower(output), "click here")

---

415-416: Current check doesn’t prove wrapping.

"aaa" will appear regardless. Check for multiple lines instead.

Apply this diff:

-		// The output should wrap the long line.
-		assert.Contains(t, output, "aaa")
+		// The output should contain line breaks (wrapped).
+		assert.Greater(t, strings.Count(output, "\n"), 1)

pkg/schema/schema.go (1)

253-254: Add omitempty to TelemetrySettings.Logging

Add omitempty so default false isn't emitted in config dumps; apply to pkg/schema/schema.go (TelemetrySettings.Logging, ~line 253):

 type TelemetrySettings struct {
   Enabled  bool   `yaml:"enabled,omitempty" json:"enabled,omitempty" mapstructure:"enabled"`
   Endpoint string `yaml:"endpoint,omitempty" json:"endpoint,omitempty" mapstructure:"endpoint"`
   Token    string `yaml:"token,omitempty" json:"token,omitempty" mapstructure:"token"`
-  Logging  bool   `yaml:"logging" json:"logging" mapstructure:"logging"`
+  Logging  bool   `yaml:"logging,omitempty" json:"logging,omitempty" mapstructure:"logging"`
 }

• bindEnv exists: pkg/config/load.go binds "settings.telemetry.logging" to ATMOS_TELEMETRY_LOGGING.
• ATMOS_TELEMETRY_LOGGING is referenced in docs/tests.
• NewTelemetry propagates Options.Logging (pkg/telemetry/telemetry.go).
• PrintTelemetryDisclosure prints via utils.PrintfMarkdownToTUI -> stderr; tests assert stderr output.

pkg/utils/markdown_utils.go (1)

35-53: Good: Markdown UI to stderr matches guidelines.

Function is documented, handles nil renderer, and writes to stderr. Consider DRYing with PrintfMarkdown via a shared helper to reduce duplication.

Example refactor:

@@
-package utils
+package utils
@@
-import (
+import (
 	"fmt"
+	"io"
 	"os"
@@
 var render *markdown.Renderer
@@
-func PrintfMarkdown(format string, a ...interface{}) {
-	if render == nil {
-		_, err := os.Stdout.WriteString(fmt.Sprintf(format, a...))
+func printfMarkdownTo(w io.Writer, format string, a ...interface{}) {
+	if render == nil {
+		_, err := fmt.Fprintf(w, format, a...)
 		errUtils.CheckErrorAndPrint(err, "", "")
 		return
 	}
 	message := fmt.Sprintf(format, a...)
 	var md string
 	var renderErr error
 	md, renderErr = render.Render(message)
 	if renderErr != nil {
 		errUtils.CheckErrorPrintAndExit(renderErr, "", "")
 	}
-	_, err := os.Stdout.WriteString(fmt.Sprint(md + "\n"))
+	_, err := fmt.Fprint(w, md+"\n")
 	errUtils.CheckErrorAndPrint(err, "", "")
 }
 
+// PrintfMarkdown prints a message in Markdown format.
+func PrintfMarkdown(format string, a ...interface{}) {
+	printfMarkdownTo(os.Stdout, format, a...)
+}
@@
-func PrintfMarkdownToTUI(format string, a ...interface{}) {
-	if render == nil {
-		_, err := fmt.Fprintf(os.Stderr, format, a...)
-		errUtils.CheckErrorAndPrint(err, "", "")
-		return
-	}
-	message := fmt.Sprintf(format, a...)
-	var md string
-	var renderErr error
-	md, renderErr = render.Render(message)
-	if renderErr != nil {
-		errUtils.CheckErrorPrintAndExit(renderErr, "", "")
-	}
-	_, err := fmt.Fprint(os.Stderr, md+"\n")
-	errUtils.CheckErrorAndPrint(err, "", "")
-}
+func PrintfMarkdownToTUI(format string, a ...interface{}) {
+	printfMarkdownTo(os.Stderr, format, a...)
+}

pkg/config/config_test.go (1)

308-316: Harden the new test with error and bounds checks.

Guard against nil/empty cfg.Commands and assert no error before indexing.

Apply:

 		{
 			name: "valid import custom override",
 			setup: func(t *testing.T, dir string, tc testCase) {
 				changeWorkingDir(t, "../../tests/fixtures/scenarios/atmos-cli-imports-override")
 			},
 			assertions: func(t *testing.T, tempDirPath string, cfg *schema.AtmosConfiguration, err error) {
-				assert.Equal(t, "foo", cfg.Commands[0].Name)
+				require.NoError(t, err)
+				require.GreaterOrEqual(t, len(cfg.Commands), 1, "expected at least 1 command")
+				assert.Equal(t, "foo", cfg.Commands[0].Name)
 			},
 		},

tests/cli_test.go (2)

348-352: Good secret scrubbing; broaden token charset slightly.

PostHog tokens can include hyphens. Consider allowing - to avoid partial masking edge cases.

Apply:

-	posthogTokenRegex := regexp.MustCompile(`phc_[a-zA-Z0-9_]+`)
+	posthogTokenRegex := regexp.MustCompile(`phc_[a-zA-Z0-9_-]+`)

---

487-505: Switch from fatal exits to skip gating in TestMain — minor fix needed.
Package-level skip gating is implemented and tests call t.Skipf when skipReason != "". Remove the redundant t.Skipf at tests/cli_test.go:753.

pkg/telemetry/posthog_logger_test.go (2)

14-19: Stabilize global logger mutations with t.Cleanup.

Avoid leaking log level/output across tests by restoring both via t.Cleanup.

Apply:

- var buf bytes.Buffer
- log.SetOutput(&buf)
- defer log.SetOutput(io.Discard) // Reset output after test
- log.SetLevel(log.DebugLevel)
+ var buf bytes.Buffer
+ log.SetOutput(&buf)
+ prevLevel := log.GetLevel()
+ log.SetLevel(log.DebugLevel)
+ t.Cleanup(func() {
+   log.SetLevel(prevLevel)
+   log.SetOutput(io.Discard)
+ })

---

86-92: Restore log level in SilentLogger test too.

Mirror the cleanup pattern to avoid side effects.

- defer log.SetOutput(io.Discard) // Reset output after test
+ prevLevel := log.GetLevel()
+ t.Cleanup(func() {
+   log.SetLevel(prevLevel)
+   log.SetOutput(io.Discard)
+ })

pkg/merge/merge.go (1)

42-52: Avoid printing from library code; return wrapped errors only.

These Fprintln calls emit UI from pkg code and duplicate the returned error. Prefer just wrapping and returning; let callers decide how to present.

- _, _ = theme.Colors.Error.Fprintln(color.Error, err.Error()+"\n")
- return nil, fmt.Errorf("%w: failed to convert to YAML: %v", errUtils.ErrMerge, err)
+ return nil, fmt.Errorf("%w: failed to convert to YAML: %v", errUtils.ErrMerge, err)

Apply similarly at Lines 50-52 and 69-71.

pkg/downloader/file_downloader.go (1)

31-43: Optional: extract a default timeout constant.

Avoid repeated literals; improves readability and future configurability.

- func (fd *fileDownloader) Fetch(src, dest string, mode ClientMode, timeout time.Duration) error {
+ const defaultTimeout = 30 * time.Second
+ func (fd *fileDownloader) Fetch(src, dest string, mode ClientMode, timeout time.Duration) error {

And use defaultTimeout at call sites.

pkg/telemetry/telemetry_logger_selection_test.go (1)

15-30: Table-driven selection test is solid. Consider t.Parallel for subtests.

Parallelizing these subtests is safe and speeds up CI.

- t.Run(tt.name, func(t *testing.T) {
+ t.Run(tt.name, func(t *testing.T) {
+   t.Parallel()

pkg/merge/merge_test.go (2)

167-181: Consolidate duplicate nil-config tests.

These two tests exercise the same scenario. Consider a single table-driven test to cut duplication.

+func TestMerge_NilConfigVariants(t *testing.T) {
+  cases := []struct{
+    name   string
+    inputs []map[string]any
+  }{
+    {"simple", []map[string]any{{"foo":"bar"},{"foo":"baz"}}},
+    {"lists",  []map[string]any{{"list":[]string{"1"}},{"list":[]string{"2"}}}},
+  }
+  for _, tc := range cases {
+    t.Run(tc.name, func(t *testing.T) {
+      res, err := Merge(nil, tc.inputs)
+      assert.Nil(t, res)
+      assert.Error(t, err)
+      assert.True(t, errors.Is(err, errUtils.ErrMerge))
+      assert.True(t, errors.Is(err, errUtils.ErrAtmosConfigIsNil))
+    })
+  }
+}

Also applies to: 235-254

---

28-29: Fix lint: comments must end with periods.

Several comments miss trailing periods, which will trip godot.

- // Nil atmosConfig should return an error to prevent panic
+ // Nil atmosConfig should return an error to prevent panic.
- // Verify the error is properly wrapped
+ // Verify the error is properly wrapped.
- // Nil config should return an error
+ // Nil config should return an error.
- // Verify proper error wrapping
+ // Verify proper error wrapping.
- // This test verifies that Merge handles nil config gracefully
+ // This test verifies that Merge handles nil config gracefully.
- // Call Merge with nil config - this would panic without our fix
+ // Call Merge with nil config - this would panic without our fix.
- // Verify it returns an error instead of panicking
+ // Verify it returns an error instead of panicking.

Also applies to: 38-41, 172-173, 179-181, 236-239, 245-247, 249-254

pkg/telemetry/telemetry_test.go (3)

58-63: Reverse assert.Equal argument order (expected, actual).

Current calls use (actual, expected); swap to improve failure messages.

- assert.Equal(t, telemetry.isEnabled, enabled)
+ assert.Equal(t, enabled, telemetry.isEnabled)
- assert.Equal(t, telemetry.token, token)
+ assert.Equal(t, token, telemetry.token)
- assert.Equal(t, telemetry.endpoint, endpoint)
+ assert.Equal(t, endpoint, telemetry.endpoint)
- assert.Equal(t, telemetry.distinctId, distinctId)
+ assert.Equal(t, distinctId, telemetry.distinctId)

Also applies to: 97-102, 147-152, 197-202, 249-254, 298-303, 360-365, 422-427, 488-493

---

439-456: Use the expectedLogger field or remove it.

The table includes expectedLogger but never asserts it; either assert logger selection or drop the field.

- expectedLogger string // "PosthogLogger" or "SilentLogger"
...
- expectedLogger: "PosthogLogger",
+ // expected logger selection verified by telemetry.logging flag below
...
- expectedLogger: "SilentLogger",
+ // expected logger selection verified by telemetry.logging flag below

Also applies to: 481-499

---

24-63: Lint: ensure comment sentences end with periods.

A few comments here miss trailing periods; please fix to satisfy godot.

Also applies to: 68-75, 111-121, 161-171, 211-223, 263-275, 312-327, 377-393

pkg/config/load.go (1)

269-271: Comment periods.

Add trailing periods to newly added comment sentences to appease godot.

Also applies to: 323-324, 333-334, 342-345

pkg/filetype/filetype_by_extension_test.go (1)

18-55: Question mark/hash in local filenames.

You assert trimming “?” and “#” even for local paths (e.g., “is-this-json?.json” → “is-this-json”). If local files containing these chars should be supported literally on Unix, consider trimming only when the input looks like a URL (contains “://”). Otherwise keep as‑is.

pkg/utils/yaml_include_by_extension.go (1)

99-108: Remote URL detection.

Coverage is broad (http/s3/git/oci/etc.). Consider using net/url parsing in the future for stricter checks, but this is fine for now.

pkg/utils/yaml_include_by_extension_test.go (3)

87-93: Avoid process-wide chdir in tests.

Changing the working directory is global and can cause cross-test flakiness. Prefer absolute paths and keep CWD unchanged.

Example (apply similarly to each test):

- // Change to temp directory
- originalDir, err := os.Getwd()
- assert.NoError(t, err)
- err = os.Chdir(tempDir)
- assert.NoError(t, err)
- defer os.Chdir(originalDir)
+ // Stay in original CWD; use absolute paths instead.

- yamlFileContent, err := os.ReadFile("test_manifest.yaml")
+ yamlFileContent, err := os.ReadFile(manifestFile)

- manifest, err := UnmarshalYAMLFromFile[schema.AtmosSectionMapType](atmosConfig, string(yamlFileContent), "test_manifest.yaml")
+ manifest, err := UnmarshalYAMLFromFile[schema.AtmosSectionMapType](atmosConfig, string(yamlFileContent), manifestFile)

If keeping chdir, ensure no test in this package calls t.Parallel.

Also applies to: 206-212, 277-283, 347-353

---

126-130: Use assert.True for booleans.

Improves intent and failure messages.

- assert.Equal(t, true, yamlConfig["server"].(map[string]any)["enabled"])
+ assert.True(t, yamlConfig["server"].(map[string]any)["enabled"].(bool))

---

109-114: Reduce repetitive deep map assertions.

Consider a small helper to fetch component vars and typed lookups to cut duplication and panic risk on bad types. Happy to provide a helper if you want it added.

Also applies to: 126-129, 131-135, 136-147, 148-151, 228-236, 299-306, 372-384

pkg/telemetry/telemetry.go (3)

8-15: Remove duplicated doc comment block.

The TelemetryClientProvider comment appears twice. Keep one to satisfy godoc/godot.

-// TelemetryClientProvider is a function type that creates a PostHog client
-// given a token and configuration. This allows for dependency injection
-// and easier testing by providing mock implementations.
-// TelemetryClientProvider is a function type that creates a PostHog client
-// given a token and configuration. The configuration is passed by pointer to
-// avoid copying large structs and to allow tests to modify it.
+// TelemetryClientProvider is a function type that creates a PostHog client
+// given a token and configuration. The configuration is passed by pointer to
+// avoid copying large structs and to allow tests to modify it.

---

16-21: Ensure comments end with periods (godot).

Several inline comments don’t end with periods; golangci-lint godot may flag them. Add trailing periods to satisfy lint.

Run lint locally to confirm no godot violations remain.

Also applies to: 70-78, 80-87, 89-95, 104-110

---

64-68: Differentiate disabled vs missing token in debug logs.

Minor DX: separate messages help trace misconfig vs user opting out. Optional.

-	if !t.isEnabled || t.token == "" {
-		log.Debug("Telemetry is disabled, skipping capture")
+	if !t.isEnabled {
+		log.Debug("Telemetry disabled, skipping capture.")
+		return false
+	}
+	if t.token == "" {
+		log.Debug("Telemetry token missing, skipping capture.")
 		return false
 	}

pkg/downloader/get_git_test.go (3)

584-598: Rename test to reflect expectation (it asserts error).

The name says “Succeeds” but the test expects an error. Rename for clarity.

-func TestGetCustom_Succeeds_ClonePath_NoRefNoSSHKey(t *testing.T) {
+func TestGetCustom_ClonePath_NoRefNoSSHKey_Errors(t *testing.T) {

---

961-965: Fix contradictory comment.

The test asserts no error; update the comment.

-// Will error because our fake git doesn't actually work.
+// Expect success for the update path with the fake git setup.

---

441-461: Prefer strconv.Itoa over custom itoa helpers (nit).

Standard lib is clearer; drop duplicated int-to-string helpers in tests.

-func itoa(i int) string {
-  ...
-}
+// replace uses with: strconv.Itoa(i)

Remember to add:

+ "strconv"

Also applies to: 210-232

pkg/config/config_merge_test.go (1)

97-136: Solid, readable coverage of merge/load paths.

Subtests cover happy/error cases well; assertions are specific. Consider adding t.Parallel() within subtests where filesystem isolation allows it to speed up CI.

Also applies to: 137-167, 169-223, 224-250, 252-293, 295-304

pkg/telemetry/posthog_logger.go (2)

9-22: Make doc comment lines sentence‑terminated (godot).

End each line with a period to satisfy the linter.

-// PosthogLogger is an adapter that implements the posthog.Logger interface
-// using Atmos's charmbracelet/log. This ensures PostHog messages are properly
-// integrated with Atmos logging and respect log levels. It also prevents
-// PostHog errors from being printed directly to stdout/stderr.
+// PosthogLogger is an adapter that implements the posthog.Logger interface.
+// It uses Atmos's charmbracelet/log. This ensures PostHog messages are properly integrated with Atmos logging and respect log levels.
+// It also prevents PostHog errors from being printed directly to stdout/stderr.

---

24-29: Terminate inline comments with periods (godot).

Add periods to these inline comments to keep linters green.

-	// Convert printf-style to structured logging
+	// Convert printf-style to structured logging.
-	// Convert printf-style to structured logging at debug level
-	// to avoid cluttering user output with telemetry info
+	// Convert printf-style to structured logging at debug level.
+	// Avoid cluttering user output with telemetry info.
-	// Convert printf-style to structured logging
+	// Convert printf-style to structured logging.
-	// Only log PostHog errors at debug level to avoid polluting user output.
-	// Telemetry failures should not impact the user experience.
+	// Only log PostHog errors at debug level to avoid polluting user output.
+	// Telemetry failures should not impact the user experience.
-	// Convert printf-style to structured logging at debug level
-	// to avoid cluttering user output with telemetry info
+	// Convert printf-style to structured logging at debug level.
+	// Avoid cluttering user output with telemetry info.
-	// Convert printf-style to structured logging at debug level
+	// Convert printf-style to structured logging at debug level.

Also applies to: 31-39, 41-46, 48-55, 57-65, 67-74

cmd/cmd_utils.go (1)

507-532: Route the leading newline to stderr.

The fmt.Println() here still writes to stdout before the markdown emit, so the missing-config banner leaks a blank line into data streams. Drop this call and let the existing PrintfMarkdownToTUI("\n") supply the spacing so the whole banner stays on stderr.

-	fmt.Println()

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: samtholiya
PR: cloudposse/atmos#955
File: tests/snapshots/TestCLICommands_atmos_validate_editorconfig_--help.stdout.golden:0-0
Timestamp: 2025-01-19T15:49:15.593Z
Learning: In future commits, the help text for Atmos CLI commands should be limited to only show component and stack parameters for commands that actually use them. This applies to the example usage section in command help text.

Learnt from: CR
PR: cloudposse/atmos#0
File: CLAUDE.md:0-0
Timestamp: 2025-10-06T02:10:05.491Z
Learning: Applies to cmd/root.go : Telemetry: standard Cobra commands added to RootCmd get telemetry via RootCmd.ExecuteC() (see cmd/root.go:174); do not add extra telemetry for standard paths.

Learnt from: samtholiya
PR: cloudposse/atmos#1466
File: toolchain/list.go:39-42
Timestamp: 2025-09-13T18:06:07.674Z
Learning: In the cloudposse/atmos repository, for UI messages in the toolchain package, use utils.PrintfMessageToTUI instead of log.Error or fmt.Fprintln(os.Stderr, ...). Import pkg/utils with alias "u" to follow the established pattern.

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to cmd/**/*.go : Use Cobra's recommended command structure with a root command and subcommands

Learnt from: samtholiya
PR: cloudposse/atmos#1068
File: cmd/vendor_pull.go:31-31
Timestamp: 2025-02-18T13:18:53.146Z
Learning: Error checking is not required for cobra.Command.RegisterFlagCompletionFunc calls as these are static configurations done at init time.

Learnt from: osterman
PR: cloudposse/atmos#1498
File: website/src/components/Screengrabs/atmos-terraform-metadata--help.html:25-55
Timestamp: 2025-10-07T00:25:16.323Z
Learning: In Atmos CLI, subcommands inherit flags from their parent commands via Cobra's command inheritance. For example, `atmos terraform metadata --help` shows `--affected` and related flags inherited from the parent `terraform` command (defined in cmd/terraform.go), even though the metadata subcommand doesn't explicitly define these flags. This is expected Cobra behavior and auto-generated help screengrabs accurately reflect this inheritance.

Learnt from: Listener430
PR: cloudposse/atmos#1149
File: tests/snapshots/TestCLICommands_atmos_vendor_pull_ssh.stderr.golden:7-7
Timestamp: 2025-03-18T12:26:25.329Z
Learning: In the Atmos project, typos or inconsistencies in test snapshot files (such as "terrafrom" instead of "terraform") may be intentional as they capture the exact output of commands and should not be flagged as issues requiring correction.

Learnt from: CR
PR: cloudposse/atmos#0
File: CLAUDE.md:0-0
Timestamp: 2025-10-06T02:10:05.491Z
Learning: Applies to cmd/**/*.go : For CLI examples, load content via //go:embed and render with utils.PrintfMarkdown(); register examples in cmd/markdown_help.go.

Learnt from: CR
PR: cloudposse/atmos#0
File: CLAUDE.md:0-0
Timestamp: 2025-10-06T02:10:05.491Z
Learning: Applies to cmd/markdown/*_usage.md : Store CLI example usage in embedded markdown files named atmos_<command>_<subcommand>_usage.md under cmd/markdown/.

cmd/root_test.go (1)

444-521: Solid test coverage for completion command detection.

The test structure is well-organized and the issues from previous reviews (missing loop, misplaced logic) have been resolved. The table-driven approach properly exercises isCompletionCommand across the key scenarios.

Consider two optional enhancements:

1. Make nil command handling explicit: The "no args" case passes nil when len(tt.args) <= 1. Add an explicit test case that documents this:

+		{
+			name:     "nil command",
+			args:     []string{"atmos"},
+			expected: false,
+		},

2. Test simultaneous environment variables: Add a case where both COMP_LINE and _ARGCOMPLETE are set to verify the function handles multiple signals correctly:

+		{
+			name:     "both COMP_LINE and _ARGCOMPLETE set",
+			args:     []string{"atmos", "terraform"},
+			compLine: "atmos terraform ",
+			argComp:  "1",
+			expected: true,
+		},

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: cloudposse/atmos#0
File: .cursor/rules/atmos-rules.mdc:0-0
Timestamp: 2025-09-23T02:30:42.362Z
Learning: Applies to cmd/**/*.go : Use Cobra's recommended command structure with a root command and subcommands