Closed
Conversation
Make the token writing interface support any type.
Contributor
There was a problem hiding this comment.
golangci-lint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1424 +/- ##
==========================================
- Coverage 55.61% 54.55% -1.07%
==========================================
Files 273 287 +14
Lines 28620 30190 +1570
==========================================
+ Hits 15918 16470 +552
- Misses 10919 11856 +937
- Partials 1783 1864 +81
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a866f80 to
a1a106f
Compare
|
💥 This pull request now has conflicts. Could you fix it @Benbentwo? 🙏 |
a1a106f to
942a63a
Compare
This was referenced Sep 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Replaces PR #1389
Atmos Auth
This pull request introduces a new authentication framework to the Atmos CLI, adds a demo project for auth configuration, and improves CI/CD workflows to support OIDC and integration testing. The most important changes are the addition of new CLI commands for authentication, a comprehensive demo project showcasing auth configuration, and updates to CI workflows to test these features.
Authentication CLI enhancements
auth- Helper Command containing other commandslogin- Sign into an identity - forces refresh of credentialsuser- User command root.configure- Configure an Identities Credentials in keystore.Demo project for authentication
examples/demo-authproject, including a sampleatmos.yamlwith a detailedauthsection, Terraform component, stack manifest, and supporting files to demonstrate and test authentication flows (examples/demo-auth/README.md,examples/demo-auth/atmos.yaml,examples/demo-auth/components/terraform/whoami/*,examples/demo-auth/stacks/deploy/dev/demo.yaml). [1] [2] [3] [4] [5] [6] [7]CI/CD and integration testing improvements
oidc-localstack-integration.yml) to run unit and OIDC + LocalStack integration tests, ensuring authentication features are validated in CI (.github/workflows/oidc-localstack-integration.yml).id-tokenpermissions for OIDC testing (.github/workflows/test.yml). [1] [2] [3]Dependency updates
go.mod). [1] [2] [3] [4] [5]Utility and codebase improvements
cmd/docs.go). [1] [2] [3]These changes collectively introduce robust authentication support in Atmos, provide a demo for users and CI, and ensure the codebase is ready for advanced identity and access management workflows.