Skip to content

WIP Atmos Auth#1389

Closed
Benbentwo wants to merge 56 commits intocloudposse:mainfrom
Benbentwo:feature/dev-3508-remove-leapp-replace-with-aws-sso-script
Closed

WIP Atmos Auth#1389
Benbentwo wants to merge 56 commits intocloudposse:mainfrom
Benbentwo:feature/dev-3508-remove-leapp-replace-with-aws-sso-script

Conversation

@Benbentwo
Copy link
Member

@Benbentwo Benbentwo commented Aug 1, 2025

what

  • Initial configuration for Atmos authentication, which will manage AWS profiles, signing in, and ultimately replace Leapp.

why

  • Leapp is an amazing tool, but unfortunately, it's no longer being maintained. As such, we need to find a solution that will authenticate users to AWS and to our reference architecture.

@mergify mergify bot added triage Needs triage wip Work in Progress: Not ready for final review or merge labels Aug 1, 2025
osterman
osterman reviewed Aug 2, 2025
View reviewed changes
@Benbentwo Benbentwo force-pushed the feature/dev-3508-remove-leapp-replace-with-aws-sso-script branch from 0ffcc20 to e5e3018 Compare August 4, 2025 22:05
@Benbentwo Benbentwo force-pushed the feature/dev-3508-remove-leapp-replace-with-aws-sso-script branch from ba65521 to ae12590 Compare August 7, 2025 18:26
@mergify
Copy link

mergify bot commented Aug 7, 2025

💥 This pull request now has conflicts. Could you fix it @Benbentwo? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Aug 7, 2025
@Benbentwo Benbentwo force-pushed the feature/dev-3508-remove-leapp-replace-with-aws-sso-script branch from db63878 to f77ed3e Compare August 8, 2025 16:58
coderabbitai[bot]
coderabbitai bot previously approved these changes Aug 8, 2025
View reviewed changes
@mergify mergify bot removed the triage Needs triage label Aug 8, 2025
osterman
osterman reviewed Aug 8, 2025
View reviewed changes
osterman
osterman reviewed Aug 8, 2025
View reviewed changes
pkg/utils/url_utils.go
"runtime"
)

func OpenUrl(URL string) error {
Copy link
Member

@osterman osterman Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update docs to use this function, but make this function more robust like the one in docs. For example, when running tests, we don't want to launch the browser.

atmos/cmd/docs.go

Line 130 in 9179bd8

err = exec.Command("xdg-open", atmosDocsURL).Start()

coderabbitai[bot]
coderabbitai bot previously approved these changes Aug 27, 2025
View reviewed changes
@mergify
Copy link

mergify bot commented Aug 27, 2025

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Aug 27, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 27, 2025
View reviewed changes
internal/auth/aws_assume_role.go
@@ -0,0 +1,201 @@
package auth

Check failure

Code scanning / golangci-lint

: # github.com/cloudposse/atmos/internal/auth [github.com/cloudposse/atmos/internal/auth.test] internal/auth/utils_aws_test.go:182:94: not enough arguments in call to CreateAwsFilesAndUpdateEnvVars have (*schema.ConfigAndStacksInfo, string, string, string) want (*schema.ConfigAndStacksInfo, string, string, string, string, string) Error

: # github.com/cloudposse/atmos/internal/auth [github.com/cloudposse/atmos/internal/auth.test]
internal/auth/utils_aws_test.go:182:94: not enough arguments in call to CreateAwsFilesAndUpdateEnvVars
have (*schema.ConfigAndStacksInfo, string, string, string)
want (*schema.ConfigAndStacksInfo, string, string, string, string, string)
@Benbentwo
Copy link
Member Author

Benbentwo commented Aug 27, 2025

Closing in favor of a non fork.

@Benbentwo Benbentwo closed this Aug 27, 2025
@mergify mergify bot removed wip Work in Progress: Not ready for final review or merge needs-cloudposse Needs Cloud Posse assistance labels Aug 27, 2025
@mergify
Copy link

mergify bot commented Aug 27, 2025

⚠️ The sha of the head commit of this PR conflicts with #1424. Mergify cannot evaluate rules on this PR. ⚠️

@Benbentwo Benbentwo mentioned this pull request Aug 27, 2025
Closed
@Benbentwo Benbentwo deleted the feature/dev-3508-remove-leapp-replace-with-aws-sso-script branch August 27, 2025 18:49
@mergify
Copy link

mergify bot commented Aug 30, 2025

⚠️ The sha of the head commit of this PR conflicts with #1424. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osterman osterman osterman left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Benbentwo @osterman