Skip to content

Add mandatory static error handling requirements to CLAUDE.md#1420

Merged
osterman merged 1 commit intoadd-claude-mdfrom
claude
Aug 26, 2025
Merged

Add mandatory static error handling requirements to CLAUDE.md#1420
osterman merged 1 commit intoadd-claude-mdfrom
claude

Conversation

@osterman
Copy link
Member

Summary

  • Updated CLAUDE.md error handling section to enforce use of static errors
  • Added examples and patterns for proper error wrapping to prevent golangci-lint warnings

Test plan

  • Documentation update only - no code changes requiring tests
  • Clear examples provided for correct vs incorrect error handling patterns

🤖 Generated with Claude Code

Update error handling section to enforce use of static errors defined in errors/errors.go
to comply with golangci-lint requirements and prevent dynamic error warnings.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@osterman osterman requested a review from a team as a code owner August 26, 2025 22:53
@osterman osterman merged commit 623848f into add-claude-md Aug 26, 2025
9 of 10 checks passed
@osterman osterman deleted the claude branch August 26, 2025 22:54
@mergify mergify bot added stacked Stacked triage Needs triage and removed triage Needs triage labels Aug 26, 2025
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.45%. Comparing base (bc7ab0b) to head (26fcca9).
⚠️ Report is 3 commits behind head on add-claude-md.

Additional details and impacted files
@@              Coverage Diff               @@
##           add-claude-md    #1420   +/-   ##
==============================================
  Coverage          55.45%   55.45%           
==============================================
  Files                273      273           
  Lines              28620    28620           
==============================================
  Hits               15870    15870           
- Misses             10962    10963    +1     
+ Partials            1788     1787    -1     
Flag Coverage Δ
unittests 55.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

osterman added a commit that referenced this pull request Aug 27, 2025
* Add comprehensive CLAUDE.md development guide

This document provides essential guidance for future Claude Code instances working with the Atmos codebase, including:

- Essential development commands (build, test, lint)
- Project architecture and core concepts
- Mandatory requirements for test coverage (80%), environment variables, logging, output streams
- Schema update requirements for all configuration changes
- Theme/styling consistency guidelines
- Template integration requirements
- Cross-platform compatibility standards
- Multi-provider interface patterns with mocking
- Documentation requirements using Docusaurus with definition lists
- CLI command structure with embedded markdown examples

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Add pull request template requirements to CLAUDE.md

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix label name to no-release

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Add telemetry integration requirements to CLAUDE.md

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Correct TUI output conventions to use utils.PrintfMessageToTUI

- Use utils.PrintfMessageToTUI() as the preferred method for UI messages
- Document direct stderr as acceptable last resort
- Fix typo: 'pi' -> 'piping'

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix test naming examples to follow best practices

- Use descriptive test names that describe behavior being tested
- Remove 'TestBugFix' anti-pattern examples
- Show proper Go test naming conventions
- Include both success and error condition examples

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Add comprehensive file organization principles to CLAUDE.md

Establishes Go idioms for file structure:
- Prefer many small, focused files over few large files
- One implementation per file for interface implementations
- Test file naming symmetry with implementation files
- Clear examples using store interface pattern
- Domain-based package organization

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Add reference to authoritative store provider registry

- Point to pkg/store/registry.go for up-to-date list of supported stores
- Google Secret Manager is actually implemented and registered in the codebase

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Add mandatory static error handling requirements to CLAUDE.md (#1420)

Update error handling section to enforce use of static errors defined in errors/errors.go
to comply with golangci-lint requirements and prevent dynamic error warnings.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stacked Stacked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant