Execute Atmos YAML functions when running the command `atmos terraform output` by aknysh · Pull Request #1033 · cloudposse/atmos

aknysh · 2025-02-06T05:07:01Z

what

Execute Atmos YAML functions when running the command atmos terraform output

why

atmos terraform output requires processing of YAML functions, and it was not included in https://github.com/cloudposse/atmos/releases/tag/v1.160.0

Summary by CodeRabbit

Chore
- Refreshed several third-party libraries to improve stability, performance, and security.
Refactor
- Enhanced internal processing logic to support an expanded set of command options for improved configuration handling.

coderabbitai · 2025-02-06T05:11:32Z

📝 Walkthrough

Walkthrough

The pull request updates various dependency versions in the go.mod file—mostly minor version increments or commit hash updates. Additionally, the needProcessTemplatesAndYamlFunctions function in internal/exec/terraform_utils.go has been refined by renaming the variable commands to commandsThatNeedFuncProcessing and expanding its list to include the "output" command.

Changes

File(s)	Change Summary
`go.mod`	Updated multiple dependency versions with minor version increments and commit hash updates. For example, dependencies like `github.com/aws/aws-sdk-go-v2` (v1.36.0 → v1.36.1) and others such as `.../config`, `.../service/ssm`, `jfrog-client-go`, etc., were updated.
`internal/exec/terraform_utils.go`	Renamed variable `commands` to `commandsThatNeedFuncProcessing` in the `needProcessTemplatesAndYamlFunctions` function and added `"output"` to the list of commands requiring Go template and Atmos YAML processing.

Suggested labels

minor

Suggested reviewers

osterman
mcalhoun

Tip

🌐 Web search-backed reviews and chat

We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
You can disable this feature by setting web_search: false in the knowledge_base settings.
Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 110cc7a and f792f7e.

⛔ Files ignored due to path filters (1)

go.sum is excluded by !**/*.sum

📒 Files selected for processing (2)

go.mod (12 hunks)
internal/exec/terraform_utils.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Build (macos-latest, macos)
GitHub Check: Build (windows-latest, windows)
GitHub Check: Summary

🔇 Additional comments (2)

internal/exec/terraform_utils.go (1)

92-100: LGTM! Clear and focused change.

The variable rename to commandsThatNeedFuncProcessing improves code clarity, and adding "output" to the list aligns perfectly with the PR objective to enable YAML function processing for the terraform output command.
go.mod (1)

11-14: Verify security implications of dependency updates.

The updates include security-related packages. Let's verify there are no known vulnerabilities in the updated versions.

Also applies to: 37-37, 73-73, 86-86, 95-99, 104-109, 125-125, 132-132, 162-162, 205-205, 212-212, 240-240, 270-270, 291-294
✅ Verification successful

🏁 Script executed:
#!/bin/bash
# Description: Check for security advisories for key updated packages

# Check for security advisories for cloudflare/circl
gh api graphql -f query='
{
  securityVulnerabilities(first: 5, ecosystem: GO, package: "github.com/cloudflare/circl") {
    nodes {
      advisory {
        summary
        severity
        publishedAt
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'

# Check for security advisories for aws-sdk-go-v2
gh api graphql -f query='
{
  securityVulnerabilities(first: 5, ecosystem: GO, package: "github.com/aws/aws-sdk-go-v2") {
    nodes {
      advisory {
        summary
        severity
        publishedAt
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'
Length of output: 1128

Security Implications Verified for Dependency Updates

The shell script output confirms that vulnerabilities for github.com/cloudflare/circl affect only versions prior to 1.3.7 (with the highest severity being HIGH), and updating to version 1.6.0 ensures that known security issues are patched. Additionally, the checks for github.com/aws/aws-sdk-go-v2 revealed no reported vulnerabilities, which supports that its update is safe. No further security concerns were identified in the updated dependencies.

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary or @auto-summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @auto-title anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-02-06T14:42:58Z

These changes were released in v1.160.2.

…m output` (#1033) * updates * updates * updates

aknysh added 3 commits February 5, 2025 23:28

updates

7967a44

updates

fbb055a

updates

f792f7e

aknysh added the patch A minor, backward compatible change label Feb 6, 2025

aknysh requested a review from osterman February 6, 2025 05:07

aknysh self-assigned this Feb 6, 2025

aknysh requested a review from a team as a code owner February 6, 2025 05:07

coderabbitai bot approved these changes Feb 6, 2025

View reviewed changes

mcalhoun approved these changes Feb 6, 2025

View reviewed changes

osterman approved these changes Feb 6, 2025

View reviewed changes

aknysh merged commit 845aeb5 into main Feb 6, 2025
45 of 46 checks passed

aknysh deleted the fix-terraform-commands-2 branch February 6, 2025 13:57

Cerebrovinny pushed a commit that referenced this pull request Feb 9, 2025

Execute Atmos YAML functions when running the command `atmos terrafor…

bfba487

…m output` (#1033) * updates * updates * updates

coderabbitai bot mentioned this pull request Mar 18, 2025

Add CLI flags to atmos terraform commands to control processing the templates and YAML functions in Atmos stack manifests #1157

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Execute Atmos YAML functions when running the command `atmos terraform output`#1033

Execute Atmos YAML functions when running the command `atmos terraform output`#1033
aknysh merged 3 commits intomainfrom
fix-terraform-commands-2

aknysh commented Feb 6, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 6, 2025

Walkthrough

Changes

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

aknysh commented Feb 6, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

what

why

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 6, 2025

Walkthrough

Changes

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aknysh commented Feb 6, 2025 •

edited by coderabbitai bot

Loading