Skip to content

fix typo in Redis store error message#1022

Merged
mcalhoun merged 5 commits intomainfrom
fix-type-in-redis-error-message
Feb 4, 2025
Merged

fix typo in Redis store error message#1022
mcalhoun merged 5 commits intomainfrom
fix-type-in-redis-error-message

Conversation

@mcalhoun
Copy link
Contributor

@mcalhoun mcalhoun commented Feb 4, 2025 •
edited by coderabbitai bot
Loading

what

  • Fixed environment variable name from REDIS_URL to ATMOS_REDIS_URL in error message

why

  • Error message was referencing incorrect environment variable name
  • Ensures error message matches the actual environment variable being checked in the code
  • Helps developers quickly identify and fix configuration issues

Summary by CodeRabbit

  • Bug Fixes
    • Revised the error message to clearly specify which environment variable is required for the Redis connection configuration, ensuring better clarity for users during setup.

@mcalhoun mcalhoun mentioned this pull request Feb 4, 2025
Merged
@mcalhoun Graphite App
Copy link
Contributor Author

mcalhoun commented Feb 4, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mcalhoun mcalhoun added the no-release Do not create a new release (wait for additional code changes) label Feb 4, 2025 — with Graphite App
@mcalhoun mcalhoun marked this pull request as ready for review February 4, 2025 19:14
@mcalhoun mcalhoun requested a review from a team as a code owner February 4, 2025 19:14
@mcalhoun mcalhoun changed the base branch from add-store-defaults to main February 4, 2025 19:16
@mcalhoun mcalhoun changed the base branch from main to add-store-defaults February 4, 2025 19:17
osterman
osterman previously approved these changes Feb 4, 2025
View reviewed changes
Base automatically changed from add-store-defaults to main February 4, 2025 21:24
@mcalhoun mcalhoun dismissed osterman’s stale review February 4, 2025 21:24

The base branch was changed.

@mcalhoun mcalhoun merged commit 300ca0f into main Feb 4, 2025
13 checks passed
@mcalhoun mcalhoun deleted the fix-type-in-redis-error-message branch February 4, 2025 21:26
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes update the error message in the getRedisOptions function within pkg/store/redis_store.go. Instead of asking for the REDIS_URL environment variable, the function now specifies that the ATMOS_REDIS_URL environment variable must be set when no URL is provided. No other logic or public interface modifications were made.

Changes

File Change Summary
pkg/store/redis_store.go Updated error message in getRedisOptions to refer to ATMOS_REDIS_URL instead of REDIS_URL.

Suggested labels

patch

Suggested reviewers

  • johncblandii
  • aknysh

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92f70c1 and 18ed762.

📒 Files selected for processing (1)
  • pkg/store/redis_store.go (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or @auto-summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @auto-title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

These changes were released in v1.159.0.

Cerebrovinny pushed a commit that referenced this pull request Feb 9, 2025
@coderabbitai @autofix-ci @Cerebrovinny
fix typo in Redis store error message (#1022)
6429473 
* allow user to specify default value when using store

* Update internal/exec/yaml_func_store_test.go

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* allow user to specify default value when using store

* fix typo in Redis store error message

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osterman osterman osterman approved these changes

Assignees

No one assigned

Labels

no-release Do not create a new release (wait for additional code changes)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mcalhoun @osterman